Second Refactoring of IISPH Code (#928)

* Refactoring 2

* Fix error from rebase

* Format changed

* Add Neighborhood search as argument for the trixi_include function to the dam_break_2d_iisph file

* Fix error that occured in the test file

* Change return in calculate_sum_d_ij_pj!

* Remove allocations in the pressure_solve_iteration function

* Change format with JuliaFormatter

* Format change

* Put together calculate_diagonal_elements function and calculate_predicted_density function

* Fix allocations in the pressure solve function

* Change format with JuliaFormatter

* Changes from PR Review

* Move predict advection function into the update quantities function

* Changes from PR review

* Add if statement for the IISPH tests during allocations with Julia version 1.10

---------

Co-authored-by: Niklas Neher <[email protected]>

Author: noahstruschka

examples/fluid/dam_break_2d_iisph.jl

@@ -37,6 +37,7 @@ fluid_system = ImplicitIncompressibleSPHSystem(tank.fluid, smoothing_kernel,
 # Run the dam break simulation with these changes
 trixi_include(@__MODULE__,
               joinpath(examples_dir(), "fluid", "dam_break_2d.jl"),
+              neighborhood_search=GridNeighborhoodSearch{2}(),
               viscosity_fluid=ViscosityAdami(nu=nu),
               smoothing_kernel=smoothing_kernel,
               smoothing_length=smoothing_length,

src/general/semidiscretization.jl

@@ -570,6 +570,8 @@ function update_systems_and_nhs(v_ode, u_ode, semi, t)
         update_quantities!(system, v, u, v_ode, u_ode, semi, t)
     end
 
+    update_implicit_sph!(semi, v_ode, u_ode, t)
+
     # Perform correction and pressure calculation
     foreach_system(semi) do system
         v = wrap_v(v_ode, system, semi)