Skip to content

Conversation

@efaulhaber
Copy link
Member

@efaulhaber efaulhaber commented Jan 16, 2025

Why did this work before!?
@efaulhaber efaulhaber self-assigned this Jan 16, 2025
@efaulhaber
Copy link
Member Author

@efaulhaber efaulhaber closed this Jan 16, 2025
@efaulhaber efaulhaber reopened this Jan 16, 2025
@codecov
Copy link

codecov bot commented Jan 16, 2025

Codecov Report

Attention: Patch coverage is 75.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 69.88%. Comparing base (e80d820) to head (a9bf66e).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
test/count_allocations.jl 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #703      +/-   ##
==========================================
- Coverage   69.89%   69.88%   -0.02%     
==========================================
  Files          87       87              
  Lines        5475     5476       +1     
==========================================
  Hits         3827     3827              
- Misses       1648     1649       +1     
Flag Coverage Δ
unit 69.88% <75.00%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@efaulhaber efaulhaber marked this pull request as ready for review January 17, 2025 10:47
LasNikas
LasNikas previously approved these changes Jan 17, 2025
@LasNikas LasNikas enabled auto-merge (squash) January 17, 2025 10:51
svchb
svchb previously approved these changes Jan 17, 2025
@svchb svchb disabled auto-merge January 17, 2025 12:56
@efaulhaber efaulhaber dismissed stale reviews from svchb and LasNikas via a9bf66e January 17, 2025 14:50
@svchb svchb enabled auto-merge (squash) January 17, 2025 15:59
@svchb svchb merged commit 7c537a3 into trixi-framework:main Jan 17, 2025
13 checks passed
@efaulhaber efaulhaber deleted the drop-julia19 branch January 17, 2025 16:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Increase minimum supported Julia version to v1.10

3 participants