Apply suggestions from code review

Co-authored-by: Andrew Winters <andrew.ross.winters@liu.se>

Author: patrickersing

examples/tree_1d_dgsem/elixir_shallowwater_moments_convergence.jl

@@ -38,8 +38,7 @@ sum_B = [sum(equations.B[i, j, k] * a[k] * Dx(h * a[j]) for j in 1:n, k in 1:n)
 
 # additional moment equations 
 mom_eqs = [Dt(h * a[i]) + Dx(2 * h * v * a[i] + sum_A[i]) - v * Dx(h * a[i]) + sum_B[i]
-           for
-           i in 1:n]
+           for i in 1:n]
 
 # PDE Source Terms
 eqs = [

examples/tree_1d_dgsem/elixir_shallowwater_moments_well_balanced.jl

@@ -8,9 +8,9 @@ using TrixiShallowWater
 equations = ShallowWaterMomentEquations1D(gravity = 9.812, H0 = 1.75,
                                           n_moments = 2)
 
+# This initial condition can also be used together with `ShallowWaterLinearizedMomentEquations1D`.
 function initial_condition_well_balanced(x, t,
-                                         equations::Union{ShallowWaterMomentEquations1D,
-                                                          ShallowWaterLinearizedMomentEquations1D})
+                                         equations::ShallowWaterMomentEquations1D)
     # Initial lake-at-rest configuration
     H = 1.75
     v = 0.0

src/equations/moment_matrices.jl

@@ -59,7 +59,7 @@ function compute_A_tensor(B::Array{RealT, 3}) where {RealT}
     A = Array{RealT, 3}(zeros(RealT, N, N, N))  # initialize the A tensor
 
     for i in 1:N, j in 1:N, k in 1:N
-        A[i, j, k] = -(2i + 1) * (B[i, j, k] / (2i + 1) + B[k, j, i] / (2k + 1))
+        A[i, j, k] = -(2 * i + 1) * (B[i, j, k] / (2 * i + 1) + B[k, j, i] / (2 * k + 1))
     end # i, j, k
 
     return A

src/equations/shallow_water_moments_1d.jl

@@ -59,7 +59,7 @@ struct ShallowWaterMomentEquations1D{NVARS, NMOMENTS, RealT <: Real} <:
     function ShallowWaterMomentEquations1D{NVARS, NMOMENTS, RealT}(gravity::RealT,
                                                                    H0::RealT,
                                                                    n_moments::Integer,
-                                                                   A,
+                                                                   A::Array{RealT, 3},
                                                                    B::Array{RealT, 3},
                                                                    C::Array{RealT, 2},
                                                                    nu::RealT,