Skip to content

allow Trixi.jl v0.16#133

Merged
ranocha merged 3 commits intomainfrom
hr/trixi_v016
Mar 28, 2026
Merged

allow Trixi.jl v0.16#133
ranocha merged 3 commits intomainfrom
hr/trixi_v016

Conversation

@ranocha
Copy link
Copy Markdown
Member

@ranocha ranocha commented Mar 26, 2026

It looks like there are no downgrade tests in TrixiShallowWater.jl. If so, we cannot test both the old version v0.15 and the new version v0.16 of Trixi.jl in CI. I would like to avoid supporting versions that are not tested in CI. Thus, I see two options here:

  • Restrict TrixiShallowWater.jl to Trixi.jl v0.16 (although this is not required in terms of features).
  • Add downgrade CI tests similar to Trixi.jl.

What do you think about this, @andrewwinters5000 and @patrickersing?

@codecov
Copy link
Copy Markdown

codecov bot commented Mar 26, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 99.28%. Comparing base (01ae544) to head (483ac79).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #133   +/-   ##
=======================================
  Coverage   99.28%   99.28%           
=======================================
  Files          96       96           
  Lines        5146     5146           
=======================================
  Hits         5109     5109           
  Misses         37       37           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@andrewwinters5000
Copy link
Copy Markdown
Member

I see in Trixi the downgrade runs the test/test_threaded.jl which includes a smattering of elixirs across the different mesh types and features. We would need to assemble some small subset of test elixirs to do the same I suppose. And then we could add a Downgrade.yml to the CI workflow.

@ranocha
Copy link
Copy Markdown
Member Author

ranocha commented Mar 27, 2026

Yes, this would be ideal, I think.

@patrickersing
Copy link
Copy Markdown
Member

We already have a collection of representative tests in test_upstream.jl. Should we just reuse the same testset for the downgrade testing?

@patrickersing
Copy link
Copy Markdown
Member

We have added a downgrade CI test in #134

@ranocha ranocha marked this pull request as ready for review March 27, 2026 20:01
@ranocha
Copy link
Copy Markdown
Member Author

ranocha commented Mar 27, 2026

Thanks! Let's see what CI tells us.

Copy link
Copy Markdown
Member

@patrickersing patrickersing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! All CI tests have passed.

@ranocha ranocha merged commit 641d145 into main Mar 28, 2026
19 checks passed
@ranocha ranocha deleted the hr/trixi_v016 branch March 28, 2026 10:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants