Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #133 +/- ##
=======================================
Coverage 99.28% 99.28%
=======================================
Files 96 96
Lines 5146 5146
=======================================
Hits 5109 5109
Misses 37 37 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
I see in Trixi the downgrade runs the |
|
Yes, this would be ideal, I think. |
|
We already have a collection of representative tests in |
|
We have added a downgrade CI test in #134 |
|
Thanks! Let's see what CI tells us. |
patrickersing
left a comment
There was a problem hiding this comment.
LGTM! All CI tests have passed.
It looks like there are no downgrade tests in TrixiShallowWater.jl. If so, we cannot test both the old version v0.15 and the new version v0.16 of Trixi.jl in CI. I would like to avoid supporting versions that are not tested in CI. Thus, I see two options here:
What do you think about this, @andrewwinters5000 and @patrickersing?