Skip to content

Commit bc9a5cf

Browse files
committed
conditionally disable warning
1 parent 39e92e6 commit bc9a5cf

File tree

1 file changed

+10
-5
lines changed

1 file changed

+10
-5
lines changed

.github/workflows/ci.yml

Lines changed: 10 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -52,7 +52,7 @@ jobs:
5252
# Necessary such that libtrixi will not use its own default for the depot path
5353
JULIA_DEPOT_PATH: ~/.julia
5454
# This seems to fix some stalling C tests
55-
# JULIA_NUM_THREADS: 1
55+
JULIA_NUM_THREADS: 1
5656
steps:
5757
- name: Checkout repository
5858
uses: actions/checkout@v6
@@ -117,25 +117,30 @@ jobs:
117117
118118
- name: Configure (test_type == 'regular')
119119
if: ${{ matrix.test_type == 'regular' }}
120-
# remove -Wno-error=unused-parameter once https://github.com/JuliaLang/julia/pull/57681 is in the release
120+
# remove once https://github.com/JuliaLang/julia/pull/57681 is in the release
121+
with:
122+
c_flags: ${{ matrix.julia_version == '1.12' && '-Wno-error=unused-parameter' || '' }}
121123
run: |
122124
mkdir build
123125
cd build
124126
cmake .. -DCMAKE_INSTALL_PREFIX=../install \
125127
-DCMAKE_BUILD_TYPE=Release \
126-
-DCMAKE_C_FLAGS="-Wno-error=unused-parameter" \
128+
-DCMAKE_C_FLAGS="${INPUT_C_FLAGS}" \
127129
-DT8CODE_ROOT=$PWD/../t8code-local/prefix \
128130
-DENABLE_TESTING=ON -DJULIA_PROJECT_PATH=../libtrixi-julia
129131
130132
- name: Configure (test_type == 'coverage')
131133
if: ${{ matrix.test_type == 'coverage' }}
134+
# remove once https://github.com/JuliaLang/julia/pull/57681 is in the release
135+
with:
136+
c_flags: ${{ matrix.julia_version == '1.12' && '-Wno-error=unused-parameter' || '' }}
132137
run: |
133138
mkdir build
134139
cd build
135140
cmake .. -DCMAKE_INSTALL_PREFIX=../install \
136141
-DCMAKE_BUILD_TYPE=Debug \
137142
-DT8CODE_ROOT=$PWD/../t8code-local/prefix \
138-
-DCMAKE_C_FLAGS="-cpp --coverage -O0 -Wno-error=unused-parameter" \
143+
-DCMAKE_C_FLAGS="-cpp --coverage -O0 ${INPUT_C_FLAGS}" \
139144
-DCMAKE_Fortran_FLAGS="-cpp --coverage -O0" \
140145
-DCMAKE_EXE_LINKER_FLAGS="--coverage" \
141146
-DCMAKE_SHARED_LINKER_FLAGS="--coverage" \
@@ -210,7 +215,7 @@ jobs:
210215
if: ${{ matrix.test_type == 'package-compiler' }}
211216
run: |
212217
cd build
213-
make -j2
218+
make
214219
du -hL ./prefix-pc/lib/libtrixi.so
215220
216221
- name: Test external CMake project

0 commit comments

Comments
 (0)