refactor: move request param creation to YoutubeClient to avoid duplication in implementations

Author: trldvix

lib/src/main/java/io/github/thoroldvix/api/YoutubeClient.java

@@ -3,6 +3,7 @@
 
 import java.util.Map;
 
+
 /**
  * Responsible for sending GET requests to YouTube.
  */
@@ -13,7 +14,9 @@ public interface YoutubeClient {
      *
      * @param url     The URL to which the GET request is made.
      * @param headers A map of additional headers to include in the request.
+     *
      * @return The body of the response as a {@link String}.
+     *
      * @throws TranscriptRetrievalException If the request to YouTube fails.
      */
     String get(String url, Map<String, String> headers) throws TranscriptRetrievalException;
@@ -24,9 +27,31 @@ public interface YoutubeClient {
      *
      * @param endpoint The endpoint to which the GET request is made.
      * @param params   A map of parameters to include in the request.
+     *
      * @return The body of the response as a {@link String}.
+     *
      * @throws TranscriptRetrievalException If the request to YouTube fails.
      */
     String get(YtApiV3Endpoint endpoint, Map<String, String> params) throws TranscriptRetrievalException;
+
+
+    /**
+     * Creates a string representation of the specified parameters.
+     *
+     * @param params A map of parameters to include in the request.
+     *
+     * @return A string representation of the specified parameters.
+     */
+    default String createParamsString(Map<String, String> params) {
+        StringBuilder paramString = new StringBuilder();
+
+        for (Map.Entry<String, String> entry : params.entrySet()) {
+            String value = entry.getValue().replaceAll(" ", "%20");
+            paramString.append(entry.getKey()).append("=").append(value).append("&");
+        }
+
+        paramString.deleteCharAt(paramString.length() - 1);
+        return paramString.toString();
+    }
 }
 

lib/src/main/java/io/github/thoroldvix/internal/DefaultYoutubeClient.java

@@ -77,22 +77,6 @@ public String get(YtApiV3Endpoint endpoint, Map<String, String> params) throws T
         return response.body();
     }
 
-    private String createParamsString(Map<String, String> params) {
-        StringBuilder paramString = new StringBuilder();
-
-        for (Map.Entry<String, String> entry : params.entrySet()) {
-            String value = formatValue(entry.getValue());
-            paramString.append(entry.getKey()).append("=").append(value).append("&");
-        }
-
-        paramString.deleteCharAt(paramString.length() - 1);
-        return paramString.toString();
-    }
-
-    private String formatValue(String value) {
-        return value.replaceAll(" ", "%20");
-    }
-
     private String[] createHeaders(Map<String, String> headers) {
         String[] headersArray = new String[headers.size() * 2];
         int i = 0;