Merge pull request #1826 from troessner/issue-853-improve-reek-task-env-var-handling

Fix handling of env vars overriding reek task definitions

Author: mvz

features/rake_task/rake_task.feature

@@ -136,3 +136,48 @@ Feature: Reek can be driven through its Task
         [4]:UncommunicativeMethodName: Smelly#x has the name 'x'
         [5]:UncommunicativeVariableName: Smelly#x has the variable name 'y'
       """
+
+  Scenario: REEK_CFG overrides the configuration file to use
+    Given the smelly file 'smelly.rb'
+    And a configuration file 'empty.reek'
+    And a configuration file 'full_mask.reek'
+    And a file "Rakefile" with:
+      """
+      require 'reek/rake/task'
+
+      Reek::Rake::Task.new do |t|
+        t.config_file  = 'full_mask.reek'
+        t.source_files = 'smelly.rb'
+        t.reek_opts = '--no-color --no-documentation'
+      end
+      """
+    When I set the environment variable "REEK_CFG" to "empty.reek"
+    And I run `rake reek`
+    Then the exit status indicates an error
+    And it reports:
+      """
+      smelly.rb -- 2 warnings:
+        [4]:UncommunicativeMethodName: Smelly#x has the name 'x'
+        [5]:UncommunicativeVariableName: Smelly#x has the variable name 'y'
+      """
+
+  Scenario: REEK_OPTS overrides options to use
+    Given the smelly file 'smelly.rb'
+    And a file "Rakefile" with:
+      """
+      require 'reek/rake/task'
+
+      Reek::Rake::Task.new do |t|
+        t.source_files = 'smelly.rb'
+        t.reek_opts = '--no-color --no-documentation'
+      end
+      """
+    When I set the environment variable "REEK_OPTS" to "--single-line --no-documentation"
+    And I run `rake reek`
+    Then the exit status indicates an error
+    And it reports:
+      """
+      smelly.rb -- 2 warnings:
+        smelly.rb:4: UncommunicativeMethodName: Smelly#x has the name 'x'
+        smelly.rb:5: UncommunicativeVariableName: Smelly#x has the variable name 'y'
+      """

lib/reek/rake/task.rb

@@ -69,14 +69,19 @@ class Task < ::Rake::TaskLib
 
       # @public
       def initialize(name = :reek)
-        @config_file   = ENV.fetch('REEK_CFG', nil)
         @name          = name
-        @reek_opts     = ENV.fetch('REEK_OPTS', '')
+        @reek_opts     = ''
         @fail_on_error = true
         @verbose       = false
 
         yield self if block_given?
 
+        if (reek_cfg = ENV.fetch('REEK_CFG', nil))
+          @config_file = reek_cfg
+        end
+        if (reek_opts = ENV.fetch('REEK_OPTS', nil))
+          @reek_opts = reek_opts
+        end
         if (reek_src = ENV.fetch('REEK_SRC', nil))
           @source_files = FileList[reek_src]
         end