factory style improvements

Author: zero-bites

test/integration/factories/InvoiceFactory.ts

@@ -1,19 +1,19 @@
-import {ApiFactory} from "./ApiFactory";
-import {InvoiceLineFactory} from "./InvoiceLineFactory";
-
-export class InvoiceFactory extends ApiFactory {
-    defaultAttrs = {
-        recipientId: null, // Must be passed when creating resource
-        description: "Test Invoice",
-        externalId: "testInvoice",
-        invoiceDate: "2020-01-01",
-        dueDate: "2020-01-01"
-    }
-
-    public async createResource(attrs: any = {}) {
-        return await this.apiClient.invoice.create({
-            ...this.defaultAttrs,
-            ...attrs
-        });
-    }
-}
+import { ApiFactory } from "./ApiFactory";
+import { InvoiceLineFactory } from "./InvoiceLineFactory";
+
+export class InvoiceFactory extends ApiFactory {
+    defaultAttrs = {
+        recipientId: undefined, // Must be passed when creating resource
+        description: "Test Invoice",
+        externalId: "testInvoice",
+        invoiceDate: "2020-01-01",
+        dueDate: "2020-01-01",
+    };
+
+    public async createResource(attrs: any = {}) {
+        return this.apiClient.invoice.create({
+            ...this.defaultAttrs,
+            ...attrs,
+        });
+    }
+}

test/integration/factories/InvoiceLineFactory.ts

@@ -1,29 +1,28 @@
-import {ApiFactory} from "./ApiFactory";
-import {Amount} from "../../../lib/types";
-import {InvoiceLineCategory} from "../../../lib/InvoiceLine";
-
-
-export class InvoiceLineFactory extends ApiFactory {
-    static defaultAttrs = {
-        unitAmount: {
-            value: "100",
-            currency: "USD",
-        },
-        category: InvoiceLineCategory.services,
-        description: "Test Invoice Line",
-        externalId: "testInvoiceLine",
-        taxReportable: true,
-        forceUsTaxActivity: false,
-        tags: ['test'],
-    }
-
-    public async createResource(attrs: any = {}) {
-        return await this.apiClient.invoiceLine.create(
-            attrs.invoice.id,
-            [{
-            ...InvoiceLineFactory.defaultAttrs,
-            ...attrs
-            }],
-        );
-    }
-}
+import { ApiFactory } from "./ApiFactory";
+import { Amount } from "../../../lib/types";
+import { InvoiceLineCategory } from "../../../lib/InvoiceLine";
+
+export class InvoiceLineFactory extends ApiFactory {
+    static defaultAttrs = {
+        unitAmount: {
+            value: "100",
+            currency: "USD",
+        },
+        category: InvoiceLineCategory.services,
+        description: "Test Invoice Line",
+        externalId: "testInvoiceLine",
+        taxReportable: true,
+        forceUsTaxActivity: false,
+        tags: ['test'],
+    };
+
+    public async createResource(attrs: any = {}) {
+        return this.apiClient.invoiceLine.create(
+            attrs.invoice.id,
+            [{
+            ...InvoiceLineFactory.defaultAttrs,
+            ...attrs,
+            }],
+        );
+    }
+}

test/integration/factories/PaymentFactory.ts

@@ -1,4 +1,4 @@
-import {ApiFactory, InvalidAttributeError} from "./ApiFactory";
+import { ApiFactory, InvalidAttributeError } from "./ApiFactory";
 
 export class PaymentFactory extends ApiFactory {
     private defaultAttrs =  {

test/integration/factories/RecipientAccountFactory.ts

@@ -1,19 +1,19 @@
-import {ApiFactory} from "./ApiFactory";
-
-export class RecipientAccountFactory extends ApiFactory {
-    private defaultAttrs = {
-        type: "bank-transfer",
-        currency: "EUR",
-        iban: "DE89 3704 0044 0532 0130 00"
-    }
-
-    public async createResource(attrs: any = {}) {
-        return await this.apiClient.recipientAccount.create(
-            attrs.recipient.id,
-            {
-                ...this.defaultAttrs,
-                ...attrs
-            }
-        );
-    }
-}
+import { ApiFactory } from "./ApiFactory";
+
+export class RecipientAccountFactory extends ApiFactory {
+    private defaultAttrs = {
+        type: "bank-transfer",
+        currency: "EUR",
+        iban: "DE89 3704 0044 0532 0130 00",
+    };
+
+    public async createResource(attrs: any = {}) {
+        return this.apiClient.recipientAccount.create(
+            attrs.recipient.id,
+            {
+                ...this.defaultAttrs,
+                ...attrs,
+            },
+        );
+    }
+}

test/integration/factories/RecipientFactory.ts

@@ -1,23 +1,23 @@
-import {ApiFactory} from "./ApiFactory";
-
-export class RecipientFactory extends ApiFactory {
-    defaultAttrs = {
-        type: "individual",
-        firstName: "Tom",
-        lastName: `Jones`,
-        email: '[email protected]',
-        address: {
-            street1: "123 Wolfstrasse",
-            city: "Berlin",
-            country: "DE",
-            postalCode: "123123",
-        },
-    };
-
-    public async createResource(attrs: any = {}) {
-        return await this.apiClient.recipient.create({
-            ...this.defaultAttrs,
-            ...attrs
-        });
-    }
-}
+import { ApiFactory } from "./ApiFactory";
+
+export class RecipientFactory extends ApiFactory {
+    defaultAttrs = {
+        type: "individual",
+        firstName: "Tom",
+        lastName: `Jones`,
+        email: '[email protected]',
+        address: {
+            street1: "123 Wolfstrasse",
+            city: "Berlin",
+            country: "DE",
+            postalCode: "123123",
+        },
+    };
+
+    public async createResource(attrs: any = {}) {
+        return this.apiClient.recipient.create({
+            ...this.defaultAttrs,
+            ...attrs,
+        });
+    }
+}