spec style fixes

Author: zero-bites

test/integration/BalanceSpec.ts

@@ -1,28 +1,31 @@
 import { startNockRec, testingApiClient } from "./helpers/integrationTestsHelpers";
 import * as assert from "assert";
+import { Balance } from "../../lib";
 
 describe("Balance", () => {
     it("lists all balances", async () => {
         const nockDone = await startNockRec('balance-all.json');
 
         const balances = await testingApiClient.balances.all();
 
-        assert.ok(balances);
-        assert.strictEqual(1, balances.length);
-        assert.strictEqual("paymentrails", balances[0].type);
-
         nockDone();
+
+        assert.ok(balances);
+        assert.strictEqual(balances.length, 1);
+        assert.strictEqual(balances[0].constructor, Balance);
+        assert.strictEqual(balances[0].type, "paymentrails");
     });
 
     it("lists balances for a given kind", async () => {
         const nockDone = await startNockRec('balance-find.json');
 
         const balances = await testingApiClient.balances.find("paymentrails");
 
-        assert.ok(balances);
-        assert.strictEqual(1, balances.length);
-        assert.strictEqual("paymentrails", balances[0].type);
-
         nockDone();
+
+        assert.ok(balances);
+        assert.strictEqual(balances.length, 1);
+        assert.strictEqual(balances[0].constructor, Balance);
+        assert.strictEqual(balances[0].type, "paymentrails");
     });
 });

test/integration/InvoiceLineSpec.ts

@@ -3,6 +3,7 @@ import { RecipientFactory } from './factories/RecipientFactory';
 import { InvoiceFactory } from './factories/InvoiceFactory';
 import { InvoiceLineFactory } from './factories/InvoiceLineFactory';
 import * as assert from 'assert';
+import { InvoiceLine } from "../../lib/InvoiceLine";
 
 let recipientFactory: RecipientFactory;
 let invoiceFactory: InvoiceFactory;
@@ -26,6 +27,7 @@ describe('InvoiceLine', () => {
 
         assert.ok(invoiceLines);
         assert.strictEqual(invoiceLines.length, 1);
+        assert.strictEqual(invoiceLines[0].constructor, InvoiceLine);
         assert.strictEqual('testInvoiceLine', invoiceLines[0].externalId);
     });
 
@@ -51,6 +53,9 @@ describe('InvoiceLine', () => {
         nockDone();
 
         assert.ok(updatedInvoice);
+        assert.strictEqual(invoiceLines.length, 1);
+        assert.strictEqual(invoiceLines[0].constructor, InvoiceLine);
+        assert.strictEqual(updatedInvoice.lines.length, 1);
         assert.strictEqual('updated line description', updatedInvoice.lines[0].description);
     });
 

test/integration/InvoiceSpec.ts

@@ -24,6 +24,7 @@ describe("Invoice", () => {
         nockDone();
 
         assert.ok(invoice);
+        assert.strictEqual(invoice.constructor, Invoice);
         assert.strictEqual("testInvoice", invoice.externalId);
         assert.strictEqual(recipient.id, invoice.recipientId);
     });
@@ -53,6 +54,7 @@ describe("Invoice", () => {
         nockDone();
 
         assert.ok(invoice);
+        assert.strictEqual(invoice.constructor, Invoice);
         assert.strictEqual("testInvoice", invoice.externalId);
         assert.strictEqual(recipient.id, invoice.recipientId);
         assert.strictEqual(1, invoice.lines.length);
@@ -73,6 +75,7 @@ describe("Invoice", () => {
         nockDone();
 
         assert.ok(findInvoice);
+        assert.strictEqual(findInvoice.constructor, Invoice);
         assert.strictEqual("testInvoice", findInvoice.externalId);
     });
 
@@ -96,7 +99,9 @@ describe("Invoice", () => {
         nockDone();
 
         assert.ok(invoices);
-        assert.strictEqual(2, invoices.length);
+        assert.strictEqual(invoices.length, 2);
+        assert.strictEqual(invoices[0].constructor, Invoice);
+        assert.strictEqual(invoices[1].constructor, Invoice);
         assert.strictEqual([invoice.id, otherInvoice.id].sort().toString(), invoices.map(i => i.id).sort().toString());
     });
 
@@ -119,6 +124,7 @@ describe("Invoice", () => {
         nockDone();
 
         assert.ok(invoice);
+        assert.strictEqual(invoice.constructor, Invoice);
         assert.strictEqual("Updated description", updatedInvoice.description);
     });
 

test/integration/OfflinePaymentSpec.ts

@@ -2,6 +2,7 @@ import { startNockRec, testingApiClient } from "./helpers/integrationTestsHelper
 import { RecipientFactory } from "./factories/RecipientFactory";
 import * as assert from "assert";
 import { OfflinePaymentFactory } from "./factories/OfflinePaymentFactory";
+import { OfflinePayment } from "../../lib";
 
 let recipientFactory: RecipientFactory;
 let offlinePaymentFactory: OfflinePaymentFactory;
@@ -21,7 +22,8 @@ describe('OfflinePayment', () => {
         nockDone();
 
         assert.ok(offlinePayment);
-        assert.strictEqual('testOfflinePayment', offlinePayment.externalId);
+        assert.strictEqual(offlinePayment.constructor, OfflinePayment);
+        assert.strictEqual(offlinePayment.externalId, 'testOfflinePayment');
     });
 
     it('updates an offline payment', async () => {
@@ -44,6 +46,7 @@ describe('OfflinePayment', () => {
         nockDone();
 
         assert.ok(offlinePayment);
+        assert.strictEqual(offlinePayment.constructor, OfflinePayment);
         assert.strictEqual(true, offlinePayment.taxReportable);
     });
 
@@ -86,5 +89,7 @@ describe('OfflinePayment', () => {
 
         assert.ok(offlinePaymentResults);
         assert.strictEqual(2, offlinePaymentResults.length);
+        assert.strictEqual(offlinePaymentResults[0].constructor, OfflinePayment);
+        assert.strictEqual(offlinePaymentResults[1].constructor, OfflinePayment);
     });
 });

test/integration/PaymentSpec.ts

@@ -3,6 +3,7 @@ import { PaymentFactory } from "./factories/PaymentFactory";
 import { BatchFactory } from "./factories/BatchFactory";
 import { RecipientFactory } from "./factories/RecipientFactory";
 import * as assert from "assert";
+import { Payment } from "../../lib";
 
 let batchFactory: BatchFactory;
 let recipientFactory: RecipientFactory;
@@ -36,7 +37,8 @@ describe('Payment', () => {
         nockDone();
 
         assert.ok(payment);
-        assert.strictEqual('testPayment', payment.externalId);
+        assert.strictEqual(payment.constructor, Payment);
+        assert.strictEqual(payment.externalId, 'testPayment');
     });
 
     it('updates a payment', async () => {
@@ -68,6 +70,7 @@ describe('Payment', () => {
         nockDone();
 
         assert.ok(updatedPayment);
+        assert.strictEqual(updatedPayment.constructor, Payment);
         assert.strictEqual('updatedPayment', updatedPayment.externalId);
     });
 
@@ -115,12 +118,13 @@ describe('Payment', () => {
         );
 
         const query = { recipientId: recipient.id, batchId: batch.id };
-        const searchResult = await testingApiClient.payment.search(query);
+        const paymentsCollection = await testingApiClient.payment.search(query);
 
         nockDone();
 
-        assert.ok(searchResult);
-        assert.strictEqual(1, searchResult.length);
-        assert.strictEqual(payment.externalId, searchResult[0].externalId);
+        assert.ok(paymentsCollection);
+        assert.strictEqual(1, paymentsCollection.length);
+        assert.strictEqual(paymentsCollection[0].constructor, Payment);
+        assert.strictEqual(payment.externalId, paymentsCollection[0].externalId);
     });
 });

test/integration/RecipientAccountSpec.ts

@@ -2,6 +2,7 @@ import * as assert from "assert";
 import { startNockRec, testingApiClient } from "./helpers/integrationTestsHelpers";
 import { RecipientFactory } from "./factories/RecipientFactory";
 import { RecipientAccountFactory } from "./factories/RecipientAccountFactory";
+import {RecipientAccount} from "../../lib";
 
 let recipientFactory: RecipientFactory;
 let recipientAccountFactory: RecipientAccountFactory;
@@ -33,7 +34,7 @@ describe("RecipientAccount", () => {
 
         const primaryAccount = await testingApiClient.recipientAccount.find(recipient.id, account.id);
         const accountList = await testingApiClient.recipientAccount.all(recipient.id);
-        const result = await testingApiClient.recipientAccount.remove(recipient.id, account.id);
+        const deleteResult = await testingApiClient.recipientAccount.remove(recipient.id, account.id);
         const accountList2 = await testingApiClient.recipientAccount.all(recipient.id);
 
         nockDone();
@@ -43,12 +44,18 @@ describe("RecipientAccount", () => {
         assert.ok(account2);
         assert.ok(account2.primary);
 
+        assert.strictEqual(account.constructor, RecipientAccount);
+        assert.strictEqual(account2.constructor, RecipientAccount);
         assert.strictEqual(account.iban, primaryAccount.iban);
 
         assert.strictEqual(accountList.length, 2);
-        assert.strictEqual(accountList[0].currency, "EUR");
+        assert.strictEqual(accountList[0].constructor, RecipientAccount);
+        assert.strictEqual(accountList[1].constructor, RecipientAccount);
 
-        assert.strictEqual(true, result);
+        assert.strictEqual(accountList2.length, 1);
+        assert.strictEqual(accountList2[0].id, account2.id);
+
+        assert.strictEqual(true, deleteResult);
 
         assert.strictEqual(accountList2.length, 1);
         assert.ok(accountList2[0].primary);
@@ -58,30 +65,31 @@ describe("RecipientAccount", () => {
         const nockDone = await startNockRec('recipient-account-update.json');
 
         const recipient = await recipientFactory.createResource();
-        const dummyIban = "DE89 3704 0044 0532 0130 00";
+        const iban = "DE89 3704 0044 0532 0130 00";
         const account = await recipientAccountFactory.createResource({
             recipient: { id: recipient.id },
             type: "bank-transfer",
             currency: "EUR",
-            iban: dummyIban,
+            iban: iban,
         });
-        const otherDummyIban = "DE91 1000 0000 0123 4567 89";
-        const account2 = await testingApiClient.recipientAccount.update(recipient.id, account.id, {
-            iban: otherDummyIban,
+        const otherIban = "DE91 1000 0000 0123 4567 89";
+        const updatedAccount = await testingApiClient.recipientAccount.update(recipient.id, account.id, {
+            iban: otherIban,
         });
 
         const accountList = await testingApiClient.recipientAccount.all(recipient.id);
 
         nockDone();
 
         assert.ok(account);
-        assert.ok(account2);
-        assert.strictEqual(account.id, account2.id);
-        assert.ok(account2.iban && account2.iban.includes("**89"));
+        assert.ok(updatedAccount);
+        assert.strictEqual(account.constructor, RecipientAccount);
+        assert.strictEqual(updatedAccount.constructor, RecipientAccount);
+        assert.ok(updatedAccount.iban && updatedAccount.iban.includes("**89"));
 
         assert.ok((accountList as any)[0].iban.includes("**89"));
         assert.strictEqual(accountList.length, 1);
-        assert.strictEqual(accountList[0].id, account2.id);
+        assert.strictEqual(accountList[0].id, updatedAccount.id);
     });
 
     it("deletes account", async () => {

test/integration/RecipientSpec.ts

@@ -16,6 +16,7 @@ describe("Recipient", () => {
     const recipient = await recipientFactory.createResource();
 
     assert.ok(recipient);
+    assert.strictEqual(recipient.constructor, Recipient);
     assert.strictEqual("Tom", recipientFactory.defaultAttrs.firstName);
     assert.strictEqual("Jones", recipientFactory.defaultAttrs.lastName);
     assert.ok(recipient.id);
@@ -27,16 +28,17 @@ describe("Recipient", () => {
     const nockDone = await startNockRec('recipient-update.json');
 
     const recipient = await recipientFactory.createResource();
-    const updated = await testingApiClient.recipient.update(recipient.id, {
+    const updatedRecipient = await testingApiClient.recipient.update(recipient.id, {
       firstName: "John",
       lastName: "Smith",
     });
 
     nockDone();
 
-    assert.ok(updated);
-    assert.strictEqual("John", updated.firstName);
-    assert.strictEqual("Smith", updated.lastName);
+    assert.ok(updatedRecipient);
+    assert.strictEqual(updatedRecipient.constructor, Recipient);
+    assert.strictEqual("John", updatedRecipient.firstName);
+    assert.strictEqual("Smith", updatedRecipient.lastName);
     });
 
   it("deletes a recipient", async () => {
@@ -54,12 +56,12 @@ describe("Recipient", () => {
     const nockDone = await startNockRec('recipient-search.json');
 
     const recipient = await recipientFactory.createResource();
-    const recipients = await testingApiClient.recipient.search();
+    const recipientsCollection: Recipient[] = await testingApiClient.recipient.search();
 
     nockDone();
 
-    assert.ok(recipients);
-    assert.strictEqual(1, recipients.length);
-    assert.strictEqual(recipient.id, recipients[0].id);
+    assert.ok(recipientsCollection);
+    assert.strictEqual(1, recipientsCollection.length);
+    assert.strictEqual(recipient.id, recipientsCollection[0].id);
     });
   });