weakref gas internal error

amodra · amodra · commit 829b08e405a4 · 2025-06-01T13:21:00.000+09:30
This horrible testcase (cleaned up from oss-fuzz)
 r=x*2
 x=r-r
 .weakref r,x
 r=r-5
triggers resolve_symbol_value "gas_assert (final_val == 0)" in weakref
handling.

	* read.c (assign_symbol): Clear weakrefr.
diff --git a/gas/read.c b/gas/read.c
@@ -3306,6 +3306,7 @@ assign_symbol (char *name, int mode)
 	 retain the value of the symbol at the point of use.  */
       else if (S_IS_VOLATILE (symbolP))
 	symbolP = symbol_clone (symbolP, 1);
+      S_CLEAR_WEAKREFR (symbolP);
     }
 
   if (mode == 0)

Original file line number	Diff line number	Diff line change
`@@ -3306,6 +3306,7 @@ assign_symbol (char *name, int mode)`
`3306`	`3306`	`retain the value of the symbol at the point of use. */`
`3307`	`3307`	`else if (S_IS_VOLATILE (symbolP))`
`3308`	`3308`	`symbolP = symbol_clone (symbolP, 1);`
	`3309`	`+ S_CLEAR_WEAKREFR (symbolP);`
`3309`	`3310`	`}`
`3310`	`3311`
`3311`	`3312`	`if (mode == 0)`