fix error vis bug causing crashes when jumping with segment select menu

musicog · musicog · commit a281c646fd6c · 2021-03-01T17:08:19.000+01:00
diff --git a/src/containers/errorRibbonVis.js b/src/containers/errorRibbonVis.js
@@ -218,7 +218,7 @@ export default class ErrorRibbonVis extends Component {
                   .map( (instant) => this.props.noteElementsForInstant(instant) ).flat()
                   .map( (noteElement) => this.props.convertCoords(noteElement).x )
               }
-              if(closestSuccessorScoretime) { 
+              if(closestSuccessorScoretime && closestSuccessorScoretime.qstamp in this.props.instantsByScoretime[tl]) { 
                 successorNoteElementXPositions = this.props.instantsByScoretime[tl][closestSuccessorScoretime.qstamp]
                   .map( (instant) => this.props.noteElementsForInstant(instant) ).flat()
                   .map( (noteElement) => this.props.convertCoords(noteElement).x )

Original file line number	Diff line number	Diff line change
`@@ -218,7 +218,7 @@ export default class ErrorRibbonVis extends Component {`
`218`	`218`	`.map( (instant) => this.props.noteElementsForInstant(instant) ).flat()`
`219`	`219`	`.map( (noteElement) => this.props.convertCoords(noteElement).x )`
`220`	`220`	`}`
`221`		`- if(closestSuccessorScoretime) {`
	`221`	`+ if(closestSuccessorScoretime && closestSuccessorScoretime.qstamp in this.props.instantsByScoretime[tl]) {`
`222`	`222`	`successorNoteElementXPositions = this.props.instantsByScoretime[tl][closestSuccessorScoretime.qstamp]`
`223`	`223`	`.map( (instant) => this.props.noteElementsForInstant(instant) ).flat()`
`224`	`224`	`.map( (noteElement) => this.props.convertCoords(noteElement).x )`