Skip to content

Commit 30317c7

Browse files
committed
Minimise includes of executorpool.h
Remove the include of executorpool.h from kvbucket.h; then add it back into the specific .cc files which require it. Change-Id: I7256be2ccef778ebbf6f526a3f82fb637e7f0603 Reviewed-on: http://review.couchbase.org/113435 Tested-by: Build Bot <[email protected]> Reviewed-by: Trond Norbye <[email protected]>
1 parent 67ef8e8 commit 30317c7

16 files changed

+30
-9
lines changed

engines/ep/src/bgfetcher.cc

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -18,6 +18,7 @@
1818
#include "bgfetcher.h"
1919
#include "bucket_logger.h"
2020
#include "ep_engine.h"
21+
#include "executorpool.h"
2122
#include "executorthread.h"
2223
#include "kv_bucket.h"
2324
#include "kvshard.h"

engines/ep/src/dcp/backfill-manager.cc

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -15,15 +15,16 @@
1515
* limitations under the License.
1616
*/
1717

18+
#include "dcp/backfill-manager.h"
1819
#include "bucket_logger.h"
1920
#include "connmap.h"
2021
#include "dcp/active_stream.h"
21-
#include "dcp/backfill-manager.h"
2222
#include "dcp/backfill_disk.h"
2323
#include "dcp/dcpconnmap.h"
2424
#include "dcp/producer.h"
2525
#include "ep_engine.h"
2626
#include "ep_time.h"
27+
#include "executorpool.h"
2728
#include "kv_bucket.h"
2829

2930
#include <phosphor/phosphor.h>

engines/ep/src/dcp/backfill-manager.h

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -44,9 +44,12 @@
4444
#pragma once
4545

4646
#include "dcp/backfill.h"
47-
47+
#include <memcached/engine_common.h>
48+
#include <memcached/types.h>
4849
#include <list>
50+
#include <mutex>
4951

52+
class DcpProducer;
5053
class EventuallyPersistentEngine;
5154
class GlobalTask;
5255
class VBucket;

engines/ep/src/dcp/backfill.h

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -17,6 +17,10 @@
1717

1818
#pragma once
1919

20+
#include <memcached/vbucket.h>
21+
22+
#include <memory>
23+
2024
class ActiveStream;
2125
class ScanContext;
2226

engines/ep/src/ep_bucket.cc

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -26,6 +26,7 @@
2626
#include "ep_engine.h"
2727
#include "ep_time.h"
2828
#include "ep_vb.h"
29+
#include "executorpool.h"
2930
#include "failover-table.h"
3031
#include "flusher.h"
3132
#include "item.h"

engines/ep/src/ep_engine.cc

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -33,6 +33,7 @@
3333
#include "ep_bucket.h"
3434
#include "ep_vb.h"
3535
#include "ephemeral_bucket.h"
36+
#include "executorpool.h"
3637
#include "ext_meta_parser.h"
3738
#include "failover-table.h"
3839
#include "flusher.h"

engines/ep/src/ephemeral_bucket.cc

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -23,6 +23,7 @@
2323
#include "ephemeral_tombstone_purger.h"
2424
#include "ephemeral_vb.h"
2525
#include "ephemeral_vb_count_visitor.h"
26+
#include "executorpool.h"
2627
#include "failover-table.h"
2728
#include "replicationthrottle.h"
2829
#include "rollback_result.h"

engines/ep/src/ephemeral_tombstone_purger.cc

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -23,6 +23,7 @@
2323
#include "ep_time.h"
2424
#include "ephemeral_bucket.h"
2525
#include "ephemeral_vb.h"
26+
#include "executorpool.h"
2627
#include "seqlist.h"
2728

2829
#include <climits>

engines/ep/src/flusher.cc

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -20,6 +20,7 @@
2020
#include "bucket_logger.h"
2121
#include "common.h"
2222
#include "ep_bucket.h"
23+
#include "executorpool.h"
2324
#include "tasks.h"
2425

2526
#include <platform/timeutils.h>

engines/ep/src/item_freq_decayer.cc

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -18,6 +18,7 @@
1818
#include "item_freq_decayer.h"
1919
#include "bucket_logger.h"
2020
#include "ep_engine.h"
21+
#include "executorpool.h"
2122
#include "item_freq_decayer_visitor.h"
2223
#include "kv_bucket.h"
2324
#include "stored-value.h"

0 commit comments

Comments
 (0)