Skip to content

Commit 68b5190

Browse files
daverigbytrondn
authored andcommitted
Minimise includes of dcp/ headers
Change-Id: Ic9a737cfd50b8f665b52f90dc59f38b71eeaac99 Reviewed-on: http://review.couchbase.org/113439 Tested-by: Build Bot <[email protected]> Reviewed-by: Trond Norbye <[email protected]>
1 parent d148b3d commit 68b5190

File tree

6 files changed

+11
-8
lines changed

6 files changed

+11
-8
lines changed

engines/ep/src/dcp/flow-control-manager.h

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -16,11 +16,14 @@
1616
*/
1717
#pragma once
1818

19+
#include "memcached/types.h"
20+
1921
#include <atomic>
22+
#include <map>
2023
#include <mutex>
2124

22-
#include "memcached/types.h"
23-
#include "dcp/consumer.h"
25+
class DcpConsumer;
26+
class EventuallyPersistentEngine;
2427

2528
/**
2629
* DcpFlowControlManager is a base class for handling/enforcing flow control

engines/ep/src/dcp/flow-control.cc

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -15,9 +15,10 @@
1515
* limitations under the License.
1616
*/
1717

18+
#include "dcp/flow-control.h"
1819
#include "connhandler_impl.h"
20+
#include "dcp/consumer.h"
1921
#include "dcp/flow-control-manager.h"
20-
#include "dcp/flow-control.h"
2122
#include "ep_engine.h"
2223
#include "ep_time.h"
2324
#include "objectregistry.h"

engines/ep/tests/mock/mock_stream.cc

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -18,8 +18,8 @@
1818
#include "mock_stream.h"
1919
#include "checkpoint_manager.h"
2020
#include "dcp/response.h"
21+
#include "mock_dcp_producer.h"
2122
#include "vbucket.h"
22-
2323
MockActiveStream::MockActiveStream(EventuallyPersistentEngine* e,
2424
std::shared_ptr<MockDcpProducer> p,
2525
uint32_t flags,

engines/ep/tests/mock/mock_stream.h

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -18,13 +18,10 @@
1818
#pragma once
1919

2020
#include "dcp/active_stream.h"
21-
#include "dcp/consumer.h"
2221
#include "dcp/passive_stream.h"
23-
#include "dcp/producer.h"
24-
#include "dcp/stream.h"
25-
#include "tests/mock/mock_dcp_producer.h"
2622

2723
class CheckpointManager;
24+
class MockDcpProducer;
2825

2926
/*
3027
* Mock of the ActiveStream class. Wraps the real ActiveStream, but exposes

engines/ep/tests/module_tests/dcp_durability_stream_test.cc

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -31,6 +31,7 @@
3131

3232
#include "../mock/mock_checkpoint_manager.h"
3333
#include "../mock/mock_dcp_consumer.h"
34+
#include "../mock/mock_dcp_producer.h"
3435
#include "../mock/mock_stream.h"
3536
#include "../mock/mock_synchronous_ep_engine.h"
3637

engines/ep/tests/module_tests/evp_store_rollback_test.cc

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -36,6 +36,7 @@
3636
#include "tests/mock/mock_checkpoint_manager.h"
3737
#include "tests/mock/mock_dcp.h"
3838
#include "tests/mock/mock_dcp_consumer.h"
39+
#include "tests/mock/mock_dcp_producer.h"
3940
#include "tests/mock/mock_stream.h"
4041
#include "tests/mock/mock_synchronous_ep_engine.h"
4142
#include "tests/module_tests/collections/test_manifest.h"

0 commit comments

Comments
 (0)