MB-34995: [DM] Keys should be marked for log redaction

Add log redaction tags for the keys when used in exceptions
or logs in the durability manager.

Change-Id: I05c96243d426e8573a6a73148492c0ea04ac08f3
Reviewed-on: http://review.couchbase.org/112019
Tested-by: Trond Norbye <[email protected]>
Reviewed-by: Dave Rigby <[email protected]>

Author: trondn

engines/ep/src/durability/active_durability_monitor.cc

@@ -28,6 +28,7 @@
 #include <folly/concurrency/UnboundedQueue.h>
 
 #include <gsl.h>
+#include <utilities/logtags.h>
 
 /*
  * This class embeds the state of an ADM. It has been designed for being
@@ -950,8 +951,8 @@ void ActiveDurabilityMonitor::commit(const SyncWrite& sw) {
 
     if (globalBucketLogger->should_log(spdlog::level::debug)) {
         std::stringstream ss;
-        ss << "SyncWrite commit \"" << key << "\": ack'ed by {"
-           << boost::join(sw.getAckedNodes(), ", ") << "}";
+        ss << "SyncWrite commit \"" << cb::tagUserData(key.to_string())
+           << "\": ack'ed by {" << boost::join(sw.getAckedNodes(), ", ") << "}";
 
         EP_LOG_DEBUG(ss.str());
     }

engines/ep/src/durability/durability_monitor_impl.cc

@@ -18,6 +18,7 @@
 #include "durability_monitor_impl.h"
 #include <folly/lang/Assume.h>
 #include <gsl.h>
+#include <utilities/logtags.h>
 
 /// Helper function to determine the expiry time for a SyncWrite from the
 /// durability requirements.
@@ -233,7 +234,8 @@ std::unordered_set<std::string> DurabilityMonitor::SyncWrite::getAckedNodes()
 std::ostream& operator<<(std::ostream& os,
                          const DurabilityMonitor::SyncWrite& sw) {
     os << "SW @" << &sw << " "
-       << "cookie:" << sw.cookie << " qi:[key:'" << sw.item->getKey()
+       << "cookie:" << sw.cookie << " qi:[key:'"
+       << cb::tagUserData(sw.item->getKey().to_string())
        << "' seqno:" << sw.item->getBySeqno()
        << " reqs:" << to_string(sw.item->getDurabilityReqs()) << "] maj:"
        << std::to_string(sw.firstChain ? sw.firstChain.chainPtr->majority : 0)

engines/ep/src/durability/passive_durability_monitor.cc

@@ -27,6 +27,7 @@
 
 #include <boost/range/adaptor/reversed.hpp>
 #include <gsl.h>
+#include <utilities/logtags.h>
 #include <unordered_map>
 
 PassiveDurabilityMonitor::PassiveDurabilityMonitor(VBucket& vb)
@@ -190,10 +191,10 @@ void PassiveDurabilityMonitor::completeSyncWrite(const StoredDocKey& key,
     auto s = state.wlock();
 
     if (s->trackedWrites.empty()) {
-        throwException<std::logic_error>(__func__,
-                                         "No tracked, but received " +
-                                                 to_string(res) + " for key " +
-                                                 key.to_string());
+        throwException<std::logic_error>(
+                __func__,
+                "No tracked, but received " + to_string(res) + " for key " +
+                        cb::tagUserData(key.to_string()));
     }
 
     const auto next = s->getIteratorNext(s->highCompletedSeqno.it);
@@ -202,15 +203,16 @@ void PassiveDurabilityMonitor::completeSyncWrite(const StoredDocKey& key,
         throwException<std::logic_error>(
                 __func__,
                 "No Prepare waiting for completion, but received " +
-                        to_string(res) + " for key " + key.to_string());
+                        to_string(res) + " for key " +
+                        cb::tagUserData(key.to_string()));
     }
 
     // Sanity check for In-Order Commit
     if (next->getKey() != key) {
         std::stringstream ss;
         ss << "Pending resolution for '" << *next
            << "', but received unexpected " + to_string(res) + " for key "
-           << key;
+           << cb::tagUserData(key.to_string());
         throwException<std::logic_error>(__func__, "" + ss.str());
     }