Skip to content

Commit 068eb3a

Browse files
Merge pull request #6190 from yanghang8612/feat/optimize_tests_and_logs
feat(vm): optimize tests and logs
2 parents 2ce580d + 9a44b0b commit 068eb3a

File tree

3 files changed

+10
-3
lines changed

3 files changed

+10
-3
lines changed

actuator/src/main/java/org/tron/core/vm/nativecontract/UnfreezeBalanceV2Processor.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -84,7 +84,7 @@ public void validate(UnfreezeBalanceV2Param param, Repository repo)
8484

8585
if (!checkUnfreezeBalance(accountCapsule, param.getUnfreezeBalance(), param.getResourceType())) {
8686
throw new ContractValidateException(
87-
"Invalid unfreeze_balance, [" + param.getUnfreezeBalance() + "] is error");
87+
"Invalid unfreeze_balance, [" + param.getUnfreezeBalance() + "] is too large");
8888
}
8989
}
9090

framework/src/test/java/org/tron/common/runtime/vm/BatchValidateSignContractTest.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -79,7 +79,6 @@ public void staticCallTest() {
7979

8080
@Test
8181
public void correctionTest() {
82-
contract.setConstantCall(false);
8382
List<Object> signatures = new ArrayList<>();
8483
List<Object> addresses = new ArrayList<>();
8584
byte[] hash = Hash.sha3(longData);
@@ -128,7 +127,8 @@ Pair<Boolean, byte[]> validateMultiSign(byte[] hash, List<Object> signatures,
128127
List<Object> parameters = Arrays.asList("0x" + Hex.toHexString(hash), signatures, addresses);
129128
byte[] input = Hex.decode(AbiUtil.parseParameters(METHOD_SIGN, parameters));
130129
contract.getEnergyForData(input);
131-
contract.setVmShouldEndInUs(System.nanoTime() / 1000 + 500 * 1000);
130+
long maxExecutionTime = 2000; // ms
131+
contract.setVmShouldEndInUs(System.nanoTime() / 1000 + maxExecutionTime * 1000);
132132
Pair<Boolean, byte[]> ret = contract.execute(input);
133133
logger.info("BytesArray:{},HexString:{}", Arrays.toString(ret.getValue()),
134134
Hex.toHexString(ret.getValue()));

framework/src/test/java/org/tron/common/runtime/vm/Create2Test.java

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -160,9 +160,16 @@ public void testCreate2()
160160
// Trigger contract method: deploy(bytes,uint)
161161
long salt = 100L;
162162
String hexInput = AbiUtil.parseMethod(methodSign, Arrays.asList(testCode, salt));
163+
164+
long preTime = manager.getDynamicPropertiesStore().getMaxCpuTimeOfOneTx();
165+
// set max cpu time to 500
166+
manager.getDynamicPropertiesStore().saveMaxCpuTimeOfOneTx(500L);
163167
TVMTestResult result = TvmTestUtils
164168
.triggerContractAndReturnTvmTestResult(Hex.decode(OWNER_ADDRESS),
165169
factoryAddress, Hex.decode(hexInput), 0, fee, manager, null);
170+
// restore max cpu time
171+
manager.getDynamicPropertiesStore().saveMaxCpuTimeOfOneTx(preTime);
172+
166173
Assert.assertNull(result.getRuntime().getRuntimeError());
167174

168175
byte[] returnValue = result.getRuntime().getResult().getHReturn();

0 commit comments

Comments
 (0)