Merge pull request #3799 from forfreeday/memory_optimization

memory optimization

Author: lvs007

framework/src/main/java/org/tron/core/Wallet.java

@@ -1320,17 +1320,17 @@ public TransactionInfo getTransactionInfoById(ByteString transactionId) {
     }
     TransactionInfoCapsule transactionInfoCapsule;
     try {
-      transactionInfoCapsule = chainBaseManager.getTransactionHistoryStore()
-          .get(transactionId.toByteArray());
+      transactionInfoCapsule = chainBaseManager.getTransactionRetStore()
+              .getTransactionInfo(transactionId.toByteArray());
     } catch (StoreException e) {
       return null;
     }
     if (transactionInfoCapsule != null) {
       return transactionInfoCapsule.getInstance();
     }
     try {
-      transactionInfoCapsule = chainBaseManager.getTransactionRetStore()
-          .getTransactionInfo(transactionId.toByteArray());
+      transactionInfoCapsule = chainBaseManager.getTransactionHistoryStore()
+              .get(transactionId.toByteArray());
     } catch (BadItemException e) {
       return null;
     }

framework/src/main/java/org/tron/core/db/Manager.java

@@ -1197,6 +1197,7 @@ public TransactionInfo processTransaction(final TransactionCapsule trxCap, Block
     }
     //set the sort order
     trxCap.setOrder(transactionInfo.getFee());
+    trxCap.setTrxTrace(null);
     return transactionInfo.getInstance();
   }
 

framework/src/main/java/org/tron/core/net/messagehandler/FetchInvDataMsgHandler.java

@@ -146,8 +146,6 @@ private void check(PeerConnection peer, FetchInvDataMessage fetchInvDataMsg) thr
       int maxCount = advService.getTrxCount().getCount(60);
       if (fetchCount > maxCount) {
         logger.error("maxCount: " + maxCount + ", fetchCount: " + fetchCount);
-        //        throw new P2pException(TypeEnum.BAD_MESSAGE,
-        //            "maxCount: " + maxCount + ", fetchCount: " + fetchCount);
       }
     } else {
       boolean isAdv = true;
@@ -165,9 +163,6 @@ private void check(PeerConnection peer, FetchInvDataMessage fetchInvDataMsg) thr
         if (outBlockCountIn1min > producedBlockIn2min) {
           logger.error("producedBlockIn2min: " + producedBlockIn2min + ", outBlockCountIn1min: "
               + outBlockCountIn1min);
-          //throw new P2pException(TypeEnum.BAD_MESSAGE, "producedBlockIn2min: "
-          // + producedBlockIn2min
-          //  + ", outBlockCountIn1min: " + outBlockCountIn1min);
         }
       } else {
         if (!peer.isNeedSyncFromUs()) {

framework/src/main/java/org/tron/core/net/messagehandler/TransactionsMsgHandler.java

@@ -37,7 +37,6 @@ public class TransactionsMsgHandler implements TronMsgHandler {
   @Autowired
   private AdvService advService;
 
-  //  private static int TIME_OUT = 10 * 60 * 1000;
   private BlockingQueue<TrxEvent> smartContractQueue = new LinkedBlockingQueue(MAX_TRX_SIZE);
 
   private BlockingQueue<Runnable> queue = new LinkedBlockingQueue();

framework/src/main/java/org/tron/core/net/peer/PeerStatusCheck.java

@@ -27,7 +27,7 @@ public void init() {
       try {
         statusCheck();
       } catch (Exception e) {
-        logger.error("Unhandled exception", e);
+        logger.error("", e);
       }
     }, 5, 2, TimeUnit.SECONDS);
   }

framework/src/main/java/org/tron/core/net/service/AdvService.java

@@ -83,15 +83,15 @@ public void init() {
       try {
         consumerInvToSpread();
       } catch (Exception exception) {
-        logger.error("Spread thread error.", exception.getMessage());
+        logger.error("Spread thread error. {}", exception.getMessage());
       }
     }, 100, 30, TimeUnit.MILLISECONDS);
 
     fetchExecutor.scheduleWithFixedDelay(() -> {
       try {
         consumerInvToFetch();
       } catch (Exception exception) {
-        logger.error("Fetch thread error.", exception.getMessage());
+        logger.error("Fetch thread error. {}", exception.getMessage());
       }
     }, 100, 30, TimeUnit.MILLISECONDS);
   }