feat: optimize ZksnarkParams initialization in tests.

Author: Federico2014

framework/src/test/java/org/tron/core/ShieldWalletTest.java

@@ -7,6 +7,7 @@
 import java.math.BigInteger;
 import javax.annotation.Resource;
 import org.junit.Assert;
+import org.junit.BeforeClass;
 import org.junit.Test;
 import org.tron.api.GrpcAPI.PrivateParameters;
 import org.tron.api.GrpcAPI.PrivateParametersWithoutAsk;
@@ -29,13 +30,14 @@ public class ShieldWalletTest extends BaseTest {
   @Resource
   private Wallet wallet;
 
-  static {
-    Args.setParam(new String[] {"-d", dbPath()}, Constant.TEST_CONF);
+  @BeforeClass
+  public static void init() {
+    Args.setParam(new String[]{"-d", dbPath()}, Constant.TEST_CONF);
+    librustzcashInitZksnarkParams();
   }
 
   @Test
   public void testCreateShieldedTransaction1() {
-    librustzcashInitZksnarkParams();
     String transactionStr1 = new String(ByteArray.fromHexString(
         "0x7b0a20202020227472616e73706172656e745f66726f6d5f61646472657373223a202234433930413"
             + "73241433344414546324536383932343545463430303839443634314345414337373433323433414233"
@@ -68,7 +70,6 @@ public void testCreateShieldedTransaction1() {
 
   @Test
   public void testCreateShieldedTransaction2() {
-    librustzcashInitZksnarkParams();
     String transactionStr2 = new String(ByteArray.fromHexString(
         "7b0a202020202261736b223a20223938666430333136376632333437623534643737323338343137663"
             + "6373038643537323939643938376362613838353564653037626532346236316464653064222c0a2020"
@@ -176,7 +177,6 @@ public void testCreateShieldedTransaction2() {
 
   @Test
   public void testCreateShieldedTransactionWithoutSpendAuthSig() {
-    librustzcashInitZksnarkParams();
     String transactionStr3 = new String(ByteArray.fromHexString(
         "7b0a2020202022616b223a2022373161643638633466353035373464356164333735343863626538363"
             + "63031663732393662393161306362303535353733313462373830383437323730326465222c0a202020"
@@ -286,7 +286,6 @@ public void testCreateShieldedTransactionWithoutSpendAuthSig() {
 
   @Test
   public void testGetNewShieldedAddress() {
-    librustzcashInitZksnarkParams();
     try {
       ShieldedAddressInfo shieldedAddressInfo = wallet.getNewShieldedAddress();
       Assert.assertNotNull(shieldedAddressInfo);
@@ -297,7 +296,6 @@ public void testGetNewShieldedAddress() {
 
   @Test
   public void testCreateShieldedContractParameters() throws ContractExeException {
-    librustzcashInitZksnarkParams();
     Args.getInstance().setAllowShieldedTransactionApi(true);
     Wallet wallet1 = spy(new Wallet());
 
@@ -340,7 +338,6 @@ public void testCreateShieldedContractParameters() throws ContractExeException {
 
   @Test
   public void testCreateShieldedContractParameters2() throws ContractExeException {
-    librustzcashInitZksnarkParams();
     Args.getInstance().setAllowShieldedTransactionApi(true);
     Wallet wallet1 = spy(new Wallet());
 
@@ -416,7 +413,6 @@ public void testCreateShieldedContractParameters2() throws ContractExeException
 
   @Test
   public void testCreateShieldedContractParametersWithoutAsk() throws ContractExeException {
-    librustzcashInitZksnarkParams();
     Args.getInstance().setAllowShieldedTransactionApi(true);
 
     Wallet wallet1 = spy(new Wallet());

framework/src/test/java/org/tron/core/ShieldedTRC20BuilderTest.java

@@ -1,7 +1,5 @@
 package org.tron.core;
 
-import static org.tron.core.zksnark.LibrustzcashTest.librustzcashInitZksnarkParams;
-
 import com.google.protobuf.ByteString;
 import java.math.BigInteger;
 import java.util.Arrays;
@@ -12,7 +10,7 @@
 import org.apache.commons.lang3.tuple.Pair;
 import org.bouncycastle.util.encoders.Hex;
 import org.junit.Assert;
-import org.junit.Before;
+import org.junit.BeforeClass;
 import org.junit.Ignore;
 import org.junit.Test;
 import org.tron.api.GrpcAPI;
@@ -68,16 +66,16 @@ public class ShieldedTRC20BuilderTest extends BaseTest {
     SHIELDED_CONTRACT_ADDRESS = WalletClient.decodeFromBase58Check(SHIELDED_CONTRACT_ADDRESS_STR);
     DEFAULT_OVK = ByteArray
         .fromHexString("030c8c2bc59fb3eb8afb047a8ea4b028743d23e7d38c6fa30908358431e2314d");
-    ZksnarkInitService.librustzcashInitZksnarkParams();
     PUBLIC_TO_ADDRESS = WalletClient.decodeFromBase58Check(PUBLIC_TO_ADDRESS_STR);
   }
 
   VerifyMintProof mintContract = new VerifyMintProof();
   VerifyTransferProof transferContract = new VerifyTransferProof();
   VerifyBurnProof burnContract = new VerifyBurnProof();
 
-  @Before
-  public void before() {
+  @BeforeClass
+  public static void initZksnarkParams() {
+    ZksnarkInitService.librustzcashInitZksnarkParams();
   }
 
   @Ignore
@@ -2172,7 +2170,6 @@ public void createShieldedContractParametersWithoutAskForBurn1to2()
   @Ignore
   @Test
   public void getTriggerInputForForMint() throws Exception {
-    librustzcashInitZksnarkParams();
     SpendingKey sk = SpendingKey.random();
     ExpandedSpendingKey expsk = sk.expandedSpendingKey();
     byte[] ovk = expsk.getOvk();
@@ -2241,7 +2238,6 @@ public void getTriggerInputForForMint() throws Exception {
   public void testScanShieldedTRC20NotesByIvk() throws Exception {
     int statNum = 1;
     int endNum = 100;
-    librustzcashInitZksnarkParams();
     SpendingKey sk = SpendingKey.decode(priKey);
     FullViewingKey fvk = sk.fullViewingKey();
     byte[] ivk = fvk.inViewingKey().value;
@@ -2273,7 +2269,6 @@ public void testscanShieldedTRC20NotesByOvk() throws Exception {
   public void isShieldedTRC20ContractNoteSpent() throws Exception {
     int statNum = 9200;
     int endNum = 9240;
-    librustzcashInitZksnarkParams();
     SpendingKey sk = SpendingKey.decode(priKey);
     FullViewingKey fvk = sk.fullViewingKey();
     byte[] ivk = fvk.inViewingKey().value;
@@ -2350,7 +2345,6 @@ private byte[] decodePath(byte[] encodedPath) {
   private GrpcAPI.PrivateShieldedTRC20Parameters mintParams(String privKey,
       long value, String contractAddr, byte[] rcm)
       throws ZksnarkException, ContractValidateException {
-    librustzcashInitZksnarkParams();
     long fromAmount = value;
     SpendingKey sk = SpendingKey.decode(privKey);
     ExpandedSpendingKey expsk = sk.expandedSpendingKey();

framework/src/test/java/org/tron/core/zksnark/LibrustzcashTest.java

@@ -85,6 +85,7 @@ public static void init() {
         "config-test-mainnet.conf"
     );
     Args.getInstance().setAllowShieldedTransactionApi(true);
+    ZksnarkInitService.librustzcashInitZksnarkParams();
   }
 
   private static int randomInt(int minInt, int maxInt) {
@@ -115,10 +116,6 @@ public static void test(byte[] K, byte[] ovk, byte[] cv, byte[] cm, byte[] epk)
             null, 0, cipher_nonce, K)));
   }
 
-  public static void librustzcashInitZksnarkParams() {
-    ZksnarkInitService.librustzcashInitZksnarkParams();
-  }
-
   @Test
   public void testLibsodium() throws ZksnarkException {
     byte[] K = new byte[32];
@@ -275,7 +272,6 @@ public long benchmarkCreateSpend() throws ZksnarkException {
   @Ignore
   @Test
   public void calBenchmarkSpendConcurrent() throws Exception {
-    librustzcashInitZksnarkParams();
     System.out.println("--- load ok ---");
 
     int count = 2;
@@ -307,7 +303,6 @@ public void calBenchmarkSpendConcurrent() throws Exception {
 
   @Test
   public void calBenchmarkSpend() throws ZksnarkException {
-    librustzcashInitZksnarkParams();
     System.out.println("--- load ok ---");
 
     int count = 2;
@@ -374,7 +369,6 @@ public long benchmarkCreateSaplingSpend() throws BadItemException, ZksnarkExcept
 
   @Test
   public void calBenchmarkCreateSaplingSpend() throws BadItemException, ZksnarkException {
-    librustzcashInitZksnarkParams();
     System.out.println("--- load ok ---");
 
     int count = 2;
@@ -451,7 +445,6 @@ public long benchmarkCreateSaplingOutput() throws BadItemException, ZksnarkExcep
 
   @Test
   public void calBenchmarkCreateSaplingOutPut() throws BadItemException, ZksnarkException {
-    librustzcashInitZksnarkParams();
     System.out.println("--- load ok ---");
 
     int count = 2;
@@ -479,7 +472,6 @@ public void calBenchmarkCreateSaplingOutPut() throws BadItemException, ZksnarkEx
 
   @Test
   public void checkVerifyOutErr() throws ZksnarkException {
-    librustzcashInitZksnarkParams();
     System.out.println("--- load ok ---");
 
     // expect fail