Skip to content

Commit 8ec46aa

Browse files
committed
use shoudownnow instead of shutdown in close Channel
1 parent 6df929f commit 8ec46aa

File tree

8 files changed

+19
-74
lines changed

8 files changed

+19
-74
lines changed

framework/src/main/java/org/tron/common/application/TronApplicationContext.java

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -13,8 +13,10 @@ public TronApplicationContext(DefaultListableBeanFactory beanFactory) {
1313
super(beanFactory);
1414
}
1515

16+
//only used for testcase
1617
public TronApplicationContext(Class<?>... annotatedClasses) {
1718
super(annotatedClasses);
19+
this.registerShutdownHook();
1820
}
1921

2022
public TronApplicationContext(String... basePackages) {

framework/src/test/java/org/tron/core/CreateCommonTransactionTest.java

Lines changed: 0 additions & 62 deletions
This file was deleted.

framework/src/test/java/org/tron/core/net/services/EffectiveCheckServiceTest.java

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -7,6 +7,7 @@
77
import org.junit.BeforeClass;
88
import org.junit.Test;
99
import org.tron.common.BaseTest;
10+
import org.tron.common.utils.PublicMethod;
1011
import org.tron.common.utils.ReflectUtils;
1112
import org.tron.core.Constant;
1213
import org.tron.core.config.args.Args;
@@ -40,17 +41,18 @@ public void testNoIpv4() throws Exception {
4041

4142
@Test
4243
public void testFind() {
44+
int port = PublicMethod.chooseRandomPort();
4345
P2pConfig p2pConfig = new P2pConfig();
4446
p2pConfig.setIp("127.0.0.1");
45-
p2pConfig.setPort(34567);
47+
p2pConfig.setPort(port);
4648
ReflectUtils.setFieldValue(tronNetService, "p2pConfig", p2pConfig);
4749
TronNetService.getP2pService().start(p2pConfig);
4850

4951
service.triggerNext();
5052
Assert.assertNull(service.getCur());
5153

5254
ReflectUtils.invokeMethod(service, "resetCount");
53-
InetSocketAddress cur = new InetSocketAddress("192.168.0.1", 34567);
55+
InetSocketAddress cur = new InetSocketAddress("192.168.0.1", port);
5456
service.setCur(cur);
5557
service.onDisconnect(cur);
5658
}

framework/src/test/java/org/tron/core/services/RpcApiServicesTest.java

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -189,13 +189,13 @@ public static void init() throws IOException {
189189
@AfterClass
190190
public static void destroy() {
191191
if (channelFull != null) {
192-
channelFull.shutdown();
192+
channelFull.shutdownNow();
193193
}
194194
if (channelPBFT != null) {
195-
channelPBFT.shutdown();
195+
channelPBFT.shutdownNow();
196196
}
197197
if (channelSolidity != null) {
198-
channelSolidity.shutdown();
198+
channelSolidity.shutdownNow();
199199
}
200200
context.close();
201201
appTest.shutdown();

framework/src/test/java/org/tron/core/services/filter/LiteFnQueryGrpcInterceptorTest.java

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -90,13 +90,13 @@ public static void init() throws IOException {
9090
@AfterClass
9191
public static void destroy() throws InterruptedException {
9292
if (channelFull != null) {
93-
channelFull.shutdown();
93+
channelFull.shutdownNow();
9494
}
9595
if (channelSolidity != null) {
96-
channelSolidity.shutdown();
96+
channelSolidity.shutdownNow();
9797
}
9898
if (channelpBFT != null) {
99-
channelpBFT.shutdown();
99+
channelpBFT.shutdownNow();
100100
}
101101
context.close();
102102
Args.clearParam();

framework/src/test/java/org/tron/core/services/filter/RpcApiAccessInterceptorTest.java

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -97,13 +97,13 @@ public static void init() throws IOException {
9797
@AfterClass
9898
public static void destroy() {
9999
if (channelFull != null) {
100-
channelFull.shutdown();
100+
channelFull.shutdownNow();
101101
}
102102
if (channelPBFT != null) {
103-
channelPBFT.shutdown();
103+
channelPBFT.shutdownNow();
104104
}
105105
if (channelSolidity != null) {
106-
channelSolidity.shutdown();
106+
channelSolidity.shutdownNow();
107107
}
108108
context.close();
109109
Args.clearParam();

framework/src/test/java/org/tron/program/SolidityNodeTest.java

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -9,6 +9,7 @@
99
import org.junit.Test;
1010
import org.tron.common.BaseTest;
1111
import org.tron.common.client.DatabaseGrpcClient;
12+
import org.tron.common.utils.PublicMethod;
1213
import org.tron.core.Constant;
1314
import org.tron.core.config.args.Args;
1415
import org.tron.core.exception.TronError;
@@ -27,6 +28,8 @@ public class SolidityNodeTest extends BaseTest {
2728

2829
static {
2930
Args.setParam(new String[]{"-d", dbPath(), "--solidity"}, Constant.TEST_CONF);
31+
Args.getInstance().setRpcPort(PublicMethod.chooseRandomPort());
32+
Args.getInstance().setSolidityHttpPort(PublicMethod.chooseRandomPort());
3033
}
3134

3235
@Test

plugins/src/test/java/org/tron/plugins/DbLiteTest.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -62,7 +62,7 @@ public void startApp() {
6262
*/
6363
public void shutdown() throws InterruptedException {
6464
if (channelFull != null) {
65-
channelFull.shutdown().awaitTermination(5, TimeUnit.SECONDS);
65+
channelFull.shutdownNow();
6666
}
6767
context.close();
6868
}

0 commit comments

Comments
 (0)