fix(api): fix the bug of determine if triggerConstantContract succeeds (#5688)

* fix(api):fix the bug of determine if get scale factor succeed

* fix(api):fix bug of isShieldedTRC20NoteSpent

Author: 317787106

framework/src/main/java/org/tron/core/Wallet.java

@@ -3862,11 +3862,12 @@ private boolean isShieldedTRC20NoteSpent(GrpcAPI.Note note, long pos, byte[] ak,
     TransactionExtention.Builder trxExtBuilder = TransactionExtention.newBuilder();
     Return.Builder retBuilder = Return.newBuilder();
     TransactionExtention trxExt;
+    Transaction trx;
 
     try {
       TransactionCapsule trxCap = createTransactionCapsule(trigger,
           ContractType.TriggerSmartContract);
-      Transaction trx = triggerConstantContract(trigger, trxCap, trxExtBuilder, retBuilder);
+      trx = triggerConstantContract(trigger, trxCap, trxExtBuilder, retBuilder);
 
       retBuilder.setResult(true).setCode(response_code.SUCCESS);
       trxExtBuilder.setTransaction(trx);
@@ -3889,10 +3890,10 @@ private boolean isShieldedTRC20NoteSpent(GrpcAPI.Note note, long pos, byte[] ak,
       logger.warn("unknown exception caught: " + e.getMessage(), e);
     } finally {
       trxExt = trxExtBuilder.build();
+      trx = trxExt.getTransaction();
     }
 
-    String code = trxExt.getResult().getCode().toString();
-    if ("SUCCESS".equals(code)) {
+    if (code.SUCESS == trx.getRet(0).getRet()) {
       List<ByteString> list = trxExt.getConstantResultList();
       byte[] listBytes = new byte[0];
       for (ByteString bs : list) {
@@ -4126,11 +4127,12 @@ public byte[] getShieldedContractScalingFactor(byte[] contractAddress)
     TransactionExtention.Builder trxExtBuilder = TransactionExtention.newBuilder();
     Return.Builder retBuilder = Return.newBuilder();
     TransactionExtention trxExt;
+    Transaction trx;
 
     try {
       TransactionCapsule trxCap = createTransactionCapsule(trigger,
           ContractType.TriggerSmartContract);
-      Transaction trx = triggerConstantContract(trigger, trxCap, trxExtBuilder, retBuilder);
+      trx = triggerConstantContract(trigger, trxCap, trxExtBuilder, retBuilder);
 
       retBuilder.setResult(true).setCode(response_code.SUCCESS);
       trxExtBuilder.setTransaction(trx);
@@ -4153,10 +4155,10 @@ public byte[] getShieldedContractScalingFactor(byte[] contractAddress)
       logger.warn("Unknown exception caught: " + e.getMessage(), e);
     } finally {
       trxExt = trxExtBuilder.build();
+      trx = trxExt.getTransaction();
     }
 
-    String code = trxExt.getResult().getCode().toString();
-    if ("SUCCESS".equals(code)) {
+    if (code.SUCESS == trx.getRet(0).getRet()) {
       List<ByteString> list = trxExt.getConstantResultList();
       byte[] listBytes = new byte[0];
       for (ByteString bs : list) {

framework/src/test/java/org/tron/core/capsule/utils/RLPListTest.java

@@ -2,8 +2,12 @@
 
 import java.lang.reflect.InvocationTargetException;
 import java.lang.reflect.Method;
+import java.math.BigInteger;
+import java.util.Random;
+import org.bouncycastle.util.BigIntegers;
 import org.junit.Assert;
 import org.junit.Test;
+import org.tron.common.utils.Value;
 
 public class RLPListTest {
 
@@ -34,5 +38,44 @@ public void testToBytes()
     byte[] aBytes = new byte[10];
     byte[] bBytes = (byte[]) method.invoke(RLP.class, aBytes);
     Assert.assertArrayEquals(aBytes, bBytes);
+
+    int i = new Random().nextInt();
+    byte[] cBytes = BigIntegers.asUnsignedByteArray(BigInteger.valueOf(i));
+    byte[] dBytes = (byte[]) method.invoke(RLP.class, i);
+    Assert.assertArrayEquals(cBytes, dBytes);
+
+    long j = new Random().nextInt();
+    byte[] eBytes = BigIntegers.asUnsignedByteArray(BigInteger.valueOf(j));
+    byte[] fBytes = (byte[]) method.invoke(RLP.class, j);
+    Assert.assertArrayEquals(eBytes, fBytes);
+
+    String test = "testA";
+    byte[] gBytes = test.getBytes();
+    byte[] hBytes = (byte[]) method.invoke(RLP.class, test);
+    Assert.assertArrayEquals(gBytes, hBytes);
+
+    BigInteger bigInteger = BigInteger.valueOf(100);
+    byte[] iBytes = BigIntegers.asUnsignedByteArray(bigInteger);
+    byte[] jBytes = (byte[]) method.invoke(RLP.class, bigInteger);
+    Assert.assertArrayEquals(iBytes, jBytes);
+
+    Value v = new Value(new byte[0]);
+    byte[] kBytes = v.asBytes();
+    byte[] lBytes = (byte[]) method.invoke(RLP.class, v);
+    Assert.assertArrayEquals(kBytes, lBytes);
+
+    char c = 'a';
+    try {
+      method.invoke(RLP.class, c);
+      Assert.fail();
+    } catch (Exception e) {
+      Assert.assertTrue(true);
+    }
+  }
+
+  @Test
+  public void testEncode() {
+    byte[] aBytes = RLP.encode(new byte[1]);
+    Assert.assertEquals(1, aBytes.length);
   }
 }