Merge pull request #422 from tropicsquare/ETR01SDK-498-Don-t-call-lt_deinit-if-lt_init-fails

medexs · web-flow · commit 4f869404d3d3 · 2026-01-20T08:59:51.000+01:00
ETR01SDK-498: Don't call lt_deinit if lt_init fails
diff --git a/docs/get_started/integrating_libtropic/how_to_use/index.md b/docs/get_started/integrating_libtropic/how_to_use/index.md
@@ -89,7 +89,6 @@ int main(void) {
     // first.
     lt_ret_t ret = lt_init(h);
     if (LT_OK != ret) {
-        lt_deinit(h);
         return -1;
     }
 
diff --git a/examples/linux/spi_devkit/fw_update/main.c b/examples/linux/spi_devkit/fw_update/main.c
@@ -93,7 +93,6 @@ int main(void)
     lt_ret_t ret = lt_init(&lt_handle);
     if (LT_OK != ret) {
         fprintf(stderr, "\nFailed to initialize handle, ret=%s\n", lt_ret_verbose(ret));
-        lt_deinit(&lt_handle);
         mbedtls_psa_crypto_free();
         return -1;
     }
diff --git a/examples/linux/spi_devkit/hello_world/main.c b/examples/linux/spi_devkit/hello_world/main.c
@@ -80,7 +80,6 @@ int main(void)
     lt_ret_t ret = lt_init(&lt_handle);
     if (LT_OK != ret) {
         fprintf(stderr, "\nFailed to initialize handle, ret=%s\n", lt_ret_verbose(ret));
-        lt_deinit(&lt_handle);
         mbedtls_psa_crypto_free();
         return -1;
     }
diff --git a/examples/linux/spi_devkit/identify_chip/main.c b/examples/linux/spi_devkit/identify_chip/main.c
@@ -66,7 +66,6 @@ int main(void)
     lt_ret_t ret = lt_init(&lt_handle);
     if (LT_OK != ret) {
         fprintf(stderr, "\nFailed to initialize handle, ret=%s\n", lt_ret_verbose(ret));
-        lt_deinit(&lt_handle);
         mbedtls_psa_crypto_free();
         return -1;
     }
diff --git a/examples/linux/usb_devkit/fw_update/main.c b/examples/linux/usb_devkit/fw_update/main.c
@@ -85,7 +85,6 @@ int main(void)
     lt_ret_t ret = lt_init(&lt_handle);
     if (LT_OK != ret) {
         fprintf(stderr, "\nFailed to initialize handle, ret=%s\n", lt_ret_verbose(ret));
-        lt_deinit(&lt_handle);
         mbedtls_psa_crypto_free();
         return -1;
     }
diff --git a/examples/linux/usb_devkit/hello_world/main.c b/examples/linux/usb_devkit/hello_world/main.c
@@ -72,7 +72,6 @@ int main(void)
     lt_ret_t ret = lt_init(&lt_handle);
     if (LT_OK != ret) {
         fprintf(stderr, "\nFailed to initialize handle, ret=%s\n", lt_ret_verbose(ret));
-        lt_deinit(&lt_handle);
         mbedtls_psa_crypto_free();
         return -1;
     }
diff --git a/examples/linux/usb_devkit/identify_chip/main.c b/examples/linux/usb_devkit/identify_chip/main.c
@@ -58,7 +58,6 @@ int main(void)
     lt_ret_t ret = lt_init(&lt_handle);
     if (LT_OK != ret) {
         fprintf(stderr, "\nFailed to initialize handle, ret=%s\n", lt_ret_verbose(ret));
-        lt_deinit(&lt_handle);
         mbedtls_psa_crypto_free();
         return -1;
     }
diff --git a/examples/model/hello_world/main.c b/examples/model/hello_world/main.c
@@ -77,7 +77,6 @@ int main(void)
     lt_ret_t ret = lt_init(&lt_handle);
     if (LT_OK != ret) {
         fprintf(stderr, "\nFailed to initialize handle, ret=%s\n", lt_ret_verbose(ret));
-        lt_deinit(&lt_handle);
         mbedtls_psa_crypto_free();
         return -1;
     }
diff --git a/examples/model/hw_wallet/main.c b/examples/model/hw_wallet/main.c
@@ -840,7 +840,6 @@ int main(void)
     lt_ret_t ret = lt_init(&lt_handle);
     if (LT_OK != ret) {
         fprintf(stderr, "\nFailed to initialize handle, ret=%s\n", lt_ret_verbose(ret));
-        lt_deinit(&lt_handle);
         mbedtls_psa_crypto_free();
         return -1;
     }
diff --git a/examples/model/mac_and_destroy/main.c b/examples/model/mac_and_destroy/main.c
@@ -570,7 +570,6 @@ int main(void)
     lt_ret_t ret = lt_init(&lt_handle);
     if (ret != LT_OK) {
         fprintf(stderr, "\nFailed to initialize handle, ret=%s\n", lt_ret_verbose(ret));
-        lt_deinit(&lt_handle);
         mbedtls_psa_crypto_free();
         return -1;
     }
diff --git a/examples/stm32/nucleo_f439zi/fw_update/Src/main.c b/examples/stm32/nucleo_f439zi/fw_update/Src/main.c
@@ -251,7 +251,6 @@ int main(void)
     lt_ret_t ret = lt_init(&lt_handle);
     if (LT_OK != ret) {
         fprintf(stderr, "\nFailed to initialize handle, ret=%s\n", lt_ret_verbose(ret));
-        lt_deinit(&lt_handle);
         mbedtls_psa_crypto_free();
         return -1;
     }
diff --git a/examples/stm32/nucleo_f439zi/hello_world/Src/main.c b/examples/stm32/nucleo_f439zi/hello_world/Src/main.c
@@ -222,7 +222,6 @@ int main(void)
     lt_ret_t ret = lt_init(&lt_handle);
     if (LT_OK != ret) {
         fprintf(stderr, "\nFailed to initialize handle, ret=%s\n", lt_ret_verbose(ret));
-        lt_deinit(&lt_handle);
         mbedtls_psa_crypto_free();
         return -1;
     }
diff --git a/examples/stm32/nucleo_f439zi/identify_chip/Src/main.c b/examples/stm32/nucleo_f439zi/identify_chip/Src/main.c
@@ -219,7 +219,6 @@ int main(void)
     lt_ret_t ret = lt_init(&lt_handle);
     if (LT_OK != ret) {
         fprintf(stderr, "\nFailed to initialize handle, ret=%s\n", lt_ret_verbose(ret));
-        lt_deinit(&lt_handle);
         mbedtls_psa_crypto_free();
         return -1;
     }
diff --git a/examples/stm32/nucleo_l432kc/fw_update/Src/main.c b/examples/stm32/nucleo_l432kc/fw_update/Src/main.c
@@ -279,7 +279,6 @@ int main(void)
     lt_ret_t ret = lt_init(&lt_handle);
     if (LT_OK != ret) {
         fprintf(stderr, "\nFailed to initialize handle, ret=%s\n", lt_ret_verbose(ret));
-        lt_deinit(&lt_handle);
         mbedtls_psa_crypto_free();
         return -1;
     }
diff --git a/examples/stm32/nucleo_l432kc/hello_world/Src/main.c b/examples/stm32/nucleo_l432kc/hello_world/Src/main.c
@@ -250,7 +250,6 @@ int main(void)
     lt_ret_t ret = lt_init(&lt_handle);
     if (LT_OK != ret) {
         fprintf(stderr, "\nFailed to initialize handle, ret=%s\n", lt_ret_verbose(ret));
-        lt_deinit(&lt_handle);
         mbedtls_psa_crypto_free();
         return -1;
     }
diff --git a/examples/stm32/nucleo_l432kc/identify_chip/Src/main.c b/examples/stm32/nucleo_l432kc/identify_chip/Src/main.c
@@ -247,7 +247,6 @@ int main(void)
     lt_ret_t ret = lt_init(&lt_handle);
     if (LT_OK != ret) {
         fprintf(stderr, "\nFailed to initialize handle, ret=%s\n", lt_ret_verbose(ret));
-        lt_deinit(&lt_handle);
         mbedtls_psa_crypto_free();
         return -1;
     }
diff --git a/include/libtropic.h b/include/libtropic.h
@@ -26,7 +26,8 @@ extern "C" {
 #endif
 
 /**
- * @brief Initialize handle and transport layer
+ * @brief Initialize handle and transport layer.
+ * @note If the function fails, `lt_deinit` must not be called. In this case, the function handles the cleanup itself.
  *
  * @param h           Handle for communication with TROPIC01
  *

Original file line number	Diff line number	Diff line change
`@@ -89,7 +89,6 @@ int main(void) {`
`89`	`89`	`// first.`
`90`	`90`	`lt_ret_t ret = lt_init(h);`
`91`	`91`	`if (LT_OK != ret) {`
`92`		`- lt_deinit(h);`
`93`	`92`	`return -1;`
`94`	`93`	`}`
`95`	`94`
Original file line number	Diff line number	Diff line change
`@@ -93,7 +93,6 @@ int main(void)`
`93`	`93`	`lt_ret_t ret = lt_init(&lt_handle);`
`94`	`94`	`if (LT_OK != ret) {`
`95`	`95`	`fprintf(stderr, "\nFailed to initialize handle, ret=%s\n", lt_ret_verbose(ret));`
`96`		`- lt_deinit(&lt_handle);`
`97`	`96`	`mbedtls_psa_crypto_free();`
`98`	`97`	`return -1;`
`99`	`98`	`}`
Original file line number	Diff line number	Diff line change
`@@ -80,7 +80,6 @@ int main(void)`
`80`	`80`	`lt_ret_t ret = lt_init(&lt_handle);`
`81`	`81`	`if (LT_OK != ret) {`
`82`	`82`	`fprintf(stderr, "\nFailed to initialize handle, ret=%s\n", lt_ret_verbose(ret));`
`83`		`- lt_deinit(&lt_handle);`
`84`	`83`	`mbedtls_psa_crypto_free();`
`85`	`84`	`return -1;`
`86`	`85`	`}`
Original file line number	Diff line number	Diff line change
`@@ -66,7 +66,6 @@ int main(void)`
`66`	`66`	`lt_ret_t ret = lt_init(&lt_handle);`
`67`	`67`	`if (LT_OK != ret) {`
`68`	`68`	`fprintf(stderr, "\nFailed to initialize handle, ret=%s\n", lt_ret_verbose(ret));`
`69`		`- lt_deinit(&lt_handle);`
`70`	`69`	`mbedtls_psa_crypto_free();`
`71`	`70`	`return -1;`
`72`	`71`	`}`
Original file line number	Diff line number	Diff line change
`@@ -85,7 +85,6 @@ int main(void)`
`85`	`85`	`lt_ret_t ret = lt_init(&lt_handle);`
`86`	`86`	`if (LT_OK != ret) {`
`87`	`87`	`fprintf(stderr, "\nFailed to initialize handle, ret=%s\n", lt_ret_verbose(ret));`
`88`		`- lt_deinit(&lt_handle);`
`89`	`88`	`mbedtls_psa_crypto_free();`
`90`	`89`	`return -1;`
`91`	`90`	`}`
Original file line number	Diff line number	Diff line change
`@@ -72,7 +72,6 @@ int main(void)`
`72`	`72`	`lt_ret_t ret = lt_init(&lt_handle);`
`73`	`73`	`if (LT_OK != ret) {`
`74`	`74`	`fprintf(stderr, "\nFailed to initialize handle, ret=%s\n", lt_ret_verbose(ret));`
`75`		`- lt_deinit(&lt_handle);`
`76`	`75`	`mbedtls_psa_crypto_free();`
`77`	`76`	`return -1;`
`78`	`77`	`}`
Original file line number	Diff line number	Diff line change
`@@ -58,7 +58,6 @@ int main(void)`
`58`	`58`	`lt_ret_t ret = lt_init(&lt_handle);`
`59`	`59`	`if (LT_OK != ret) {`
`60`	`60`	`fprintf(stderr, "\nFailed to initialize handle, ret=%s\n", lt_ret_verbose(ret));`
`61`		`- lt_deinit(&lt_handle);`
`62`	`61`	`mbedtls_psa_crypto_free();`
`63`	`62`	`return -1;`
`64`	`63`	`}`
Original file line number	Diff line number	Diff line change
`@@ -77,7 +77,6 @@ int main(void)`
`77`	`77`	`lt_ret_t ret = lt_init(&lt_handle);`
`78`	`78`	`if (LT_OK != ret) {`
`79`	`79`	`fprintf(stderr, "\nFailed to initialize handle, ret=%s\n", lt_ret_verbose(ret));`
`80`		`- lt_deinit(&lt_handle);`
`81`	`80`	`mbedtls_psa_crypto_free();`
`82`	`81`	`return -1;`
`83`	`82`	`}`
Original file line number	Diff line number	Diff line change
`@@ -840,7 +840,6 @@ int main(void)`
`840`	`840`	`lt_ret_t ret = lt_init(&lt_handle);`
`841`	`841`	`if (LT_OK != ret) {`
`842`	`842`	`fprintf(stderr, "\nFailed to initialize handle, ret=%s\n", lt_ret_verbose(ret));`
`843`		`- lt_deinit(&lt_handle);`
`844`	`843`	`mbedtls_psa_crypto_free();`
`845`	`844`	`return -1;`
`846`	`845`	`}`
Original file line number	Diff line number	Diff line change
`@@ -570,7 +570,6 @@ int main(void)`
`570`	`570`	`lt_ret_t ret = lt_init(&lt_handle);`
`571`	`571`	`if (ret != LT_OK) {`
`572`	`572`	`fprintf(stderr, "\nFailed to initialize handle, ret=%s\n", lt_ret_verbose(ret));`
`573`		`- lt_deinit(&lt_handle);`
`574`	`573`	`mbedtls_psa_crypto_free();`
`575`	`574`	`return -1;`
`576`	`575`	`}`