tests: email tool add more test case

Author: 201430098137

tool/email/sendmail.go

@@ -52,7 +52,6 @@ type sendMailResponse struct {
 }
 
 // sendMail performs the send mail operation.
-// go smtp not support context, one send one mail, can't stop
 func (e *emailToolSet) sendMail(ctx context.Context, req *sendMailRequest) (rsp *sendMailResponse, err error) {
 	rsp = &sendMailResponse{}
 
@@ -81,7 +80,7 @@ func (e *emailToolSet) sendMail(ctx context.Context, req *sendMailRequest) (rsp
 		opts...,
 	)
 	if err != nil {
-		rsp.Message = fmt.Sprintf("the address or password is incorrect,please check: %v", err)
+		rsp.Message = fmt.Sprintf("the server address err: %v", err)
 		return rsp, nil
 	}
 

tool/email/sendmail_test.go

@@ -7,7 +7,7 @@ import (
 	"github.com/stretchr/testify/assert"
 )
 
-func TestMailTool_sendMail(t *testing.T) {
+func Test_emailToolSet_sendMail(t *testing.T) {
 	toolSet, err := NewToolSet(
 		WithSendEmailEnabled(true),
 	)
@@ -21,6 +21,7 @@ func TestMailTool_sendMail(t *testing.T) {
 		ToEmail  string
 		Subject  string
 		Content  string
+		wantErr  bool
 	}{
 
 		{
@@ -29,6 +30,7 @@ func TestMailTool_sendMail(t *testing.T) {
 			ToEmail:  "[email protected]",
 			Subject:  "test",
 			Content:  "test",
+			wantErr:  false,
 		},
 
 		{
@@ -37,13 +39,76 @@ func TestMailTool_sendMail(t *testing.T) {
 			ToEmail:  "[email protected]",
 			Subject:  "test",
 			Content:  "test",
+			wantErr:  false,
 		},
 	}
 	for _, tt := range tests {
 
+		rsp, err := toolSet.(*emailToolSet).sendMail(context.Background(), &sendMailRequest{
+			Auth: Auth{
+				Name:     tt.Name,
+				Password: tt.Password,
+			},
+			MailList: []*Mail{
+				{
+					ToEmail: tt.ToEmail,
+					Subject: tt.Subject,
+					Content: tt.Content,
+				},
+			},
+		})
+		t.Logf("rsp: %+v err:%v", rsp, err)
 		if tt.Password == "" {
-			t.Skip("no passwd skip")
+			t.Logf("password is empty, skip")
+			continue
 		}
+		if rsp.Message != "" {
+			if tt.wantErr == false {
+				t.Errorf("send mail err: %s", rsp.Message)
+			}
+		} else if tt.wantErr == true {
+			t.Errorf("should err but not")
+		}
+
+	}
+}
+
+func Test_emailToolSet_sendMail2(t *testing.T) {
+	toolSet, err := NewToolSet(
+		WithSendEmailEnabled(true),
+	)
+	if err != nil {
+		t.Errorf("NewToolSet failed, err: %v", err)
+	}
+
+	tests := []struct {
+		Name     string
+		Password string
+		ToEmail  string
+		Subject  string
+		Content  string
+		wantErr  bool
+	}{
+		// error case
+		{
+			Name:     "18503@[email protected]",
+			Password: "",
+			ToEmail:  "[email protected]",
+			Subject:  "test",
+			Content:  "test",
+			wantErr:  true,
+		},
+		// error case
+		{
+			Name:     "[email protected]",
+			Password: "",
+			ToEmail:  "185039@[email protected]",
+			Subject:  "test",
+			Content:  "test",
+			wantErr:  true,
+		},
+	}
+	for _, tt := range tests {
 
 		rsp, err := toolSet.(*emailToolSet).sendMail(context.Background(), &sendMailRequest{
 			Auth: Auth{
@@ -58,10 +123,15 @@ func TestMailTool_sendMail(t *testing.T) {
 				},
 			},
 		})
-		if err != nil {
-			t.Errorf("send mail err: %v", err)
+		t.Logf("rsp: %+v err:%v", rsp, err)
+		if rsp.Message != "" {
+			if tt.wantErr == false {
+				t.Errorf("send mail err: %s", rsp.Message)
+			}
+		} else if tt.wantErr == true {
+			t.Errorf("should err but not")
 		}
-		t.Logf("rsp: %+v", rsp)
+
 	}
 }
 
@@ -147,6 +217,12 @@ func Test_checkMailBoxType(t *testing.T) {
 			want:    MAIL_GMAIL,
 			wantErr: false,
 		},
+		{
+			name:    "not valid email",
+			args:    args{email: "UserGmAiL.cOm"},
+			want:    MAIL_UNKNOWN,
+			wantErr: true,
+		},
 	}
 	for _, tt := range tests {
 		t.Run(tt.name, func(t *testing.T) {