fix:goimports and golangci-lint and remove some test

Author: 201430098137

examples/email/main.go

@@ -9,6 +9,7 @@ import (
 	"os"
 	"strings"
 	"time"
+
 	"trpc.group/trpc-go/trpc-agent-go/agent/llmagent"
 	"trpc.group/trpc-go/trpc-agent-go/event"
 	"trpc.group/trpc-go/trpc-agent-go/model"
@@ -41,7 +42,7 @@ func main() {
 	}
 
 	if err := chat.run(); err != nil {
-		log.Fatal("Chat failed: %v", err)
+		log.Fatalf("Chat failed: %s", err.Error())
 	}
 }
 
@@ -67,7 +68,7 @@ func (c *emailChat) run() error {
 }
 
 // setup creates the runner with LLM agent and send email tool.
-func (c *emailChat) setup(ctx context.Context) error {
+func (c *emailChat) setup(_ context.Context) error {
 	// Create OpenAI model.
 	modelInstance := openai.New(c.modelName)
 

tool/email/email.go

@@ -13,6 +13,7 @@ package email
 
 import (
 	"context"
+
 	"trpc.group/trpc-go/trpc-agent-go/tool"
 )
 
@@ -21,27 +22,33 @@ const (
 	defaultName = "email"
 )
 
+// MailboxType mailbox
 type MailboxType int32
 
 const (
-	// unknown mail
+	// MAIL_UNKNOWN unknown mail
 	MAIL_UNKNOWN MailboxType = 0
-	// qq mail
+	// MAIL_QQ qq mail
 	MAIL_QQ MailboxType = 1
-	// 163 mail
+	// MAIL_163 163 mail
 	MAIL_163 MailboxType = 2
-	// google email
+	// MAIL_GMAIL google mail
 	MAIL_GMAIL MailboxType = 3
 )
 
+// MailboxTypeToString convert mailbox type to string
 func MailboxTypeToString(mailboxType MailboxType) string {
 	switch mailboxType {
+	// qq mail
 	case MAIL_QQ:
 		return "qq"
+	// 163 mail
 	case MAIL_163:
 		return "163"
+	// google mail
 	case MAIL_GMAIL:
 		return "gmail"
+	// unknown mail
 	default:
 		return "unknown"
 	}
@@ -72,7 +79,7 @@ type emailToolSet struct {
 }
 
 // Tools implements the ToolSet interface.
-func (e *emailToolSet) Tools(ctx context.Context) []tool.Tool {
+func (e *emailToolSet) Tools(_ context.Context) []tool.Tool {
 	return e.tools
 }
 

tool/email/sendmail.go

@@ -3,8 +3,9 @@ package email
 import (
 	"context"
 	"fmt"
-	"gopkg.in/gomail.v2"
 	"strings"
+
+	"gopkg.in/gomail.v2"
 	"trpc.group/trpc-go/trpc-agent-go/tool"
 	"trpc.group/trpc-go/trpc-agent-go/tool/function"
 )
@@ -33,7 +34,8 @@ type sendMailResponse struct {
 }
 
 // sendMail performs the send mail operation.
-func (e *emailToolSet) sendMail(ctx context.Context, req *sendMailRequest) (rsp *sendMailResponse, err error) {
+// go smtp not support context, one send one mail, can't stop
+func (e *emailToolSet) sendMail(_ context.Context, req *sendMailRequest) (rsp *sendMailResponse, err error) {
 	rsp = &sendMailResponse{}
 
 	mailBoxType, err := checkMailBoxType(req.Auth.Name)
@@ -63,8 +65,11 @@ func (e *emailToolSet) sendMail(ctx context.Context, req *sendMailRequest) (rsp
 	s, err := dialer.Dial()
 	if err != nil {
 		rsp.Message = fmt.Sprintf("the address or password is incorrect,please check: %v", err)
-		return rsp, fmt.Errorf("the address or password is incorrect,please check: %w", err)
+		return rsp, nil
 	}
+	defer func() {
+		_ = s.Close()
+	}()
 
 	message := gomail.NewMessage()
 	for _, m := range req.MailList {

tool/email/sendmail_test.go

@@ -3,6 +3,8 @@ package email
 import (
 	"context"
 	"testing"
+
+	"github.com/stretchr/testify/assert"
 )
 
 func TestMailTool_sendMail(t *testing.T) {
@@ -21,15 +23,15 @@ func TestMailTool_sendMail(t *testing.T) {
 		Subject  string
 		Content  string
 	}{
-		// qq to gmail
+
 		{
 			Name:     "[email protected]",
 			Password: "",
 			ToEmail:  "[email protected]",
 			Subject:  "test",
 			Content:  "test",
 		},
-		// gmail to qq
+
 		{
 			Name:     "[email protected]",
 			Password: "",
@@ -40,6 +42,10 @@ func TestMailTool_sendMail(t *testing.T) {
 	}
 	for _, tt := range tests {
 
+		if tt.Password == "" {
+			t.Skip("no passwd skip")
+		}
+
 		rsp, err := toolSet.(*emailToolSet).sendMail(context.Background(), &sendMailRequest{
 			Auth: Auth{
 				Name:     tt.Name,
@@ -54,8 +60,116 @@ func TestMailTool_sendMail(t *testing.T) {
 			},
 		})
 		if err != nil {
-			t.Errorf("send mail failed, err: %v", err)
+			t.Errorf("send mail err: %v", err)
 		}
 		t.Logf("rsp: %+v", rsp)
 	}
 }
+
+func Test_checkMailBoxType(t *testing.T) {
+	type args struct {
+		email string
+	}
+	tests := []struct {
+		name    string
+		args    args
+		want    MailboxType
+		wantErr bool
+	}{
+		{
+			name:    "QQ domain",
+			args:    args{email: "[email protected]"},
+			want:    MAIL_QQ,
+			wantErr: false,
+		},
+		{
+			name:    "QQ vip domain",
+			args:    args{email: "[email protected]"},
+			want:    MAIL_QQ,
+			wantErr: false,
+		},
+		{
+			name:    "Foxmail domain",
+			args:    args{email: "[email protected]"},
+			want:    MAIL_QQ,
+			wantErr: false,
+		},
+		{
+			name:    "Gmail domain",
+			args:    args{email: "[email protected]"},
+			want:    MAIL_GMAIL,
+			wantErr: false,
+		},
+		{
+			name:    "Googlemail domain",
+			args:    args{email: "[email protected]"},
+			want:    MAIL_GMAIL,
+			wantErr: false,
+		},
+		{
+			name:    "163 domain",
+			args:    args{email: "[email protected]"},
+			want:    MAIL_163,
+			wantErr: false,
+		},
+		{
+			name:    "Unknown domain",
+			args:    args{email: "[email protected]"},
+			want:    MAIL_UNKNOWN,
+			wantErr: false,
+		},
+		{
+			name:    "Empty email",
+			args:    args{email: ""},
+			want:    MAIL_UNKNOWN,
+			wantErr: true,
+		},
+		{
+			name:    "No @ symbol",
+			args:    args{email: "invalid-email"},
+			want:    MAIL_UNKNOWN,
+			wantErr: true,
+		},
+		{
+			name:    "Multiple @ symbols",
+			args:    args{email: "user@@example.com"},
+			want:    MAIL_UNKNOWN,
+			wantErr: true,
+		},
+		{
+			name:    "Uppercase QQ domain",
+			args:    args{email: "[email protected]"},
+			want:    MAIL_QQ,
+			wantErr: false,
+		},
+		{
+			name:    "Mixed case Gmail",
+			args:    args{email: "[email protected]"},
+			want:    MAIL_GMAIL,
+			wantErr: false,
+		},
+	}
+	for _, tt := range tests {
+		t.Run(tt.name, func(t *testing.T) {
+			got, err := checkMailBoxType(tt.args.email)
+			if (err != nil) != tt.wantErr {
+				t.Errorf("checkMailBoxType() error = %v, wantErr %v", err, tt.wantErr)
+				return
+			}
+			if got != tt.want {
+				t.Errorf("checkMailBoxType() = %v, want %v", got, tt.want)
+			}
+		})
+	}
+}
+
+func Test_emailToolSet_sendMailTool(t *testing.T) {
+	e := &emailToolSet{}
+
+	got := e.sendMailTool()
+	assert.NotNil(t, got)
+
+	decl := got.Declaration()
+	assert.Equal(t, "send_email", decl.Name)
+	assert.Equal(t, "send mail to other", decl.Description)
+}