Skip to content

Commit 9033d26

Browse files
committed
* fixes for CURL functions
1 parent 1c8ffd0 commit 9033d26

File tree

2 files changed

+18
-24
lines changed

2 files changed

+18
-24
lines changed

tests/curl/001-curl_exec_basic.phpt

Lines changed: 4 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -4,19 +4,18 @@ Basic async curl_exec GET request
44
curl
55
--FILE--
66
<?php
7-
include "../common/simple_http_server.php";
7+
include "../../sapi/cli/tests/php_cli_server.inc";
88

99
use function Async\spawn;
1010
use function Async\await;
1111

12-
// Start test server
13-
$server_pid = start_test_server_process(8088);
12+
php_cli_server_start();
1413

1514
function test_basic_get() {
1615
echo "Starting basic GET test\n";
1716

1817
$ch = curl_init();
19-
curl_setopt($ch, CURLOPT_URL, get_test_server_url('/'));
18+
curl_setopt($ch, CURLOPT_URL, "http://" . PHP_CLI_SERVER_ADDRESS);
2019
curl_setopt($ch, CURLOPT_RETURNTRANSFER, true);
2120
curl_setopt($ch, CURLOPT_TIMEOUT, 5);
2221

@@ -37,16 +36,12 @@ echo "Test start\n";
3736

3837
$coroutine = spawn(test_basic_get(...));
3938
$result = await($coroutine);
40-
41-
// Stop server
42-
stop_test_server_process($server_pid);
43-
4439
echo "Test end\n";
4540
?>
4641
--EXPECT--
4742
Test start
4843
Starting basic GET test
4944
HTTP Code: 200
5045
Error: none
51-
Response: Hello World
46+
Response: Hello world
5247
Test end

tests/curl/002-concurrent_requests.phpt

Lines changed: 14 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -4,19 +4,21 @@ Concurrent async cURL requests
44
curl
55
--FILE--
66
<?php
7-
include "../common/simple_http_server.php";
7+
include "../../sapi/cli/tests/php_cli_server.inc";
88

99
use function Async\spawn;
1010
use function Async\awaitAll;
1111

12-
// Start test server
13-
$server_pid = start_test_server_process(8088);
12+
php_cli_server_start();
1413

15-
function make_request($url, $id) {
14+
function make_request_with_delay($delay_ms, $id) {
1615
echo "Request $id: starting\n";
1716

17+
// Add delay before making the request
18+
usleep($delay_ms * 1000);
19+
1820
$ch = curl_init();
19-
curl_setopt($ch, CURLOPT_URL, $url);
21+
curl_setopt($ch, CURLOPT_URL, "http://" . PHP_CLI_SERVER_ADDRESS);
2022
curl_setopt($ch, CURLOPT_RETURNTRANSFER, true);
2123
curl_setopt($ch, CURLOPT_TIMEOUT, 5);
2224

@@ -31,11 +33,11 @@ function make_request($url, $id) {
3133

3234
echo "Test start\n";
3335

34-
// Launch multiple concurrent requests
36+
// Launch multiple concurrent requests with different delays
3537
$coroutines = [
36-
spawn(fn() => make_request(get_test_server_url('/'), 1)),
37-
spawn(fn() => make_request(get_test_server_url('/json'), 2)),
38-
spawn(fn() => make_request(get_test_server_url('/slow'), 3)),
38+
spawn(fn() => make_request_with_delay(10, 1)),
39+
spawn(fn() => make_request_with_delay(20, 2)),
40+
spawn(fn() => make_request_with_delay(30, 3)),
3941
];
4042

4143
$results = awaitAll($coroutines);
@@ -44,9 +46,6 @@ foreach ($results as $result) {
4446
echo "Result: $result\n";
4547
}
4648

47-
// Stop server
48-
stop_test_server_process($server_pid);
49-
5049
echo "Test end\n";
5150
?>
5251
--EXPECTF--
@@ -57,7 +56,7 @@ Request 3: starting
5756
Request 1: completed (HTTP 200)
5857
Request 2: completed (HTTP 200)
5958
Request 3: completed (HTTP 200)
60-
Result: Request 1 result: Hello World
61-
Result: Request 2 result: {"message":"Hello JSON","status":"ok"}
62-
Result: Request 3 result: Slow Response
59+
Result: Request 1 result: Hello world
60+
Result: Request 2 result: Hello world
61+
Result: Request 3 result: Hello world
6362
Test end

0 commit comments

Comments
 (0)