* fix errors for basical await tests

Author: EdmondDantes

async.c

@@ -434,6 +434,10 @@ PHP_FUNCTION(Async_awaitAnyOf)
 
 	HashTable * results = zend_new_array(8);
 
+	if (count == 0) {
+		RETURN_ARR(results);
+	}
+
 	async_await_futures(futures,
 		(int)count,
 		false,

async_API.c

@@ -342,6 +342,10 @@ static zend_class_entry* async_get_class_ce(zend_async_class type)
 ////////////////////////////////////////////////////////////////////
 
 #define AWAIT_ALL(await_context) ((await_context)->waiting_count == 0 || (await_context)->waiting_count == (await_context)->total)
+#define ITERATOR_IS_FINISHED(await_context) \
+	((await_context->ignore_errors ? await_context->success_count : await_context->resolved_count) >= await_context->waiting_count || \
+		(await_context->total != 0 && await_context->resolved_count >= await_context->total) \
+	)
 
 static zend_always_inline zend_async_event_t * zval_to_event(const zval * current)
 {
@@ -442,6 +446,7 @@ void async_waiting_callback(
 	if (exception == NULL && await_context->results != NULL && ZEND_ASYNC_EVENT_WILL_ZVAL_RESULT(event) && result != NULL) {
 
 		const zval *success = NULL;
+		await_context->success_count++;
 
 		if (Z_TYPE(await_callback->key) == IS_STRING) {
 			success = zend_hash_update(await_context->results, Z_STR(await_callback->key), result);
@@ -459,7 +464,7 @@ void async_waiting_callback(
 		}
 	}
 
-	if (await_context->resolved_count >= await_context->waiting_count) {
+	if (UNEXPECTED(ITERATOR_IS_FINISHED(await_context))) {
 		ZEND_ASYNC_RESUME(await_callback->callback.coroutine);
 	}
 }
@@ -579,7 +584,7 @@ void iterator_coroutine_finish_callback(
 			exception,
 			false
 		);
-	} else if (iterator->await_context->resolved_count >= iterator->await_context->waiting_count) {
+	} else if (ITERATOR_IS_FINISHED(iterator->await_context)) {
 		// If iteration is finished, resume the waiting coroutine
 		ZEND_ASYNC_RESUME(iterator->waiting_coroutine);
 	}
@@ -669,6 +674,7 @@ void async_await_futures(
 	await_context->total = futures != NULL ? (int) zend_hash_num_elements(futures) : 0;
 	await_context->waiting_count = count > 0 ? count : await_context->total;
 	await_context->resolved_count = 0;
+	await_context->success_count = 0;
 	await_context->ignore_errors = ignore_errors;
 	await_context->concurrency = concurrency;
 	await_context->fill_missing_with_null = fill_missing_with_null;

async_API.h

@@ -27,18 +27,26 @@ typedef void (*async_await_context_dtor_t) (async_await_context_t *context);
 struct _async_await_context_t
 {
 	unsigned int ref_count;
+	/* The total number of futures to wait for */
 	unsigned int total;
+	/* The number of futures that are currently waiting */
 	unsigned int waiting_count;
+	/* The number of futures that have been resolved */
 	unsigned int resolved_count;
+	/* The number of futures that have been successfully resolved */
+	unsigned int success_count;
+	/* If errors should be ignored */
 	bool ignore_errors;
+	/* If we need to fill missing results with null */
+	bool fill_missing_with_null;
+	/* Number of concurrent coroutines that can be executed */
 	unsigned int concurrency;
 	async_await_context_dtor_t dtor;
 	HashTable *futures;
 	// Scope for the new coroutines
 	zend_async_scope_t * scope;
 	HashTable *results;
 	HashTable *errors;
-	bool fill_missing_with_null;
 };
 
 typedef struct

tests/await/009-awaitFirstSuccess_all_errors.phpt

@@ -25,7 +25,7 @@ var_dump($result);
 
 echo "end\n";
 ?>
---EXPECT--
+--EXPECTF--
 start
 array(2) {
   [0]=>

tests/await/012-awaitAllWithErrors_basic.phpt

@@ -29,7 +29,7 @@ var_dump($result);
 
 echo "end\n";
 ?>
---EXPECT--
+--EXPECTF--
 start
 array(2) {
   [0]=>

tests/await/014-awaitAnyOf_basic.phpt

@@ -11,15 +11,15 @@ echo "start\n";
 
 $coroutines = [
     spawn(function() {
-        delay(50);
+        delay(80);
         return "first";
     }),
     spawn(function() {
         delay(20);
         return "second";
     }),
     spawn(function() {
-        delay(30);
+        delay(60);
         return "third";
     }),
     spawn(function() {

tests/await/016-awaitAnyOfWithErrors_basic.phpt

@@ -11,19 +11,19 @@ echo "start\n";
 
 $coroutines = [
     spawn(function() {
-        delay(50);
+        delay(80);
         return "first";
     }),
     spawn(function() {
         delay(20);
         throw new RuntimeException("test exception");
     }),
     spawn(function() {
-        delay(30);
+        delay(20);
         return "third";
     }),
     spawn(function() {
-        delay(25);
+        delay(35);
         return "fourth";
     }),
 ];
@@ -33,7 +33,7 @@ var_dump($result);
 
 echo "end\n";
 ?>
---EXPECT--
+--EXPECTF--
 start
 array(2) {
   [0]=>