fix: ensure docker compose trigger labels are handled correctly (#1)

Author: Crow-Control

app/package-lock.json

@@ -295,6 +295,91 @@ test('registerTriggers should warn when registration errors occur', async () =>
   );
 });
 
+test('ensureDockercomposeTriggerForContainer should create a trigger with container name only when no compose path', async () => {
+  const triggerId = await registry.ensureDockercomposeTriggerForContainer('my-service');
+  expect(triggerId).toBe('dockercompose.my-service');
+  expect(Object.keys(registry.getState().trigger)).toContain(triggerId);
+});
+
+test('ensureDockercomposeTriggerForContainer should create trigger with parent folder and container name', async () => {
+  const triggerId = await registry.ensureDockercomposeTriggerForContainer('my-service', '/home/user/myapp/docker-compose.yml');
+  expect(triggerId).toBe('dockercompose.myapp-my-service');
+  expect(Object.keys(registry.getState().trigger)).toContain(triggerId);
+});
+
+test('ensureDockercomposeTriggerForContainer should append a number when name conflicts', async () => {
+  const triggerId1 = await registry.ensureDockercomposeTriggerForContainer('my-service');
+  const triggerId2 = await registry.ensureDockercomposeTriggerForContainer('my-service');
+
+  expect(triggerId1).toBe('dockercompose.my-service');
+  expect(triggerId2).toBe('dockercompose.my-service-2');
+});
+
+test('ensureDockercomposeTriggerForContainer should append a number when name conflicts with compose path', async () => {
+  const triggerId1 = await registry.ensureDockercomposeTriggerForContainer('my-service', '/home/user/myapp/docker-compose.yml');
+  const triggerId2 = await registry.ensureDockercomposeTriggerForContainer('my-service', '/home/user/myapp/docker-compose.yml');
+
+  expect(triggerId1).toBe('dockercompose.myapp-my-service');
+  expect(triggerId2).toBe('dockercompose.myapp-my-service-2');
+});
+
+test('ensureDockercomposeTriggerForContainer should handle Windows paths', async () => {
+  const triggerId = await registry.ensureDockercomposeTriggerForContainer('my-service', 'C:\\Users\\user\\myapp\\docker-compose.yml');
+  expect(triggerId).toBe('dockercompose.myapp-my-service');
+  expect(Object.keys(registry.getState().trigger)).toContain(triggerId);
+});
+
+test('ensureDockercomposeTriggerForContainer should handle paths without parent folder', async () => {
+  const triggerId = await registry.ensureDockercomposeTriggerForContainer('my-service', '/docker-compose.yml');
+  // When path has no parent folder (slice(-2, -1)[0] returns undefined for single-segment paths),
+  // falls back to container name only
+  expect(triggerId).toBe('dockercompose.my-service');
+  expect(Object.keys(registry.getState().trigger)).toContain(triggerId);
+});
+
+test('sanitizeComponentName should handle empty string', () => {
+  const result = registry.testable_sanitizeComponentName('');
+  expect(result).toBe('container');
+});
+
+test('sanitizeComponentName should handle strings with only special characters', () => {
+  const result = registry.testable_sanitizeComponentName('@@@###$$$');
+  // Result should be composed only of safe characters for component names
+  expect(result).toMatch(/^[a-z0-9._-]*$/);
+});
+
+test('sanitizeComponentName should lowercase and trim mixed-case names with whitespace', () => {
+  const input = '  My-Component_Name  ';
+  const result = registry.testable_sanitizeComponentName(input);
+
+  // Should be all lowercase
+  expect(result).toBe(result.toLowerCase());
+  // Should not have leading or trailing whitespace
+  expect(result.startsWith(' ')).toBe(false);
+  expect(result.endsWith(' ')).toBe(false);
+  expect(result).toBe('my-component_name');
+});
+
+test('sanitizeComponentName should handle various special characters', () => {
+  const input = 'Comp@#Name!$ With%Chars';
+  const result = registry.testable_sanitizeComponentName(input);
+
+  // Should be lowercase and contain only safe characters
+  expect(result).toBe(result.toLowerCase());
+  expect(result).toMatch(/^[a-z0-9._-]*$/);
+  expect(result).toBe('comp--name---with-chars');
+});
+
+test('sanitizeComponentName should handle unicode and symbols robustly', () => {
+  const input = 'Üñïçødë-µ_Service!';
+  const result = registry.testable_sanitizeComponentName(input);
+
+  // Should be lowercase and contain only safe characters
+  expect(result).toBe(result.toLowerCase());
+  expect(result).toMatch(/^[a-z0-9._-]*$/);
+});
+
+
 test('registerWatchers should register all watchers', async () => {
   watchers = {
     watcher1: {

app/registry/index.test.ts

@@ -68,6 +68,8 @@ const state: RegistryState = {
   agent: {},
 };
 
+const CONTAINER_TRIGGER_DEFAULT_NAME = 'container';
+
 export function getState() {
   return state;
 }
@@ -269,6 +271,67 @@ async function registerTriggers(options: RegistrationOptions = {}) {
   }
 }
 
+function sanitizeComponentName(name: string): string {
+  const nameSanitized = `${name || ''}`
+    .trim()
+    .toLowerCase()
+    .replace(/[^a-z0-9._-]/g, '-');
+  return nameSanitized || CONTAINER_TRIGGER_DEFAULT_NAME;
+}
+
+/**
+ * Ensure a dockercompose trigger exists for a container name.
+ * Name collision strategy: append a number to the trigger name.
+ */
+export async function ensureDockercomposeTriggerForContainer(
+  containerName: string,
+  composeFilePath?: string,
+): Promise<string> {
+  let triggerBaseName: string;
+
+  if (composeFilePath) {
+    // Extract parent folder name from compose file path
+    // slice(-2, -1)[0] gets the second-to-last path segment (the parent folder)
+    // Returns undefined for root-level files, which becomes empty string via || ''
+    const parentFolder = composeFilePath
+      .replace(/\\/g, '/') // normalize Windows paths
+      .split('/')
+      .filter((part) => part.length > 0)
+      .slice(-2, -1)[0] || ''; // Get the parent folder name
+    
+    const sanitizedFolder = sanitizeComponentName(parentFolder);
+    const sanitizedContainer = sanitizeComponentName(containerName);
+    
+    // Only use folder prefix if parent folder exists and is not a default fallback value
+    // (sanitizeComponentName returns 'container' as default when input is empty/invalid)
+    if (sanitizedFolder && sanitizedFolder !== CONTAINER_TRIGGER_DEFAULT_NAME) {
+      triggerBaseName = `${sanitizedFolder}-${sanitizedContainer}`;
+    } else {
+      triggerBaseName = sanitizedContainer;
+    }
+  } else {
+    triggerBaseName = sanitizeComponentName(containerName);
+  }
+
+  let triggerName = triggerBaseName;
+  let conflictIndex = 2;
+
+  while (state.trigger[`dockercompose.${triggerName}`]) {
+    triggerName = `${triggerBaseName}-${conflictIndex}`;
+    conflictIndex += 1;
+  }
+
+  const triggerRegistered = await registerComponent({
+    kind: 'trigger',
+    provider: 'dockercompose',
+    name: triggerName,
+    configuration: {},
+    componentPath: 'triggers/providers',
+  });
+
+  return triggerRegistered.getId();
+}
+
 /**
  * Register registries.
  * @returns {Promise}
@@ -491,6 +554,7 @@ export {
   deregisterWatchers as testable_deregisterWatchers,
   deregisterAuthentications as testable_deregisterAuthentications,
   deregisterAll as testable_deregisterAll,
+  sanitizeComponentName as testable_sanitizeComponentName,
   shutdown as testable_shutdown,
   applyTriggerGroupDefaults as testable_applyTriggerGroupDefaults,
   getKnownProviderSet as testable_getKnownProviderSet,