Ensure dockercompose trigger creation uses existing dd/wud.compose.file labels only (#6)

* Initial plan

* fix docker compose label-based trigger creation

Co-authored-by: Crow-Control <7613738+Crow-Control@users.noreply.github.com>

* test compose project label trigger fallback

Co-authored-by: Crow-Control <7613738+Crow-Control@users.noreply.github.com>

* revert compose metadata trigger fallback

Co-authored-by: Crow-Control <7613738+Crow-Control@users.noreply.github.com>

* fix compose trigger creation for cached labeled containers

Co-authored-by: Crow-Control <7613738+Crow-Control@users.noreply.github.com>

---------

Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
Co-authored-by: Crow-Control <7613738+Crow-Control@users.noreply.github.com>

Author: Copilot

app/watchers/providers/docker/Docker.test.ts

@@ -2337,6 +2337,30 @@ describe('Docker Watcher', () => {
       expect(result).toBe(existingContainer);
     });
 
+    test('should not short-circuit existing container when compose label needs trigger creation', async () => {
+      const container = await setupContainerDetailTest(docker, {
+        container: {
+          Image: 'nginx:1.0.0',
+          Names: ['/existing-compose-container'],
+          Labels: {
+            'dd.compose.file': '/tmp/docker-compose.yml',
+          },
+        },
+      });
+      const existingContainer = { id: container.Id, error: undefined };
+      storeContainer.getContainer.mockReturnValue(existingContainer);
+
+      const result = await docker.addImageDetailsToContainer(container);
+
+      expect(result).not.toBe(existingContainer);
+      expect(registry.ensureDockercomposeTriggerForContainer).toHaveBeenCalledWith(
+        'existing-compose-container',
+        '/tmp/docker-compose.yml',
+        {},
+      );
+      expect(result.triggerInclude).toBe('dockercompose.tmp-existing-compose-container');
+    });
+
     test('should add image details to new container', async () => {
       const container = await setupContainerDetailTest(docker, {
         container: { Image: 'nginx:1.0.0' },

app/watchers/providers/docker/Docker.ts

@@ -2417,10 +2417,17 @@ class Docker extends Watcher {
   async addImageDetailsToContainer(container: any, labelOverrides: ContainerLabelOverrides = {}) {
     const containerId = container.Id;
     const containerLabels = container.Labels || {};
+    const composeFilePath = containerLabels[ddComposeFile] || containerLabels[wudComposeFile];
+    const needsComposeTriggerCreation =
+      !!composeFilePath && !this.composeTriggersByContainer[containerId];
 
     // Is container already in store? just return it :)
     const containerInStore = storeContainer.getContainer(containerId);
-    if (containerInStore !== undefined && containerInStore.error === undefined) {
+    if (
+      containerInStore !== undefined &&
+      containerInStore.error === undefined &&
+      !needsComposeTriggerCreation
+    ) {
       this.ensureLogger();
       this.log.debug(`Container ${containerInStore.id} already in store`);
       return containerInStore;
@@ -2472,7 +2479,6 @@ class Docker extends Watcher {
     }
     const containerName = getContainerName(container);
     let triggerIncludeUpdated = resolvedConfig.triggerInclude;
-    const composeFilePath = containerLabels[ddComposeFile] || containerLabels[wudComposeFile];
     const dockercomposeTriggerConfiguration =
       getDockercomposeTriggerConfigurationFromLabels(containerLabels);
     if (composeFilePath) {