Skip to content

Commit 0ffa03c

Browse files
authored
[Fix] detector's integration tests starting with alphabet 'b' (#3746)
* fix buildkite integration tests * fix bitfinex test * fix bitmex test * fix browserstack detector test
1 parent 350971e commit 0ffa03c

File tree

5 files changed

+15
-1
lines changed

5 files changed

+15
-1
lines changed

pkg/detectors/bitfinex/bitfinex_integration_test.go

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -53,6 +53,10 @@ func TestBitfinex_FromChunk(t *testing.T) {
5353
DetectorType: detectorspb.DetectorType_Bitfinex,
5454
Verified: true,
5555
},
56+
{
57+
DetectorType: detectorspb.DetectorType_Bitfinex,
58+
Verified: false,
59+
},
5660
},
5761
wantErr: false,
5862
},
@@ -69,6 +73,10 @@ func TestBitfinex_FromChunk(t *testing.T) {
6973
DetectorType: detectorspb.DetectorType_Bitfinex,
7074
Verified: false,
7175
},
76+
{
77+
DetectorType: detectorspb.DetectorType_Bitfinex,
78+
Verified: false,
79+
},
7280
},
7381
wantErr: false,
7482
},

pkg/detectors/bitmex/bitmex_integration_test.go

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -97,6 +97,10 @@ func TestBitmex_FromChunk(t *testing.T) {
9797
t.Fatalf("no raw secret present: \n %+v", got[i])
9898
}
9999
got[i].Raw = nil
100+
if len(got[i].RawV2) == 0 {
101+
t.Fatalf("no raw v2 secret present: \n %+v", got[i])
102+
}
103+
got[i].RawV2 = nil
100104
}
101105
if diff := pretty.Compare(got, tt.want); diff != "" {
102106
t.Errorf("Bitmex.FromData() %s diff: (-got +want)\n%s", tt.name, diff)

pkg/detectors/browserstack/browserstack_integration_test.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -116,7 +116,7 @@ func TestBrowserStack_FromChunk(t *testing.T) {
116116
},
117117
{
118118
name: "found, verified but blocked by browserstack",
119-
s: Scanner{client: common.SaneHttpClient()},
119+
s: Scanner{client: common.ConstantResponseHttpClient(403, "blocked")},
120120
args: args{
121121
ctx: context.Background(),
122122
data: []byte(fmt.Sprintf("You can find a BROWSERSTACK_ACCESS_KEY %s within BROWSERSTACK_USERNAME %s", secret, secretUser)),

pkg/detectors/buildkite/v1/buildkite_integration_test.go

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -95,6 +95,7 @@ func TestBuildkite_FromChunk(t *testing.T) {
9595
t.Fatalf("no raw secret present: \n %+v", got[i])
9696
}
9797
got[i].Raw = nil
98+
got[i].ExtraData = nil
9899
}
99100
if diff := pretty.Compare(got, tt.want); diff != "" {
100101
t.Errorf("Buildkite.FromData() %s diff: (-got +want)\n%s", tt.name, diff)

pkg/detectors/buildkite/v2/buildkitev2_integration_test.go

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -95,6 +95,7 @@ func TestBuildkite_FromChunk(t *testing.T) {
9595
t.Fatalf("no raw secret present: \n %+v", got[i])
9696
}
9797
got[i].Raw = nil
98+
got[i].ExtraData = nil
9899
}
99100
if diff := pretty.Compare(got, tt.want); diff != "" {
100101
t.Errorf("Buildkite.FromData() %s diff: (-got +want)\n%s", tt.name, diff)

0 commit comments

Comments
 (0)