Improved Baremetrics detector regex pattern (#4060)

* improved regex pattern

* Added word boundaries

Author: kashifkhan0771

pkg/detectors/baremetrics/baremetrics.go

@@ -22,7 +22,13 @@ var (
 	client = common.SaneHttpClient()
 
 	// Make sure that your group is surrounded in boundary characters such as below to reduce false positives.
-	keyPat = regexp.MustCompile(detectors.PrefixRegex([]string{"baremetrics"}) + `\b([a-zA-Z0-9_]{25})\b`)
+	/*
+		Baremetrics has two type of keys:
+		- Sandbox: starts with `sk_`
+		- Production: starts with `lk_`
+		The length of key is not fixed and can range between 18 to 25 characters.
+	*/
+	keyPat = regexp.MustCompile(detectors.PrefixRegex([]string{"baremetrics"}) + `\b((?:sk|lk)_[a-zA-Z0-9]{18,25})\b`)
 )
 
 // Keywords are used for efficiently pre-filtering chunks.

pkg/detectors/baremetrics/baremetrics_test.go

@@ -12,7 +12,7 @@ import (
 )
 
 var (
-	validPattern   = "FNdRZCc2qoPLrwrLJIBE6vovy"
+	validPattern   = "sk_nGDJWCkPiFAKE5XFTzUUA"
 	complexPattern = `
 	func main() {
 		url := "https://api.example.com/v1/resource"
@@ -24,7 +24,7 @@ var (
 			return
 		}
 		
-		baremetricsToken := "Bearer FN_RZCc2qoPLrwrLJIBE6vovy"
+		baremetricsToken := "Bearer sk_nGDJWCkPiFAKE5XFTzUUA"
 		req.Header.Set("Authorization", baremetricsToken)
 
 		// Perform the request
@@ -40,7 +40,7 @@ var (
 		}
 	}
 	`
-	invalidPattern = "FNdRZCc-qoPLrwrLJIBE6vovyu"
+	invalidPattern = "sk_nGDJWC_io8Q025XFTzUUA"
 )
 
 func TestBareMetrics_Pattern(t *testing.T) {
@@ -55,12 +55,12 @@ func TestBareMetrics_Pattern(t *testing.T) {
 		{
 			name:  "valid pattern",
 			input: fmt.Sprintf("baremetrics credentials: %s", validPattern),
-			want:  []string{"FNdRZCc2qoPLrwrLJIBE6vovy"},
+			want:  []string{"sk_nGDJWCkPiFAKE5XFTzUUA"},
 		},
 		{
 			name:  "valid pattern - complex",
 			input: complexPattern,
-			want:  []string{"FN_RZCc2qoPLrwrLJIBE6vovy"},
+			want:  []string{"sk_nGDJWCkPiFAKE5XFTzUUA"},
 		},
 		{
 			name:  "invalid pattern",