Skip to content

Commit c24b4d5

Browse files
authored
[Fix] detector's integration tests starting with alphabet 'g' (#3765)
* fix geocodio detector test * fix github detector test * fix githubapp detector test * fix gitlab v2 detector * fix godaddy v1 detector test
1 parent b26aa17 commit c24b4d5

File tree

5 files changed

+11
-0
lines changed

5 files changed

+11
-0
lines changed

pkg/detectors/geocodio/geocodio_integration_test.go

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -96,6 +96,10 @@ func TestGeocodio_FromChunk(t *testing.T) {
9696
t.Fatalf("no raw secret present: \n %+v", got[i])
9797
}
9898
got[i].Raw = nil
99+
if len(got[i].RawV2) == 0 {
100+
t.Fatalf("no raw v2 secret present: \n %+v", got[i])
101+
}
102+
got[i].RawV2 = nil
99103
}
100104
if diff := pretty.Compare(got, tt.want); diff != "" {
101105
t.Errorf("Geocodio.FromData() %s diff: (-got +want)\n%s", tt.name, diff)

pkg/detectors/github/v2/github_integration_test.go

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -205,6 +205,8 @@ func TestGitHub_FromChunk(t *testing.T) {
205205
for _, tt := range tests {
206206
t.Run(tt.name, func(t *testing.T) {
207207
s := Scanner{}
208+
s.UseCloudEndpoint(true)
209+
s.SetCloudEndpoint(s.CloudEndpoint())
208210
got, err := s.FromData(tt.args.ctx, tt.args.verify, tt.args.data)
209211
if (err != nil) != tt.wantErr {
210212
t.Errorf("GitHub.FromData() error = %v, wantErr %v", err, tt.wantErr)
@@ -215,6 +217,7 @@ func TestGitHub_FromChunk(t *testing.T) {
215217
t.Fatal("no raw secret present")
216218
}
217219
got[i].Raw = nil
220+
got[i].AnalysisInfo = nil
218221
}
219222
if diff := pretty.Compare(got, tt.want); diff != "" {
220223
t.Errorf("GitHub.FromData() %s diff: (-got +want)\n%s", tt.name, diff)

pkg/detectors/githubapp/githubapp_integration_test.go

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -101,6 +101,7 @@ func TestGitHubApp_FromChunk(t *testing.T) {
101101
t.Fatalf("no raw secret present: \n %+v", got[i])
102102
}
103103
got[i].Raw = nil
104+
got[i].ExtraData = nil
104105
}
105106
if diff := pretty.Compare(got, tt.want); diff != "" {
106107
t.Errorf("GitHubApp.FromData() %s diff: (-got +want)\n%s", tt.name, diff)

pkg/detectors/gitlab/v2/gitlab_integration_test.go

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -264,6 +264,8 @@ func TestGitlabV2_FromChunk(t *testing.T) {
264264
}
265265
for _, tt := range tests {
266266
t.Run(tt.name, func(t *testing.T) {
267+
tt.s.UseCloudEndpoint(true)
268+
tt.s.SetCloudEndpoint(tt.s.CloudEndpoint())
267269
got, err := tt.s.FromData(tt.args.ctx, tt.args.verify, tt.args.data)
268270
if (err != nil) != tt.wantErr {
269271
t.Errorf("Gitlab.FromData() error = %v, wantErr %v", err, tt.wantErr)

pkg/detectors/godaddy/v1/godaddy_integration_test.go

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -95,6 +95,7 @@ func TestGoDaddy_FromChunk(t *testing.T) {
9595
t.Fatalf("no raw secret present: \n %+v", got[i])
9696
}
9797
got[i].Raw = nil
98+
got[i].ExtraData = nil
9899
}
99100
if diff := pretty.Compare(got, tt.want); diff != "" {
100101
t.Errorf("GoDaddy.FromData() %s diff: (-got +want)\n%s", tt.name, diff)

0 commit comments

Comments
 (0)