Skip to content

Commit 2b6fc4f

Browse files
Embolden unable to get quarantine status (#972)
We've had customers skip past the log noting that we couldn't get quarantine status and log errors about not understanding why the tests were not quarantined. Emboldening that text as a quick modifier. Before: <img width="994" height="274" alt="Screenshot from 2026-01-07 10-03-01" src="https://github.com/user-attachments/assets/231f9a40-39aa-4b2e-a118-ce500d033afb" /> After: <img width="1035" height="278" alt="Screenshot from 2026-01-07 10-21-20" src="https://github.com/user-attachments/assets/9525d42b-4e48-4c14-90b3-4829550601af" />
1 parent e041f5c commit 2b6fc4f

File tree

1 file changed

+8
-6
lines changed

1 file changed

+8
-6
lines changed

cli/src/upload_command.rs

Lines changed: 8 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -5,25 +5,25 @@ use std::sync::mpsc::Sender;
55

66
use api::client::ApiClient;
77
use api::{client::get_api_host, urls::url_for_test_case};
8-
use bundle::{unzip_tarball, BundleMeta, BundlerUtil, Test};
8+
use bundle::{BundleMeta, BundlerUtil, Test, unzip_tarball};
99
use clap::{ArgAction, Args};
1010
use constants::EXIT_SUCCESS;
1111
use context::bazel_bep::common::BepParseResult;
1212
use display::{end_output::EndOutput, message::DisplayMessage};
1313
use pluralizer::pluralize;
1414
use superconsole::{
15-
style::{style, Attribute, Color, Stylize},
1615
Line, Lines, Span,
16+
style::{Attribute, Color, Stylize, style},
1717
};
1818
use tempfile::TempDir;
1919

2020
use crate::context_quarantine::QuarantineContext;
2121
use crate::validate_command::JunitReportValidations;
2222
use crate::{
2323
context::{
24-
gather_debug_props, gather_exit_code_and_quarantined_tests_context,
24+
PreTestContext, gather_debug_props, gather_exit_code_and_quarantined_tests_context,
2525
gather_initial_test_context, gather_post_test_context, gather_upload_id_context,
26-
generate_internal_file, generate_internal_file_from_bep, PreTestContext,
26+
generate_internal_file, generate_internal_file_from_bep,
2727
},
2828
error_report::ErrorReport,
2929
report_limiting::ValidationReport,
@@ -629,7 +629,7 @@ impl EndOutput for UploadRunResult {
629629
))?]));
630630
if self.quarantine_context.fetch_status.is_failure() {
631631
output.push(Line::from_iter([Span::new_styled(
632-
style(" We were unable to determine the quarantine status for tests. Any failing tests will be reported as failures".to_string()).attribute(Attribute::Dim),
632+
style(" We were unable to determine the quarantine status for tests. Any failing tests will be reported as failures".to_string()).with(Color::Yellow).attribute(Attribute::Bold),
633633
)?]));
634634
}
635635
output.push(Line::default());
@@ -840,7 +840,9 @@ impl EndOutput for UploadRunResult {
840840
} else if failures.is_empty() && self.quarantine_context.exit_code != EXIT_SUCCESS {
841841
// no test failures found but exit code not 0
842842
output.push(Line::from_iter([
843-
Span::new_unstyled("⚠️ No test failures found, but non zero exit code provided: ")?,
843+
Span::new_unstyled(
844+
"⚠️ No test failures found, but non zero exit code provided: ",
845+
)?,
844846
Span::new_styled(
845847
style(format!("{}", self.quarantine_context.exit_code))
846848
.attribute(Attribute::Bold),

0 commit comments

Comments
 (0)