Skip to content

Commit cd7e87f

Browse files
authored
Upload output - don't truncate test names (#704)
We had a customer who was unable to see their test names. Let's drop truncation for now and put it back in if anyone really needs it.
1 parent a75dd9a commit cd7e87f

File tree

3 files changed

+1
-15
lines changed

3 files changed

+1
-15
lines changed

Cargo.lock

Lines changed: 0 additions & 11 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

cli/Cargo.toml

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -58,7 +58,6 @@ url = "2.5.4"
5858
prost = "0.12.6"
5959
superconsole = "0.2.0"
6060
console = "0.15.11"
61-
unicode-ellipsis = "0.3.0"
6261
pluralizer = "0.5.0"
6362

6463
[dev-dependencies]

cli/src/upload_command.rs

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,6 @@ use superconsole::{
1515
style::{style, Attribute, Color, Stylize},
1616
Line, Lines, Span,
1717
};
18-
use unicode_ellipsis::truncate_str_leading;
1918

2019
use crate::context_quarantine::QuarantineContext;
2120
use crate::validate_command::JunitReportValidations;
@@ -481,15 +480,14 @@ impl EndOutput for UploadRunResult {
481480
if test.parent_name.is_empty() { "" } else { "/" },
482481
test.name
483482
);
484-
let truncated = truncate_str_leading(&output_name, 60);
485483
let link = url_for_test_case(
486484
&get_api_host(),
487485
&self.quarantine_context.org_url_slug,
488486
&self.quarantine_context.repo,
489487
test,
490488
)?;
491489
output.push(Line::from_iter([Span::new_styled(
492-
style(truncated.to_string()).attribute(Attribute::Italic),
490+
style(output_name.to_string()).attribute(Attribute::Italic),
493491
)?]));
494492
let mut link_output = Line::from_iter([
495493
Span::new_unstyled("⤷ ")?,

0 commit comments

Comments
 (0)