From 09a5f75f0db1ef25f8e2e6e2228f4c8c4b5234b9 Mon Sep 17 00:00:00 2001 From: Christian Millar Date: Wed, 7 Jan 2026 18:04:42 +0000 Subject: [PATCH 1/2] Embolden unable to get quarantine status We've had customers skip past the log noting that we couldn't get quarantine status and log errors about not understanding why the tests were not quarantined. Emboldening that text as a quick modifier. --- cli/src/upload_command.rs | 14 ++++++++------ 1 file changed, 8 insertions(+), 6 deletions(-) diff --git a/cli/src/upload_command.rs b/cli/src/upload_command.rs index d3702c8b..e082e96b 100644 --- a/cli/src/upload_command.rs +++ b/cli/src/upload_command.rs @@ -5,15 +5,15 @@ use std::sync::mpsc::Sender; use api::client::ApiClient; use api::{client::get_api_host, urls::url_for_test_case}; -use bundle::{unzip_tarball, BundleMeta, BundlerUtil, Test}; +use bundle::{BundleMeta, BundlerUtil, Test, unzip_tarball}; use clap::{ArgAction, Args}; use constants::EXIT_SUCCESS; use context::bazel_bep::common::BepParseResult; use display::{end_output::EndOutput, message::DisplayMessage}; use pluralizer::pluralize; use superconsole::{ - style::{style, Attribute, Color, Stylize}, Line, Lines, Span, + style::{Attribute, Color, Stylize, style}, }; use tempfile::TempDir; @@ -21,9 +21,9 @@ use crate::context_quarantine::QuarantineContext; use crate::validate_command::JunitReportValidations; use crate::{ context::{ - gather_debug_props, gather_exit_code_and_quarantined_tests_context, + PreTestContext, gather_debug_props, gather_exit_code_and_quarantined_tests_context, gather_initial_test_context, gather_post_test_context, gather_upload_id_context, - generate_internal_file, generate_internal_file_from_bep, PreTestContext, + generate_internal_file, generate_internal_file_from_bep, }, error_report::ErrorReport, report_limiting::ValidationReport, @@ -629,7 +629,7 @@ impl EndOutput for UploadRunResult { ))?])); if self.quarantine_context.fetch_status.is_failure() { output.push(Line::from_iter([Span::new_styled( - style(" We were unable to determine the quarantine status for tests. Any failing tests will be reported as failures".to_string()).attribute(Attribute::Dim), + style(" We were unable to determine the quarantine status for tests. Any failing tests will be reported as failures".to_string()).attribute(Attribute::Bold), )?])); } output.push(Line::default()); @@ -840,7 +840,9 @@ impl EndOutput for UploadRunResult { } else if failures.is_empty() && self.quarantine_context.exit_code != EXIT_SUCCESS { // no test failures found but exit code not 0 output.push(Line::from_iter([ - Span::new_unstyled("⚠️ No test failures found, but non zero exit code provided: ")?, + Span::new_unstyled( + "⚠️ No test failures found, but non zero exit code provided: ", + )?, Span::new_styled( style(format!("{}", self.quarantine_context.exit_code)) .attribute(Attribute::Bold), From 9f42b614db4483e730103fe4235dff419a808b13 Mon Sep 17 00:00:00 2001 From: Christian Millar Date: Wed, 7 Jan 2026 18:22:37 +0000 Subject: [PATCH 2/2] colour --- cli/src/upload_command.rs | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/cli/src/upload_command.rs b/cli/src/upload_command.rs index e082e96b..e4bdeefc 100644 --- a/cli/src/upload_command.rs +++ b/cli/src/upload_command.rs @@ -629,7 +629,7 @@ impl EndOutput for UploadRunResult { ))?])); if self.quarantine_context.fetch_status.is_failure() { output.push(Line::from_iter([Span::new_styled( - style(" We were unable to determine the quarantine status for tests. Any failing tests will be reported as failures".to_string()).attribute(Attribute::Bold), + style(" We were unable to determine the quarantine status for tests. Any failing tests will be reported as failures".to_string()).with(Color::Yellow).attribute(Attribute::Bold), )?])); } output.push(Line::default());