cleanup env tests #983
Open
cleanup env tests #983
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mmatheson
requested review from
TylerJang27,
acatxnamedvirtue,
cmillar-trunk,
max-trunk and
mb1206
as code owners
|
Merging to
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## matt/circleci_env_parsing #983 +/- ##
==========================================================
Coverage 81.02% 81.02%
==========================================================
Files 66 66
Lines 14152 14152
==========================================================
Hits 11466 11466
Misses 2686 2686 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
dfrankland
approved these changes
Jan 13, 2026
Comment on lines
1
to
6
| use context::env::{ | ||
| self, EnvVars, | ||
| parser::{BranchClass, CIInfo, CIPlatform, EnvParser}, | ||
| validator::{EnvValidationIssue, EnvValidationIssueSubOptimal, EnvValidationLevel}, | ||
| }; | ||
|
|
Comment on lines
+7
to
+22
| #[path = "env/bitbucket.rs"] | ||
| mod bitbucket; | ||
| #[path = "env/buildkite.rs"] | ||
| mod buildkite; | ||
| #[path = "env/circleci.rs"] | ||
| mod circleci; | ||
| #[path = "env/custom.rs"] | ||
| mod custom; | ||
| #[path = "env/drone.rs"] | ||
| mod drone; | ||
| #[path = "env/github.rs"] | ||
| mod github; | ||
| #[path = "env/gitlab.rs"] | ||
| mod gitlab; | ||
| #[path = "env/semaphore.rs"] | ||
| mod semaphore; |
Member
There was a problem hiding this comment.
IMO using path is sort of a anti-pattern (since it makes it harder to reason about module hierarchy. Instead of this, I'd just prefix each of these files with env_ and keep them at the top level.
Member
Author
There was a problem hiding this comment.
Ah ok - still new to rust, I just found something that "worked" - ty
acatxnamedvirtue
approved these changes
Jan 14, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Split env.rs test file on parser boundaries, import them all in the env.rs file.