fix: resolve HTTP 404 and COINCAP_API_KEY not applied when connecting via query params (#140)

* fix: resolve 404 and missing API key when connecting via query params

Route matching used req.url (which includes the query string), so
/mcp?coincapApiKey=xxx never matched the literal '/mcp' check, causing
a 404. Also, handleMcp always read COINCAP_API_KEY from the environment
instead of the query parameter Smithery passes per-session.

Fix: parse req.url with new URL() and route on pathname; extract
coincapApiKey from URLSearchParams and fall back to env var.

Closes #138

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

* fix: rename config key to COINCAP_API_KEY to match query param convention

Aligns the configSchema property name, Smithery YAML, and HTTP query
parameter parsing to use COINCAP_API_KEY instead of coincapApiKey,
matching the environment variable name and the expected connection URL
format: /mcp?COINCAP_API_KEY={key}

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

* docs: update README and CLAUDE.md for correct build paths and HTTP query param

- Fix build output path (.smithery/ → dist/) in both files
- Remove nonexistent build:stdio script reference
- Document COINCAP_API_KEY query parameter for HTTP connections
- Add get-top-assets tool to both docs

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

---------

Co-authored-by: Claude Sonnet 4.6 <noreply@anthropic.com>

Author: truss44

CLAUDE.md

@@ -9,12 +9,11 @@ This file provides guidance to Claude Code (claude.ai/code) when working with co
 npm run dev
 
 # Build
-npm run build          # HTTP bundle → .smithery/index.cjs
-npm run build:stdio    # STDIO bundle → dist/
+npm run build          # Compile TypeScript → dist/
 
 # Run
-npm run start:http     # Start HTTP server
-npm run start:stdio    # Start STDIO server
+npm run start:http     # Start HTTP server (dist/http.js)
+npm run start:stdio    # Start STDIO server (dist/index.js)
 
 # Test
 npm test               # Run all tests
@@ -36,7 +35,7 @@ NODE_OPTIONS='--experimental-vm-modules --no-warnings' npx jest src/services/__t
 
 This is an MCP (Model Context Protocol) server for cryptocurrency data. It supports two transports:
 - **STDIO**: built to `dist/` via `tsc`, entry point `dist/index.js`
-- **Streamable HTTP**: built to `.smithery/index.cjs` via Smithery CLI
+- **Streamable HTTP**: built to `dist/` via `tsc`, entry point `dist/http.js`. API key is passed as a query parameter: `/mcp?COINCAP_API_KEY={key}`
 
 ### Request flow
 
@@ -55,13 +54,14 @@ MCP client → transport (stdio or HTTP) → src/index.ts (createServer)
 - **`src/services/formatters.ts`** — pure formatting functions for tool output text.
 - **`src/types/index.ts`** — shared TypeScript interfaces for CoinCap API responses.
 
-### Three registered MCP tools
+### Four registered MCP tools
 
 | Tool | Handler | API endpoint |
 |------|---------|--------------|
 | `get-crypto-price` | `handleGetPrice` | `/assets` |
 | `get-market-analysis` | `handleGetMarketAnalysis` | `/assets/{id}/markets` |
 | `get-historical-analysis` | `handleGetHistoricalAnalysis` | `/assets/{id}/history` |
+| `get-top-assets` | `handleGetTopAssets` | `/assets` |
 
 ### Releases & commits
 

README.md

@@ -64,7 +64,7 @@ npm run dev
 - Build and run the HTTP server:
 
 ```bash
-# Build the HTTP bundle (outputs to .smithery/)
+# Build (outputs to dist/)
 npm run build
 
 # Start the HTTP server
@@ -74,21 +74,33 @@ npm run start:http
 - Build and run the STDIO server:
 
 ```bash
-# Build the STDIO bundle (outputs to dist/)
-npm run build:stdio
+# Build (outputs to dist/)
+npm run build
 
 # Start the STDIO server
 npm run start:stdio
 ```
 
-The dev/build commands will print the server address to the console. Use that URL in clients that support MCP over HTTP (for example, Smithery). You must provide an API key via `COINCAP_API_KEY` (see below).
+The server listens on port 3000 by default (override with `PORT`). For clients that connect over HTTP (e.g. Smithery, Claude.ai), pass your API key as a query parameter:
+
+```
+http://localhost:3000/mcp?COINCAP_API_KEY=YOUR_API_KEY_HERE
+```
+
+For remote deployments:
+
+```
+https://your-server-host/mcp?COINCAP_API_KEY=YOUR_API_KEY_HERE
+```
 
 ## Required: CoinCap API Key
 
 This server uses the CoinCap v3 API, which requires an API key. A **free tier** is available.
 
 1. Sign up and get your API key at [pro.coincap.io/dashboard](https://pro.coincap.io/dashboard)
-2. Add the key to your MCP client configuration via the `COINCAP_API_KEY` environment variable (see Usage examples above)
+2. Add the key to your MCP client configuration:
+   - **STDIO**: via the `COINCAP_API_KEY` environment variable (see Usage examples above)
+   - **HTTP**: via the `COINCAP_API_KEY` query parameter in the connection URL (e.g. `/mcp?COINCAP_API_KEY=your_key`)
 
 Without a valid API key, all tools will return an error with instructions on how to obtain one.
 
@@ -161,6 +173,14 @@ Analyzes historical price data with:
 - Volatility metrics
 - High/low price ranges
 
+#### get-top-assets
+
+Lists top cryptocurrencies ranked by market cap, including:
+- Current price in USD
+- 24-hour price change
+- Market cap and rank
+- Configurable result count (1–50, default 10)
+
 ## Sample Prompts
 
 - "What's the current price of Bitcoin?"

smithery.yaml

@@ -11,8 +11,8 @@ startCommand:
   configSchema:
     type: object
     properties:
-      coincapApiKey:
+      COINCAP_API_KEY:
         type: string
         description: "API key for CoinCap v3 API (required). Free tier available at https://pro.coincap.io/dashboard"
     required:
-      - coincapApiKey
+      - COINCAP_API_KEY

src/http.ts

@@ -8,9 +8,9 @@ import { SERVER_CONFIG } from './config/index.js';
 const PORT = parseInt(process.env.PORT ?? '3000', 10);
 
 async function handleMcp(req: http.IncomingMessage, res: http.ServerResponse, searchParams: URLSearchParams) {
-  const coincapApiKey = searchParams.get('coincapApiKey') ?? process.env.COINCAP_API_KEY;
+  const coincapApiKey = searchParams.get('COINCAP_API_KEY') ?? process.env.COINCAP_API_KEY;
   const transport = new StreamableHTTPServerTransport({ sessionIdGenerator: undefined });
-  const server = createServer({ config: { coincapApiKey } });
+  const server = createServer({ config: { COINCAP_API_KEY: coincapApiKey } });
   await server.connect(transport);
 
   if (req.method === 'POST') {

src/index.ts

@@ -20,7 +20,7 @@ import {
 } from './tools/index.js';
 
 export const configSchema = z.object({
-  coincapApiKey: z
+  COINCAP_API_KEY: z
     .string()
     .optional()
     .describe("API key for CoinCap v3 API (required). Free tier available at https://pro.coincap.io/dashboard"),
@@ -31,8 +31,8 @@ export function createServer({
 }: {
   config: z.infer<typeof configSchema>;
 }) {
-  if (config?.coincapApiKey && !process.env.COINCAP_API_KEY) {
-    process.env.COINCAP_API_KEY = config.coincapApiKey;
+  if (config?.COINCAP_API_KEY && !process.env.COINCAP_API_KEY) {
+    process.env.COINCAP_API_KEY = config.COINCAP_API_KEY;
   }
 
   const server = new McpServer({
@@ -165,13 +165,13 @@ export default createServer;
 
 export function createSandboxServer() {
   return createServer({
-    config: { coincapApiKey: undefined },
+    config: { COINCAP_API_KEY: undefined },
   });
 }
 
 async function main() {
   const server = createServer({
-    config: { coincapApiKey: process.env.COINCAP_API_KEY },
+    config: { COINCAP_API_KEY: process.env.COINCAP_API_KEY },
   });
   const transport = new StdioServerTransport();
   await server.connect(transport);