Open
Conversation
… the body. This can produce issues when sending signed requests.
DeimonDB
approved these changes
Oct 18, 2022
Contributor
DeimonDB
left a comment
There was a problem hiding this comment.
LGTM. Make sure tests still pass
tw-covain
approved these changes
Dec 14, 2022
Contributor
tw-covain
left a comment
There was a problem hiding this comment.
Dangerous change. Once upgrading go-libs in any repository, verify no tests are failing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
json.NewEncoder adds "\n" at the end of encoded data https://github.com/golang/go/blob/26b48442569102226baba1d9b4a83aaee3d06611/src/encoding/json/stream.go#L196
This can cause potential issues when requests should be signed.
Consider this code,
the server will not get valid signature because json.Marshall will return
{"payload": "data"}but request body will be{"payload": "data"}\n