bitcoin transactin: bad-txns-inputs-missingorspent

[vccomnet]

Hello all,

I use wallet-core to build bitcoin transactions, I meet following problems:

1. Decode the signed transaction with decoderwtransaction and find that the txid of utxo is different from the input.

2. Broadcast transaction, return error bad txns inputs missingorspent. I think other netizens also reported this error.

The following is my test code and operation log. Please help to see what the problem is?
thank you.

//test code:

void TOKEN_SendBTC()
{
// Setup input
TW::Bitcoin::SigningInput input;
input.hashType = TW::Bitcoin::hashTypeForCoin(TWCoinTypeBitcoin);
input.amount = 100'000'000;
input.byteFee = 1;
input.toAddress = "bcrt1q0d8qtm0wuf2caggfldylgspzsu45lr3ja6nnsa";
input.changeAddress = "bcrt1qscknkrlq52t99u5phraz8drkladwehjrq8sdt8";
input.coinType = TWCoinTypeBitcoin;

auto utxoKey0 = TW::PrivateKey(TW::parse_hex("d9b5b52d313e18f143e874ef5bde5e7d90f48653f1eb3319d47a5e97f89b1b04"));
auto pubKey0 = utxoKey0.getPublicKey(TWPublicKeyTypeSECP256k1);
auto utxoPubkeyHash0 = TW::Hash::ripemd(TW::Hash::sha256(pubKey0.bytes));
input.privateKeys.push_back(utxoKey0); 
auto utxo0Script = TW::Bitcoin::Script::buildPayToPublicKeyHash(utxoPubkeyHash0);
TW::Data scriptHash0;
utxo0Script.matchPayToPublicKeyHash(scriptHash0);

TW::Bitcoin::UTXO utxo0;
utxo0.script = utxo0Script;
utxo0.amount = 5000'000'000;
auto hash0 = TW::parse_hex("d5ea6e3d864908f12da3bc161939b9e3d263a3efcd62a11d2f60734305bda6cd");
utxo0.outPoint = TW::Bitcoin::OutPoint(hash0, 0, UINT32_MAX);
input.utxos.push_back(utxo0);

// Sign
auto result = TW::Bitcoin::TransactionSigner<TW::Bitcoin::Transaction, TW::Bitcoin::TransactionBuilder>::sign(input);
auto signedTx = result.payload();

TW::Data serialized;
signedTx.encode(serialized);

FILE* file = fopen("D:\\1.txt", "a");
fprintf(file, "BTC tx = %s\n", TW::hex(serialized).c_str());
fclose(file);

}

//raw transaction
BTC tx = 0100000001d5ea6e3d864908f12da3bc161939b9e3d263a3efcd62a11d2f60734305bda6cd000000006a4730440220236db911a787a7712d0d6c082ff0a5ae79184b8f9cf886185e7e8a120cc1876402200fbc30736276d800692bacfed5a70d3aca7519fb0b2971b3e42d4d7f05524ad9012102492220e489c7438cfdbb96b6082021ab59f0209314df83068ae7a2497beb692cffffffff0200e1f505000000001600147b4e05edeee2558ea109fb49f44022872b4f8e322410102401000000160014862d3b0fe0a29652f281b8fa23b476ff5aecde4300000000

./bitcoin-cli -regtest -rpcuser=root -rpcpassword=123456 -rpcport=8332 sendrawtransaction 0100000001d5ea6e3d864908f12da3bc161939b9e3d263a3efcd62a11d2f60734305bda6cd000000006a4730440220236db911a787a7712d0d6c082ff0a5ae79184b8f9cf886185e7e8a120cc1876402200fbc30736276d800692bacfed5a70d3aca7519fb0b2971b3e42d4d7f05524ad9012102492220e489c7438cfdbb96b6082021ab59f0209314df83068ae7a2497beb692cffffffff0200e1f505000000001600147b4e05edeee2558ea109fb49f44022872b4f8e322410102401000000160014862d3b0fe0a29652f281b8fa23b476ff5aecde4300000000

error code: -25
error message:
bad-txns-inputs-missingorspent

[root@localhost BTC]#
[root@localhost BTC]#

[root@localhost BTC]# ./bitcoin-cli -regtest -rpcuser=zhangwenge -rpcpassword=123456 -rpcport=8332 decoderawtransaction 0100000001d5ea6e3d864908f12da3bc161939b9e3d263a3efcd62a11d2f60734305bda6cd000000006a4730440220236db911a787a7712d0d6c082ff0a5ae79184b8f9cf886185e7e8a120cc1876402200fbc30736276d800692bacfed5a70d3aca7519fb0b2971b3e42d4d7f05524ad9012102492220e489c7438cfdbb96b6082021ab59f0209314df83068ae7a2497beb692cffffffff0200e1f505000000001600147b4e05edeee2558ea109fb49f44022872b4f8e322410102401000000160014862d3b0fe0a29652f281b8fa23b476ff5aecde4300000000
{
"txid": "04edf9e98bbf9d6de56a884df8ca0110b8cabf001252cb2291659d3b1781fb95",
"hash": "04edf9e98bbf9d6de56a884df8ca0110b8cabf001252cb2291659d3b1781fb95",
"version": 1,
"size": 219,
"vsize": 219,
"weight": 876,
"locktime": 0,
"vin": [
{
"txid": "cda6bd054373602f1da162cdefa363d2e3b9391916bca32df10849863d6eead5",
"vout": 0,
"scriptSig": {
"asm": "30440220236db911a787a7712d0d6c082ff0a5ae79184b8f9cf886185e7e8a120cc1876402200fbc30736276d800692bacfed5a70d3aca7519fb0b2971b3e42d4d7f05524ad9[ALL] 02492220e489c7438cfdbb96b6082021ab59f0209314df83068ae7a2497beb692c",
"hex": "4730440220236db911a787a7712d0d6c082ff0a5ae79184b8f9cf886185e7e8a120cc1876402200fbc30736276d800692bacfed5a70d3aca7519fb0b2971b3e42d4d7f05524ad9012102492220e489c7438cfdbb96b6082021ab59f0209314df83068ae7a2497beb692c"
},
"sequence": 4294967295
}
],
"vout": [
{
"value": 1.00000000,
"n": 0,
"scriptPubKey": {
"asm": "0 7b4e05edeee2558ea109fb49f44022872b4f8e32",
"hex": "00147b4e05edeee2558ea109fb49f44022872b4f8e32",
"address": "bcrt1q0d8qtm0wuf2caggfldylgspzsu45lr3ja6nnsa",
"type": "witness_v0_keyhash"
}
},
{
"value": 48.99999780,
"n": 1,
"scriptPubKey": {
"asm": "0 862d3b0fe0a29652f281b8fa23b476ff5aecde43",
"hex": "0014862d3b0fe0a29652f281b8fa23b476ff5aecde43",
"address": "bcrt1qscknkrlq52t99u5phraz8drkladwehjrq8sdt8",
"type": "witness_v0_keyhash"
}
}
]
}
[root@localhost BTC]#

[vccomnet]

I found that the signature result in the example in tests and the result of decoderwtransaction are also incorrect. Is there a problem with the code?

SigningInput buildInputP2PKH(bool omitKey = false) {
auto hash0 = parse_hex("fff7f7881a8099afa6940d42d1e7f6362bec38171ea3edf433541db4e4ad969f");
auto hash1 = parse_hex("ef51e1b804cc89d182d279655c3aa89e815b1b309fe287d9b2b55d57b90ec68a");

// Setup input
SigningInput input;
input.hashType = hashTypeForCoin(TWCoinTypeBitcoin);
input.amount = 335'790'000;
input.byteFee = 1;
input.toAddress = "1Bp9U1ogV3A14FMvKbRJms7ctyso4Z4Tcx";
input.changeAddress = "1FQc5LdgGHMHEN9nwkjmz6tWkxhPpxBvBU";
input.coinType = TWCoinTypeBitcoin;

auto utxoKey0 = PrivateKey(parse_hex("bbc27228ddcb9209d7fd6f36b02f7dfa6252af40bb2f1cbc7a557da8027ff866"));
auto pubKey0 = utxoKey0.getPublicKey(TWPublicKeyTypeSECP256k1);
auto utxoPubkeyHash0 = Hash::ripemd(Hash::sha256(pubKey0.bytes));
assert(hex(utxoPubkeyHash0) == "b7cd046b6d522a3d61dbcb5235c0e9cc97265457");
if (!omitKey) {
    input.privateKeys.push_back(utxoKey0);
}

auto utxoKey1 = PrivateKey(parse_hex("619c335025c7f4012e556c2a58b2506e30b8511b53ade95ea316fd8c3286feb9"));
auto pubKey1 = utxoKey1.getPublicKey(TWPublicKeyTypeSECP256k1);
auto utxoPubkeyHash1 = Hash::ripemd(Hash::sha256(pubKey1.bytes));
assert(hex(utxoPubkeyHash1) == "1d0f172a0ecb48aee1be1f2687d2963ae33f71a1");
if (!omitKey) {
    input.privateKeys.push_back(utxoKey1);
}

auto utxo0Script = Script::buildPayToPublicKeyHash(utxoPubkeyHash0);
Data scriptHash;
utxo0Script.matchPayToPublicKeyHash(scriptHash);
assert(hex(scriptHash) == "b7cd046b6d522a3d61dbcb5235c0e9cc97265457");

UTXO utxo0;
utxo0.script = utxo0Script;
utxo0.amount = 625'000'000;
utxo0.outPoint = OutPoint(hash0, 0, UINT32_MAX);
input.utxos.push_back(utxo0);

UTXO utxo1;
utxo1.script = Script(parse_hex("0014" "1d0f172a0ecb48aee1be1f2687d2963ae33f71a1"));
utxo1.amount = 600'000'000;
utxo1.outPoint = OutPoint(hash1, 1, UINT32_MAX);
input.utxos.push_back(utxo1);

return input;

}

TEST(BitcoinSigning, SignP2PKH) {
auto input = buildInputP2PKH();

{
    // test plan (but do not reuse plan result)
    auto plan = TransactionBuilder::plan(input);
    EXPECT_TRUE(verifyPlan(plan, {625'000'000}, 335'790'000, 226));
}

// Sign
auto result = TransactionSigner<Transaction, TransactionBuilder>::sign(input);

ASSERT_TRUE(result) << std::to_string(result.error());
auto signedTx = result.payload();

Data serialized;
signedTx.encode(serialized);
EXPECT_EQ(getEncodedTxSize(signedTx), (EncodedTxSize{228, 225, 226}));
EXPECT_TRUE(validateEstimatedSize(signedTx, -1, 1));
ASSERT_EQ(hex(serialized), // printed using prettyPrintTransaction
    "01000000" // version
    "01" // inputs
        "fff7f7881a8099afa6940d42d1e7f6362bec38171ea3edf433541db4e4ad969f"  "00000000"  "6a"  "47304402202819d70d4bec472113a1392cadc0860a7a1b34ea0869abb4bdce3290c3aba086022023eff75f410ad19cdbe6c6a017362bd554ce5fb906c13534ddc306be117ad30a012103c9f4836b9a4f77fc0d81f7bcb01b7f1b35916864b9476c241ce9fc198bd25432"  "ffffffff"
    "02" // outputs
        "b0bf031400000000"  "19"  "76a914769bdff96a02f9135a1d19b749db6a78fe07dc9088ac"
        "aefd3c1100000000"  "19"  "76a9149e089b6889e032d46e3b915a3392edfd616fb1c488ac"
    "00000000" // nLockTime
);

}
//////////////////////////////////////////////////////////////////////////////////////////////////////////

[root@localhost BTC]# ./bitcoin-cli -regtest -rpcuser=zhangwenge -rpcpassword=123456 -rpcport=8332 decoderawtransaction 0100000001fff7f7881a8099afa6940d42d1e7f6362bec38171ea3edf433541db4e4ad969f000000006a47304402202819d70d4bec472113a1392cadc0860a7a1b34ea0869abb4bdce3290c3aba086022023eff75f410ad19cdbe6c6a017362bd554ce5fb906c13534ddc306be117ad30a012103c9f4836b9a4f77fc0d81f7bcb01b7f1b35916864b9476c241ce9fc198bd25432ffffffff02b0bf0314000000001976a914769bdff96a02f9135a1d19b749db6a78fe07dc9088acaefd3c11000000001976a9149e089b6889e032d46e3b915a3392edfd616fb1c488ac00000000
{
"txid": "430d6205de8d19a1630302bf4dd84be9e3768a6f6beb1db4dd224c66ecfd1bd1",
"hash": "430d6205de8d19a1630302bf4dd84be9e3768a6f6beb1db4dd224c66ecfd1bd1",
"version": 1,
"size": 225,
"vsize": 225,
"weight": 900,
"locktime": 0,
"vin": [
{
"txid": "9f96ade4b41d5433f4eda31e1738ec2b36f6e7d1420d94a6af99801a88f7f7ff",
"vout": 0,
"scriptSig": {
"asm": "304402202819d70d4bec472113a1392cadc0860a7a1b34ea0869abb4bdce3290c3aba086022023eff75f410ad19cdbe6c6a017362bd554ce5fb906c13534ddc306be117ad30a[ALL] 03c9f4836b9a4f77fc0d81f7bcb01b7f1b35916864b9476c241ce9fc198bd25432",
"hex": "47304402202819d70d4bec472113a1392cadc0860a7a1b34ea0869abb4bdce3290c3aba086022023eff75f410ad19cdbe6c6a017362bd554ce5fb906c13534ddc306be117ad30a012103c9f4836b9a4f77fc0d81f7bcb01b7f1b35916864b9476c241ce9fc198bd25432"
},
"sequence": 4294967295
}
],
"vout": [
{
"value": 3.35790000,
"n": 0,
"scriptPubKey": {
"asm": "OP_DUP OP_HASH160 769bdff96a02f9135a1d19b749db6a78fe07dc90 OP_EQUALVERIFY OP_CHECKSIG",
"hex": "76a914769bdff96a02f9135a1d19b749db6a78fe07dc9088ac",
"address": "mrL6m4tfJ4bFqMqY3APgbnKwkyUVwdpijg",
"type": "pubkeyhash"
}
},
{
"value": 2.89209774,
"n": 1,
"scriptPubKey": {
"asm": "OP_DUP OP_HASH160 9e089b6889e032d46e3b915a3392edfd616fb1c4 OP_EQUALVERIFY OP_CHECKSIG",
"hex": "76a9149e089b6889e032d46e3b915a3392edfd616fb1c488ac",
"address": "muvZNPif5JnY1UdQfKi9p26qcxJ6ogMLcj",
"type": "pubkeyhash"
}
}
]
}
[root@localhost BTC]#
[root@localhost BTC]#