Cardano Shelley address derivation returning invalid address

[ghost]

When using wallet.getAddressForCoin(), and the provided examples in CardanoTests.swift, an invalid, 115 character address is returned. This is in contrast to the expected 103 character address.

In addition to this, the newly added Cardano signing methods are not defined.

[hewigovens]

For some reason Cocoapod release failed for version 2.7.7, could you please try SPM build first? Thanks

[ghost]

For some reason Cocoapod release failed for version 2.7.7, could you please try SPM build first? Thanks

Hmm, I am using the SPM build.

[hewigovens]

Try resetting cache and download latest Package.swift or build from release 2.7.7, master points to earlier build

[murphman300]

@hewigovens jumping into this convo as we tried to update the package many ways - clearing cache - re-downloading - re-downloading with version pinning in the SPM downloader.

We're both a bit new with SPM, but we noticed this while pinning the version - with 2.7.7 installed - your Package.swift file has version 2.6.36. We're a bit new to the use of SPM so not sure if this is normal.

Attaching screenshots for context

Also tried this:

And here are the two versions:

[murphman300]

We're also not quite sure what you mean by update the Package.swift file, are you suggesting we build your package outside the project and import the build manually?

[hewigovens]

Will update master today

[optout21]

Could you give an example of an invalid address?

[ghost]

addr1ss35adnty3mzqf02vcnmgj4w8w4nt49008gtm6yq29y32v2gvujk3vffanr538z2y0vanxnlqdqm6r3gtwqvs7zgm6vmcugxe3ka5zdne5uu8t

This is a screenshot from Yoroi wallet:

[optout21]

How did you generate this address? With wallet-core Cardano code (current master branch) this is NOT a valid address:

Value of: AddressV3::isValid("addr1ss35adnty3mzqf02vcnmgj4w8w4nt49008gtm6yq29y32v2gvujk3vffanr538z2y0vanxnlqdqm6r3gtwqvs7zgm6vmcugxe3ka5zdne5uu8t")
  Actual: false

Value of: AddressV3::isValidLegacy("addr1ss35adnty3mzqf02vcnmgj4w8w4nt49008gtm6yq29y32v2gvujk3vffanr538z2y0vanxnlqdqm6r3gtwqvs7zgm6vmcugxe3ka5zdne5uu8t")
  Actual: false

[optout21]

Generated address is shorter (len 103), here is an example:

        const auto coin = TWCoinTypeCardano;
        const HDWallet wallet = HDWallet("oil oil oil oil oil oil oil oil oil oil oil oil", "");
        const auto derivationPath = TW::derivationPath(coin);
        PrivateKey privateKey = wallet.getKey(coin, derivationPath);
        std::string address = TW::deriveAddress(coin, privateKey);
        EXPECT_EQ(address, "addr1qy4zgdysk0yt44jksxtzpyrx23dtacvm7lx8as3tcjuypxc82ec75d5j9rayx0pk842rnhgl80z83ad88fpejl405g6sx53rcw");
        EXPECT_TRUE(AddressV3::isValid(address));

[ghost]

   let coinType = try chain.coinType()
   
   guard let wallet = HDWallet(mnemonic: mnemonic, passphrase: "") else {
     throw "error message"
   }
   
   let address = wallet.getAddressForCoin(coin: coinType)

The code above works for all other coins except Cardano.

I also tried using the examples in CardanoTests.swift and CoinAddressDerivationTests.swift, which both produce the same invalid address.

Is there another way to generate Cardano addresses that I'm unaware of?

[optout21]

Please retest, fix has been merged #2142