chore: Update security scan (#225)

* Update Trivy scan

* Add bandit scan

* Exclude tests in bandit scan

* Exclude tests in bandit scan

* Remove redundant Bandit install

* Guarantee serif format

* Update Bandit scan

* Update Bandit scan

Author: AmberJBlue

.github/workflows/security.yaml

@@ -1,31 +1,114 @@
-name: Security
+name: Security Scan
+
 on:
   push:
-    branches:
-      - main
+    branches: [main]
   pull_request:
+    branches: [main]
+  workflow_dispatch:
+
 jobs:
-  build:
-    name: Build
-    runs-on: ubuntu-20.04
+  trivy-scan:
+    name: Trivy
+    runs-on: ubuntu-latest
     permissions:
       contents: read
       security-events: write
+      actions: read
+
     steps:
       - name: Checkout code
         uses: actions/checkout@v4
 
-      - name: Trivy scan
+      - name: Set up Python
+        uses: actions/setup-python@v5
+        with:
+          python-version: '3.11'
+
+      - name: Install dependencies
+        run: |
+          python -m pip install --upgrade pip
+          if [ -f pyproject.toml ]; then
+            pip install -e ".[dev]"
+          fi
+
+      - name: Run Trivy vulnerability scan
         uses: aquasecurity/[email protected]
         with:
           scan-type: 'fs'
+          scan-ref: '.'
           format: 'sarif'
           output: 'trivy-results.sarif'
-          severity: 'MEDIUM,HIGH,CRITICAL'
+          severity: 'CRITICAL,HIGH,MEDIUM,LOW'
           exit-code: '0'
-          ignore-unfixed: false
+      - name: Check for critical and high vulnerabilities
+        uses: aquasecurity/[email protected]
+        with:
+          scan-type: 'fs'
+          scan-ref: '.'
+          format: 'table'
+          severity: 'CRITICAL,HIGH'
+          exit-code: '1'
+        continue-on-error: true
 
-      - name: Update Security tab
+      - name: Upload Trivy scan results to Security tab
         uses: github/codeql-action/upload-sarif@v3
+        if: always()
+        with:
+          sarif_file: 'trivy-results.sarif'
+          category: 'trivy-security-scan'
+
+  bandit-scan:
+    name: Bandit
+    runs-on: ubuntu-latest
+    permissions:
+      security-events: write
+      actions: read
+      contents: read
+      checks: write
+
+    steps:
+      - uses: actions/checkout@v4
+
+      - name: Set up Python
+        uses: actions/setup-python@v5
+        with:
+          python-version: "3.11"
+          cache: "pip"
+
+      - name: Create virtual environment
+        run: |
+          python -m pip install --upgrade pip
+          python -m venv .venv
+
+      - name: Install dependencies
+        run: |
+          source .venv/bin/activate
+          pip install -e ".[dev]"
+
+      - name: Install Bandit
+        run: |
+          source .venv/bin/activate
+          pip install bandit[sarif]
+
+      - name: Run Bandit Security Scan
+        uses: PyCQA/bandit-action@v1
+        with:
+          targets: "."
+          exclude: "tests"
+
+      - name: Upload SARIF results to Security tab
+        if: github.ref == 'refs/heads/main'
+        uses: github/codeql-action/upload-sarif@v3
+        with:
+          sarif_file: results.sarif
+          category: bandit-security-scan
+        continue-on-error: true
+
+      - name: Upload SARIF as artifact
+        uses: actions/upload-artifact@v4
         with:
-          sarif_file: 'trivy-results.sarif'
+          name: bandit-sarif-results
+          path: results.sarif
+          retention-days: 30
+        continue-on-error: true

pyproject.toml

@@ -85,4 +85,4 @@ markers = [
 [tool.setuptools.packages.find]
 where = ["src"]
 
-[tool.setuptools_scm]
+[tool.setuptools_scm]