CheckPodsReady lists all namespace pods instead of filtering by deployment selector

[coderabbitai]

Description

The CheckPodsReady function in controllers/utils/deployment.go currently lists all pods in the namespace without filtering by the deployment's label selector. This can lead to incorrect readiness checks, as it will check pods from other deployments in the same namespace.

Context

This issue was identified during code review of PR #607 but is pre-existing code that was moved during standardization efforts. It is outside the scope of that PR and should be addressed separately.

References

• PR: Second round of function standardization #607
• Review comment: Second round of function standardization #607 (comment)
• Reported by: @RobGeada

Expected Behavior

The function should filter pods using deployment.Spec.Selector.MatchLabels to only check pods belonging to the specific deployment.

Current Behavior

The function lists all pods in the namespace regardless of which deployment they belong to.