fix: bug fix for VectorSearchType.SimilarityScoreThreshold (#290)

vikhyat90 · HavenDV · web-flow · commit a07e22cf37a3 · 2024-05-03T21:28:46.000Z
* bug fix for VectorSearchType.SimilarityScoreThreshold

initializing ScoreThreshold value

* Update VectorStoreRetriever.cs

---------

Co-authored-by: Konstantin S &lt;havendv@gmail.com&gt;
diff --git a/src/Core/src/Retrievers/VectorStoreRetriever.cs b/src/Core/src/Retrievers/VectorStoreRetriever.cs
@@ -36,14 +36,13 @@ public VectorStoreRetriever(
         float? scoreThreshold = null)
     {
         SearchType = searchType;
+        ScoreThreshold = scoreThreshold;
 
         if (SearchType == VectorSearchType.SimilarityScoreThreshold && ScoreThreshold == null)
             throw new ArgumentException($"ScoreThreshold required for {SearchType}");
 
         EmbeddingModel = embeddingModel;
         VectorCollection = vectorCollection;
-        SearchType = searchType;
-        ScoreThreshold = scoreThreshold;
     }
 
     /// <inheritdoc/>
@@ -71,4 +70,4 @@ public Task<IReadOnlyCollection<string>> AddDocumentsAsync(IReadOnlyCollection<D
     {
         return VectorCollection.AddDocumentsAsync(EmbeddingModel, documents);
     }
-}
+}

Original file line number	Diff line number	Diff line change
`@@ -36,14 +36,13 @@ public VectorStoreRetriever(`
`36`	`36`	`float? scoreThreshold = null)`
`37`	`37`	`{`
`38`	`38`	`SearchType = searchType;`
	`39`	`+ ScoreThreshold = scoreThreshold;`
`39`	`40`
`40`	`41`	`if (SearchType == VectorSearchType.SimilarityScoreThreshold && ScoreThreshold == null)`
`41`	`42`	`throw new ArgumentException($"ScoreThreshold required for {SearchType}");`
`42`	`43`
`43`	`44`	`EmbeddingModel = embeddingModel;`
`44`	`45`	`VectorCollection = vectorCollection;`
`45`		`- SearchType = searchType;`
`46`		`- ScoreThreshold = scoreThreshold;`
`47`	`46`	`}`
`48`	`47`
`49`	`48`	`/// <inheritdoc/>`
`@@ -71,4 +70,4 @@ public Task<IReadOnlyCollection<string>> AddDocumentsAsync(IReadOnlyCollection<D`
`71`	`70`	`{`
`72`	`71`	`return VectorCollection.AddDocumentsAsync(EmbeddingModel, documents);`
`73`	`72`	`}`
`74`		`-}`
	`73`	`+}`