Sort performance improvements

Author: tryashtar

fNbt/Tags/NbtCompound.cs

@@ -203,16 +203,16 @@ public void Sort(IComparer<NbtTag> sorter, bool recursive)
             {
                 var restore_sort = (NbtCompound)this.Clone();
                 PerformAction(new DescriptionHolder("Sort {0}", this),
-                     () => { DoSort(sorter, true); },
-                     () => { DoUnsortRecursive(restore_sort); }
+                     () => DoSort(sorter, true),
+                     () => DoUnsortRecursive(restore_sort)
                  );
             }
             else
             {
                 var restore_sort = this.Tags.ToList();
                 PerformAction(new DescriptionHolder("Sort {0}", this),
-                     () => { DoSort(sorter, false); },
-                     () => { DoUnsortRoot(restore_sort); }
+                     () => DoSort(sorter, false),
+                     () => DoUnsortRoot(restore_sort)
                  );
             }
         }
@@ -261,7 +261,6 @@ private void DoSort(IComparer<NbtTag> sorter, bool recursive)
             {
                 foreach (var tag in tags)
                 {
-                    tag.RaiseChangedLoop();
                     if (tag is NbtCompound sub)
                         sub.DoSort(sorter, true);
                     else if (tag is NbtList list)
@@ -270,6 +269,7 @@ private void DoSort(IComparer<NbtTag> sorter, bool recursive)
             }
             DoClear();
             DoAddRange(tags);
+            RaiseChanged(this);
         }
 
         private static void SortListChildren(NbtList list, IComparer<NbtTag> sorter)

fNbt/Tags/NbtContainerTag.cs

@@ -27,6 +27,21 @@ public abstract class NbtContainerTag : NbtTag, IList<NbtTag>
         protected abstract void DoAddRange(IEnumerable<NbtTag> items);
         protected abstract void DoClear();
 
+        public IEnumerable<NbtTag> GetAllTags()
+        {
+            foreach (var tag in this)
+            {
+                yield return tag;
+                if (tag is NbtContainerTag container)
+                {
+                    foreach (var sub in container.GetAllTags())
+                    {
+                        yield return sub;
+                    }
+                }
+            }
+        }
+
         public void Add(NbtTag item)
         {
             PerformAction(new DescriptionHolder("Add {0} to {1}", item, this),

fNbt/Tags/NbtTag.cs

@@ -15,12 +15,12 @@ public abstract class NbtTag : ICloneable {
         public abstract NbtTagType TagType { get; }
 
         /// <summary> Event raised when this tag or one of its children is changed. </summary>
-        public event Action<NbtTag> Changed;
+        public event Action<NbtTag> OnChanged;
 
         /// <summary> Event raised when this tag has an undoable action performed on it. </summary>
         public event Action<UndoableAction> ActionPerformed;
 
-        private void RaiseChanged(NbtTag tag) => Changed?.Invoke(tag);
+        protected void RaiseChanged(NbtTag tag) => OnChanged?.Invoke(tag);
         private void RaiseActionPerformed(UndoableAction action) => ActionPerformed?.Invoke(action);
 
         /// <summary> Helper method for signaling changes to parent tags. </summary>
@@ -49,7 +49,7 @@ protected void PerformAction(DescriptionHolder description, Action action, Actio
             RaiseActionPerformed(undoable);
         }
 
-        internal void RaiseChangedLoop()
+        protected void RaiseChangedLoop()
         {
             var tag = this;
             while (tag != null)