fix: streamline elevation process in Windows script for clarity

- Removed the option for automatic elevation, simplifying the user experience.
- Updated messaging to clearly instruct users to run the script as Administrator.
- Enhanced error handling by providing a specific exit code when not run with elevated privileges.

Author: Marfuen

apps/portal/src/app/api/download-agent/scripts/windows.ts

@@ -27,45 +27,16 @@ set "HAS_ERROR=0"
 set "ERRORS="
 set "EXIT_CODE=0"
 
-REM Capture elevation flag if passed
-set "ELEVATED_FLAG=%~1"
-
-REM Self-elevate if not running as administrator (check High Mandatory Level)
+REM Require Administrator (check High Mandatory Level) and exit with instructions if not elevated
 whoami /groups | find "S-1-16-12288" >nul 2>&1
-if errorlevel 1 if /I not "%ELEVATED_FLAG%"=="elevated" (
+if errorlevel 1 (
   color 0E
-  echo Administrator permission is required.
-  echo A prompt will appear asking for permission. Please click "Yes".
-  echo If no prompt appears, right-click this file and select "Run as administrator".
+  echo This script must be run as Administrator.
+  echo Please right-click the file and select "Run as administrator".
   echo.
-  echo Choose an option:
-  echo   [Y] Try to auto-elevate (recommended)
-  echo   [N] I will re-run manually as Administrator
-  choice /C YN /N /M "Attempt automatic elevation? (Y/N): "
-  if errorlevel 2 (
-    echo.
-    echo Please close this window and re-run the script by right-clicking it and selecting "Run as administrator".
-    echo Press any key to exit.
-    pause >nul
-    exit /b
-  ) else (
-    echo Elevating... A new window will open and remain open after running.
-    rem Try PowerShell elevation first (keeps admin window open with /k)
-    powershell -NoProfile -ExecutionPolicy Bypass -Command "Start-Process -Verb RunAs -FilePath '%comspec%' -ArgumentList '/k','\"%~f0 elevated\"' -WorkingDirectory '%~dp0'" 2>nul
-    rem Fallback to VBScript if PowerShell attempt failed or is blocked
-    if not exist "%TEMP%\elevate.tmp" (
-      > "%TEMP%\getadmin.vbs" echo Set UAC = CreateObject^("Shell.Application"^)
-      >> "%TEMP%\getadmin.vbs" echo UAC.ShellExecute "%~f0", "elevated", "", "runas", 1
-      wscript "%TEMP%\getadmin.vbs" >nul 2>&1
-      del "%TEMP%\getadmin.vbs" >nul 2>&1
-    )
-    echo.
-    echo This window will now stay open so you can see messages.
-    echo Once the new admin window appears, you may close this one after confirming progress.
-    echo Press any key to exit this non-admin window.
-    pause >nul
-    exit /b
-  )
+  echo Press any key to exit, then try again with Administrator privileges.
+  pause
+  exit /b 5
 )
 echo Running with administrator privileges.
 echo Current directory: %cd%