Skip to content

Commit 3a6559e

Browse files
authored
Merge pull request #758 from trycompai/lewis/comp-onboarding-testjam-fixes
[dev] [carhartlewis] lewis/comp-onboarding-testjam-fixes
2 parents 4194173 + 1b600bf commit 3a6559e

File tree

8 files changed

+134
-458
lines changed

8 files changed

+134
-458
lines changed

apps/app/src/app/[locale]/(app)/(dashboard)/[orgId]/vendors/[vendorId]/components/VendorInherentRiskChart.tsx

Lines changed: 4 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@
33
import { RiskMatrixChart } from "@/components/risks/charts/RiskMatrixChart";
44
import { useI18n } from "@/locales/client";
55
import type { Vendor } from "@comp/db/types";
6-
import { VendorInherentRiskSheet } from "./VendorInherentRiskSheet";
6+
import { updateVendorInherentRisk } from "../actions/update-vendor-inherent-risk";
77

88
interface InherentRiskChartProps {
99
vendor: Vendor;
@@ -16,14 +16,11 @@ export function VendorInherentRiskChart({ vendor }: InherentRiskChartProps) {
1616
<RiskMatrixChart
1717
title={t("vendors.risks.inherent_risk")}
1818
description={t("vendors.risks.update_inherent_risk_description")}
19+
riskId={vendor.id}
1920
activeLikelihood={vendor.inherentProbability}
2021
activeImpact={vendor.inherentImpact}
21-
sheetQueryParam="inherent-risk-sheet"
22-
EditSheetComponent={VendorInherentRiskSheet}
23-
editSheetProps={{
24-
vendorId: vendor.id,
25-
initialProbability: vendor.inherentProbability,
26-
initialImpact: vendor.inherentImpact,
22+
saveAction={async ({ id, probability, impact }) => {
23+
return updateVendorInherentRisk({ vendorId: id, inherentProbability: probability, inherentImpact: impact });
2724
}}
2825
/>
2926
);

apps/app/src/app/[locale]/(app)/(dashboard)/[orgId]/vendors/[vendorId]/components/VendorInherentRiskForm.tsx

Lines changed: 0 additions & 171 deletions
This file was deleted.

apps/app/src/app/[locale]/(app)/(dashboard)/[orgId]/vendors/[vendorId]/components/VendorResidualRiskChart.tsx

Lines changed: 4 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@
33
import { RiskMatrixChart } from "@/components/risks/charts/RiskMatrixChart";
44
import { useI18n } from "@/locales/client";
55
import type { Vendor } from "@comp/db/types";
6-
import { VendorResidualRiskSheet } from "./VendorResidualRiskSheet";
6+
import { updateVendorResidualRisk } from "../actions/update-vendor-residual-risk";
77

88
interface ResidualRiskChartProps {
99
vendor: Vendor;
@@ -16,13 +16,11 @@ export function VendorResidualRiskChart({ vendor }: ResidualRiskChartProps) {
1616
<RiskMatrixChart
1717
title={t("vendors.risks.residual_risk")}
1818
description={t("vendors.risks.update_residual_risk_description")}
19+
riskId={vendor.id}
1920
activeLikelihood={vendor.residualProbability}
2021
activeImpact={vendor.residualImpact}
21-
sheetQueryParam="residual-risk-sheet"
22-
EditSheetComponent={VendorResidualRiskSheet}
23-
editSheetProps={{
24-
vendorId: vendor.id,
25-
initialRisk: vendor,
22+
saveAction={async ({ id, probability, impact }) => {
23+
return updateVendorResidualRisk({ vendorId: id, residualProbability: probability, residualImpact: impact });
2624
}}
2725
/>
2826
);

apps/app/src/components/risks/charts/InherentRiskChart.tsx

Lines changed: 4 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -1,9 +1,9 @@
11
"use client";
22

3-
import { InherentRiskSheet } from "@/components/sheets/InherentRiskSheet";
43
import { useI18n } from "@/locales/client";
54
import type { Risk } from "@comp/db/types";
65
import { RiskMatrixChart } from "./RiskMatrixChart";
6+
import { updateInherentRiskAction } from "@/actions/risk/update-inherent-risk-action";
77

88
interface InherentRiskChartProps {
99
risk: Risk;
@@ -16,14 +16,11 @@ export function InherentRiskChart({ risk }: InherentRiskChartProps) {
1616
<RiskMatrixChart
1717
title={t("risk.metrics.inherentRisk")}
1818
description={t("risk.dashboard.inherent_risk_description")}
19+
riskId={risk.id}
1920
activeLikelihood={risk.likelihood}
2021
activeImpact={risk.impact}
21-
sheetQueryParam="inherent-risk-sheet"
22-
EditSheetComponent={InherentRiskSheet}
23-
editSheetProps={{
24-
riskId: risk.id,
25-
initialProbability: risk.likelihood,
26-
initialImpact: risk.impact,
22+
saveAction={async ({ id, probability, impact }) => {
23+
return updateInherentRiskAction({ id, probability, impact });
2724
}}
2825
/>
2926
);

apps/app/src/components/risks/charts/ResidualRiskChart.tsx

Lines changed: 4 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -1,9 +1,9 @@
11
"use client";
22

3-
import { ResidualRiskSheet } from "@/components/sheets/ResidualRiskSheet";
43
import { useI18n } from "@/locales/client";
54
import type { Risk } from "@comp/db/types";
65
import { RiskMatrixChart } from "./RiskMatrixChart";
6+
import { updateResidualRiskEnumAction } from "@/actions/risk/update-residual-risk-enum-action";
77

88
interface ResidualRiskChartProps {
99
risk: Risk;
@@ -16,14 +16,11 @@ export function ResidualRiskChart({ risk }: ResidualRiskChartProps) {
1616
<RiskMatrixChart
1717
title={t("risk.metrics.residualRisk")}
1818
description={t("risk.dashboard.residual_risk_description")}
19+
riskId={risk.id}
1920
activeLikelihood={risk.residualLikelihood}
2021
activeImpact={risk.residualImpact}
21-
sheetQueryParam="residual-risk-sheet"
22-
EditSheetComponent={ResidualRiskSheet}
23-
editSheetProps={{
24-
riskId: risk.id,
25-
initialProbability: risk.residualLikelihood,
26-
initialImpact: risk.residualImpact,
22+
saveAction={async ({ id, probability, impact }) => {
23+
return updateResidualRiskEnumAction({ id, probability, impact });
2724
}}
2825
/>
2926
);

0 commit comments

Comments
 (0)