Mariano/fix 12 (#1899)

* refactor(api): improve handling of required variables in connections and auto-check services

Author: Marfuen

apps/api/src/integration-platform/controllers/connections.controller.ts

@@ -91,6 +91,14 @@ export class ConnectionsController {
       const seenTaskIds = new Set<string>();
       const requiredVariables = new Set<string>();
 
+      // Collect manifest-level required variables
+      for (const variable of m.variables || []) {
+        if (variable.required) {
+          requiredVariables.add(variable.id);
+        }
+      }
+
+      // Collect check-level required variables
       for (const check of m.checks || []) {
         if (check.taskMapping && !seenTaskIds.has(check.taskMapping)) {
           seenTaskIds.add(check.taskMapping);
@@ -100,7 +108,6 @@ export class ConnectionsController {
             mappedTasks.push({ id: check.taskMapping, name: taskInfo.name });
           }
         }
-        // Collect required variables
         if (check.variables) {
           for (const variable of check.variables) {
             if (variable.required) {
@@ -158,8 +165,17 @@ export class ConnectionsController {
     const mappedTasks: Array<{ id: string; name: string }> = [];
     const seenTaskIds = new Set<string>();
 
-    // Collect required variables from all checks
+    // Collect required variables (manifest-level and check-level)
     const requiredVariables = new Set<string>();
+
+    // Manifest-level variables
+    for (const variable of manifest.variables || []) {
+      if (variable.required) {
+        requiredVariables.add(variable.id);
+      }
+    }
+
+    // Check-level variables
     for (const check of manifest.checks || []) {
       if (check.taskMapping && !seenTaskIds.has(check.taskMapping)) {
         seenTaskIds.add(check.taskMapping);
@@ -169,7 +185,6 @@ export class ConnectionsController {
           mappedTasks.push({ id: check.taskMapping, name: taskInfo.name });
         }
       }
-      // Collect required variables
       if (check.variables) {
         for (const variable of check.variables) {
           if (variable.required) {

apps/api/src/integration-platform/services/auto-check-runner.service.ts

@@ -44,8 +44,17 @@ export class AutoCheckRunnerService {
       return { canRun: false, reason: 'No checks defined for this provider' };
     }
 
-    // Collect all required variables from all checks
+    // Collect all required variables (manifest-level and check-level)
     const requiredVariables = new Set<string>();
+
+    // Manifest-level variables
+    for (const variable of manifest.variables || []) {
+      if (variable.required) {
+        requiredVariables.add(variable.id);
+      }
+    }
+
+    // Check-level variables
     for (const check of manifest.checks) {
       if (check.variables) {
         for (const variable of check.variables) {

apps/app/src/app/(app)/[orgId]/cloud-tests/page.tsx

@@ -7,21 +7,35 @@ import { TestsLayout } from './components/TestsLayout';
 
 const CLOUD_PROVIDER_SLUGS = ['aws', 'gcp', 'azure'];
 
-// Get required variables from manifest
+// Get required variables from manifest (both manifest-level and check-level)
 const getRequiredVariables = (providerSlug: string): string[] => {
   const manifest = getManifest(providerSlug);
-  if (!manifest?.checks) return [];
+  if (!manifest) return [];
 
   const requiredVars = new Set<string>();
-  for (const check of manifest.checks) {
-    if (check.variables) {
-      for (const variable of check.variables) {
-        if (variable.required) {
-          requiredVars.add(variable.id);
+
+  // Check manifest-level variables
+  if (manifest.variables) {
+    for (const variable of manifest.variables) {
+      if (variable.required) {
+        requiredVars.add(variable.id);
+      }
+    }
+  }
+
+  // Check check-level variables
+  if (manifest.checks) {
+    for (const check of manifest.checks) {
+      if (check.variables) {
+        for (const variable of check.variables) {
+          if (variable.required) {
+            requiredVars.add(variable.id);
+          }
         }
       }
     }
   }
+
   return Array.from(requiredVars);
 };