fix: correct aws ecs run-task syntax in deploy scripts

- Fix incorrect --subnets and --security-groups parameters
- Use proper --network-configuration with JSON structure
- Add --launch-type FARGATE parameter
- Add ECR image processing delay before deployment
- Apply fixes to both deploy.sh and GitHub Actions workflow

Author: claudfuen

.github/workflows/deploy.yml

@@ -78,11 +78,18 @@ jobs:
           
       - name: Run database migrations
         run: |
+          # Get subnet and security group for migration task
+          PRIVATE_SUBNET=$(aws ec2 describe-subnets --filters "Name=tag:Type,Values=private" --query 'Subnets[0].SubnetId' --output text)
+          CODEBUILD_SG=$(aws ec2 describe-security-groups --filters "Name=tag:Name,Values=pathfinder-codebuild-sg" --query 'SecurityGroups[0].GroupId' --output text)
+          
+          echo "Using subnet: $PRIVATE_SUBNET"
+          echo "Using security group: $CODEBUILD_SG"
+          
           TASK_ARN=$(aws ecs run-task \
             --cluster pathfinder \
             --task-definition pathfinder-migration:latest \
-            --subnets $(aws ec2 describe-subnets --filters "Name=tag:Type,Values=private" --query 'Subnets[0].SubnetId' --output text) \
-            --security-groups $(aws ec2 describe-security-groups --filters "Name=tag:Name,Values=pathfinder-codebuild-sg" --query 'SecurityGroups[0].GroupId' --output text) \
+            --launch-type FARGATE \
+            --network-configuration "awsvpcConfiguration={subnets=[$PRIVATE_SUBNET],securityGroups=[$CODEBUILD_SG],assignPublicIp=ENABLED}" \
             --query 'tasks[0].taskArn' --output text)
           
           echo "Migration task started: $TASK_ARN"
@@ -122,6 +129,10 @@ jobs:
           
       - name: Deploy application
         run: |
+          # Wait for ECR to process the new image
+          echo "Waiting for ECR to process new image..."
+          sleep 30
+          
           # Update ECS service to use new image
           aws ecs update-service \
             --cluster pathfinder \

scripts/deploy.sh

@@ -79,12 +79,15 @@ codebuild_sg=$(aws ec2 describe-security-groups \
     --filters "Name=tag:Name,Values=pathfinder-codebuild-sg" \
     --query 'SecurityGroups[0].GroupId' --output text)
 
-# Run migration task
+echo "Using subnet: $private_subnet"
+echo "Using security group: $codebuild_sg"
+
+# Run migration task with correct syntax
 migration_task_arn=$(aws ecs run-task \
     --cluster "$CLUSTER_NAME" \
     --task-definition pathfinder-migration:latest \
-    --subnets "$private_subnet" \
-    --security-groups "$codebuild_sg" \
+    --launch-type FARGATE \
+    --network-configuration "awsvpcConfiguration={subnets=[$private_subnet],securityGroups=[$codebuild_sg],assignPublicIp=ENABLED}" \
     --query 'tasks[0].taskArn' --output text)
 
 echo "Migration task ARN: $migration_task_arn"
@@ -117,6 +120,10 @@ wait_for_build "$app_build_id" "Application"
 # Step 5: Deploy Application
 echo -e "${YELLOW}🚢 Step 5: Deploying application...${NC}"
 
+# Wait for ECR to process the new image
+echo -e "${YELLOW}⏳ Waiting for ECR to process new image...${NC}"
+sleep 30
+
 # Update ECS service
 aws ecs update-service \
     --cluster "$CLUSTER_NAME" \