clippy

Author: aapoalas

nova_vm/src/engine/bytecode/instructions.rs

@@ -704,17 +704,15 @@ pub(crate) struct Instr<'a> {
 
 impl<'a> Instr<'a> {
     pub(super) fn consume_instruction(instructions: &'a [u8], ip: &mut usize) -> Option<Self> {
-        let Some(kind_at) = instructions.get(*ip) else {
-            return None;
-        };
+        let kind_at = instructions.get(*ip)?;
         let Ok(kind) = Instruction::try_from(*kind_at) else {
             panic_invalid_instruction()
         };
         // SAFETY: we checked above the kind is Ok.
         let ptr = NonNull::from_ref(kind_at).cast::<Instruction>();
 
         let byte_count = match kind.argument_count() {
-            value @ (0 | 1 | 2) => (value * 2) as usize,
+            value @ (0..=2) => (value * 2) as usize,
             _ => panic_invalid_instruction(),
         };
         *ip += byte_count + 1;

tests/expectations.json

@@ -7026,4 +7026,4 @@
   "staging/sm/syntax/yield-as-identifier.js": "FAIL",
   "staging/source-phase-imports/import-source-source-text-module.js": "FAIL",
   "staging/top-level-await/tla-hang-entry.js": "FAIL"
-}
+}

tests/metrics.json

@@ -8,4 +8,4 @@
     "unresolved": 37
   },
   "total": 50733
-}
+}