Mutate heap data

Author: komyg

nova_vm/src/ecmascript/builtins/control_abstraction_objects/promise_objects/promise_abstract_operations/promise_all_record.rs

@@ -13,7 +13,7 @@ use crate::{
         execution::Agent,
         types::Value,
     },
-    engine::context::{Bindable, NoGcScope},
+    engine::context::{Bindable, GcScope, NoGcScope},
     heap::{
         CompactionLists, CreateHeapData, Heap, HeapMarkAndSweep, WorkQueues, indexes::BaseIndex,
     },
@@ -37,6 +37,7 @@ impl<'a> PromiseAllRecordHeapData<'a> {
         value: Value<'a>,
         gc: NoGcScope<'a, '_>,
     ) {
+        eprintln!("Self memory address: {:p}", &self);
         // Update the result array at the specified index by reconstructing it
         let array_slice = self.result_array.as_slice(agent);
         let new_values: Vec<Value> = array_slice
@@ -51,9 +52,15 @@ impl<'a> PromiseAllRecordHeapData<'a> {
             })
             .collect();
 
+        eprintln!("Index: {:#?}", index);
         eprintln!("New values: {:#?}", new_values);
+        eprintln!(
+            "Remaining unresolved promise count: {:#?}",
+            self.remaining_unresolved_promise_count
+        );
 
         self.result_array = Array::from_slice(agent, &new_values, gc);
+        eprintln!("Result array memory address: {:p}", &self.result_array);
 
         self.remaining_unresolved_promise_count -= 1;
         if self.remaining_unresolved_promise_count == 0 {

nova_vm/src/ecmascript/builtins/control_abstraction_objects/promise_objects/promise_abstract_operations/promise_jobs.rs

@@ -292,8 +292,27 @@ impl PromiseReactionJob {
                 let capability = agent[reaction].capability.clone().unwrap().bind(gc.nogc());
                 match agent[reaction].reaction_type {
                     PromiseReactionType::Fulfill => {
-                        let mut promise_all_record = agent.heap.promise_all_records[promise_all];
-                        promise_all_record.on_promise_fufilled(agent, index, argument, gc.nogc());
+                        // Take out the record to drop the vec borrow before we use `agent`/`gc`
+                        let rec = {
+                            let slot = agent
+                                .heap
+                                .promise_all_records
+                                .get_mut(promise_all.get_index())
+                                .expect("PromiseAllRecord out of bounds");
+                            slot.take().expect("PromiseAllRecord slot empty")
+                        };
+
+                        // Bind to current scope and mutate
+                        let mut rec_bound = rec.unbind().bind(gc.nogc());
+                        rec_bound.on_promise_fufilled(agent, index, argument.unbind(), gc.nogc());
+
+                        // Write back with 'static lifetime
+                        agent
+                            .heap
+                            .promise_all_records
+                            .get_mut(promise_all.get_index())
+                            .unwrap()
+                            .replace(rec_bound.unbind());
 
                         (Ok(argument), capability)
                     }