Implement Promise All Settled #872
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
komyg
force-pushed
the
feature/promise.all_settled
branch
from
6271720 to
16237ab
Compare
aapoalas
reviewed
Oct 13, 2025
| pub(crate) realms: Vec<Option<RealmRecord<'static>>>, | ||
| pub(crate) promise_all_records: Vec<PromiseAllRecord<'static>>, | ||
| pub(crate) promise_all_settled_records: Vec<PromiseAllSettledRecord<'static>>, | ||
| pub(crate) promise_group_records: Vec<PromiseGroupRecord<'static>>, |
There was a problem hiding this comment.
issue: The intention behind the "PromiseGroup" is that PromiseAll and PromiseAllSettled would not exist as separate categories / vectors in the heap, but instead they'd both just be "PromiseGroups" of some kind, with the exact kind of the group determined by what the enum variant of the PromiseGroupRecord is.
There was a problem hiding this comment.
Yes, that is my intention.
I left the other records there, so that I could test my changes without a huge change, but I will remove them once the PromiseGroup is fully ready.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.