Skip to content

Commit be8f41b

Browse files
authored
[fix] Update standalone dbconnector service type definition to match … (#232)
1 parent 3e1759d commit be8f41b

File tree

4 files changed

+12
-9
lines changed

4 files changed

+12
-9
lines changed

charts/retool/Chart.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@ apiVersion: v2
22
name: retool
33
description: A Helm chart for Kubernetes
44
type: application
5-
version: 6.4.7
5+
version: 6.4.8
66
maintainers:
77
- name: Retool Engineering
88

charts/retool/templates/deployment_backend.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -101,7 +101,7 @@ spec:
101101
{{- end }}
102102
- name: SERVICE_TYPE
103103
value: {{ join "," $serviceType }}
104-
{{ if and ( include "retool_version_with_java_dbconnector_opt_out" . ) ( not $.Values.dbconnector.java.enabled ) }}
104+
{{ if and ( not $.Values.dbconnector.enabled ) ( and ( include "retool_version_with_java_dbconnector_opt_out" . ) ( not $.Values.dbconnector.java.enabled ) ) }}
105105
- name: DISABLE_JAVA_DBCONNECTOR
106106
value: "true"
107107
{{ end }}

charts/retool/templates/deployment_dbconnector.yaml

Lines changed: 9 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -62,13 +62,16 @@ spec:
6262
{{- toYaml .Values.resources | nindent 10 }}
6363
{{- end }}
6464
env:
65-
{{- if $.Values.dbconnector.java.enabled }}
66-
- name: SERVICE_TYPE
67-
value: DB_CONNECTOR,DB_SSH_CONNECTOR,JAVA_DBCONNECTOR
68-
{{- else }}
69-
- name: SERVICE_TYPE
70-
value: DB_CONNECTOR,DB_SSH_CONNECTOR
65+
{{- $serviceType := list "DB_CONNECTOR" "DB_SSH_CONNECTOR" }}
66+
{{- if and ( not ( include "retool_version_with_java_dbconnector_opt_out" . ) ) ( $.Values.dbconnector.java.enabled ) }}
67+
{{- $serviceType = append $serviceType "JAVA_DBCONNECTOR" }}
7168
{{- end }}
69+
- name: SERVICE_TYPE
70+
value: {{ join "," $serviceType }}
71+
{{ if and ( include "retool_version_with_java_dbconnector_opt_out" . ) ( not $.Values.dbconnector.java.enabled ) }}
72+
- name: DISABLE_JAVA_DBCONNECTOR
73+
value: "true"
74+
{{ end }}
7275
- name: DEPLOYMENT_TEMPLATE_TYPE
7376
value: {{ template "retool.deploymentTemplateType" . }}
7477
- name: DEPLOYMENT_TEMPLATE_VERSION

charts/retool/templates/deployment_workflows.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -95,7 +95,7 @@ spec:
9595
value: {{ $.Values.dbconnector.java.port | quote }}
9696
{{- end }}
9797
{{- end }}
98-
{{ if and ( include "retool_version_with_java_dbconnector_opt_out" . ) ( not $.Values.dbconnector.java.enabled ) }}
98+
{{ if and ( not $.Values.dbconnector.enabled ) ( and ( include "retool_version_with_java_dbconnector_opt_out" . ) ( not $.Values.dbconnector.java.enabled ) ) }}
9999
- name: DISABLE_JAVA_DBCONNECTOR
100100
value: "true"
101101
{{ end }}

0 commit comments

Comments
 (0)