Skip to content

Commit e0cbd93

Browse files
authored
Fixes #220 (#221)
1 parent 0eb520b commit e0cbd93

File tree

5 files changed

+36
-18
lines changed

5 files changed

+36
-18
lines changed

.github/kubeconform.sh

Lines changed: 11 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,9 @@
11
#!/bin/bash
22
set -euo pipefail
33

4-
KUBECONFORM_VERSION="v0.6.1"
4+
KUBECONFORM_VERSION="v0.6.7"
55
OS=$(uname)
6+
: ${KUBERNETES_VERSION:=v1.31.1}
67

78
CHANGED_CHARTS=${CHANGED_CHARTS:-${1:-}}
89
if [ -n "$CHANGED_CHARTS" ];
@@ -12,6 +13,13 @@ else
1213
CHART_DIRS=$(ls -d charts/*)
1314
fi
1415

16+
KUBECONFORM_OPTS="\
17+
--strict \
18+
--summary \
19+
--schema-location default \
20+
--schema-location https://raw.githubusercontent.com/datreeio/CRDs-catalog/main/{{.Group}}/{{.ResourceKind}}_{{.ResourceAPIVersion}}.json \
21+
"
22+
1523
# install kubeconform
1624
curl --silent --show-error --fail --location --output /tmp/kubeconform.tar.gz "https://github.com/yannh/kubeconform/releases/download/${KUBECONFORM_VERSION}/kubeconform-${OS}-amd64.tar.gz"
1725
tar -xf /tmp/kubeconform.tar.gz kubeconform
@@ -22,11 +30,11 @@ for CHART_DIR in ${CHART_DIRS}; do
2230
helm dep up "${CHART_DIR}"
2331
for VALUES_FILE in $(find "${CHART_DIR}/ci" -name '*values.yaml'); do
2432
helm template --kube-version "${KUBERNETES_VERSION#v}" --values "${VALUES_FILE}" "${CHART_DIR}" \
25-
| ./kubeconform --strict --summary --kubernetes-version "${KUBERNETES_VERSION#v}"
33+
| ./kubeconform $KUBECONFORM_OPTS --kubernetes-version "${KUBERNETES_VERSION#v}"
2634
for OPTION_FILE in $(find "${CHART_DIR}/ci" -name '*option.yaml'); do
2735
echo "== Checking values file: ${VALUES_FILE} and option file: ${OPTION_FILE}"
2836
helm template --kube-version "${KUBERNETES_VERSION#v}" --values "${VALUES_FILE}" --values "${OPTION_FILE}" "${CHART_DIR}" \
29-
| ./kubeconform --strict --summary --kubernetes-version "${KUBERNETES_VERSION#v}"
37+
| ./kubeconform $KUBECONFORM_OPTS --kubernetes-version "${KUBERNETES_VERSION#v}"
3038
done
3139
done
3240
done

.github/workflows/ci.yaml

Lines changed: 7 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -93,12 +93,12 @@ jobs:
9393
# When changing versions here, check that the version exists at:
9494
# https://github.com/yannh/kubernetes-json-schema
9595
k8s:
96-
- v1.28.2
96+
- v1.32.2
97+
- v1.31.6
98+
- v1.30.10
99+
- v1.29.10
100+
- v1.28.15
97101
- v1.27.6
98-
- v1.26.5
99-
- v1.25.2
100-
- v1.24.2
101-
- v1.22.9
102102
steps:
103103
- name: Checkout
104104
uses: actions/checkout@v3
@@ -122,12 +122,8 @@ jobs:
122122
matrix:
123123
# Only keep a couple because they take ~5 min each to run :(
124124
k8s:
125-
- v1.26.4
126-
# - v1.25.2
127-
# - v1.24.2
128-
- v1.22.9
129-
# - v1.18.20
130-
# - v1.16.15
125+
- v1.31.6
126+
- v1.27.6
131127
steps:
132128
- name: Checkout
133129
uses: actions/checkout@v3

charts/retool/Chart.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@ apiVersion: v2
22
name: retool
33
description: A Helm chart for Kubernetes
44
type: application
5-
version: 6.4.2
5+
version: 6.4.3
66
maintainers:
77
- name: Retool Engineering
88
email: engineering+helm@retool.com
Lines changed: 14 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,14 @@
1+
externalSecrets:
2+
enabled: false
3+
includeConfigSecrets: false
4+
name: retool-config
5+
externalSecretsOperator:
6+
enabled: true
7+
backendType: secretsManager
8+
useLegacyCR: false
9+
secretStoreRef:
10+
name: retool
11+
kind: SecretStore
12+
secretRef:
13+
- name: retool-config
14+
path: mysecret

charts/retool/templates/externalsecret.yaml

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -24,10 +24,10 @@ metadata:
2424
name: {{ .name }}
2525
namespace: {{ $.Release.Namespace }}
2626
spec:
27-
refreshInterval: {{ .Values.externalSecrets.externalSecretsOperator.refreshInterval }}
27+
refreshInterval: {{ $.Values.externalSecrets.externalSecretsOperator.refreshInterval }}
2828
secretStoreRef:
29-
name: {{ .Values.externalSecrets.externalSecretsOperator.secretStoreRef.name }}
30-
kind: {{ .Values.externalSecrets.externalSecretsOperator.secretStoreRef.kind }}
29+
name: {{ $.Values.externalSecrets.externalSecretsOperator.secretStoreRef.name }}
30+
kind: {{ $.Values.externalSecrets.externalSecretsOperator.secretStoreRef.kind }}
3131
target:
3232
name: {{ .name }}
3333
creationPolicy: Owner

0 commit comments

Comments
 (0)